KFS Request
  1. KFS Request
  2. KFSMI-940

AbstractLookupableHelperServiceImpl validateSearchParameters throws excepton if errorMap is not empty, which makes LookupAction search call unusable in some situations

    Details

    • Type: Enhancement Enhancement
    • Status: Rice Roadblock Rice Roadblock
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: TBD
    • Sub-Committee:
      Tech / QA / PM
    • Impacted Modules:
      System

      Description

      We have a situation in budget where we are doing some extra processing of lookup results (overriding LookupAction), if there are errors we add them to GlobalVariables errorMap and then call LookupAction.search to redisplay the search
      results. LookupAction:search calls validateSearchParameters on lookupable, which calls lookupableHelperService and the default AbstractLookupableHelperServiceImpl implementation. The default implementation throws an exception at the
      end of processing if the errorMap is not empty:

      if (!GlobalVariables.getErrorMap().isEmpty())

      { throw new ValidationException("errors in search criteria"); }

      So if there were errors previous to the method call but the validation was OK an exception will still be thrown. I believe it would be better if the method just checked for errors encountered within the method itself (maybe by a boolean) and then throw
      an exception, allowing for the errorMap to contain errors from previous code.

        Issue Links

          Activity

          Hide
          Jerry Neal (Inactive) added a comment -

          This is still an issue, should fix in KRAD

          Show
          Jerry Neal (Inactive) added a comment - This is still an issue, should fix in KRAD

            People

            • Reporter:
              Jerry Neal (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:

                Structure Helper Panel