KFS Request
  1. KFS Request
  2. KFSMI-940

AbstractLookupableHelperServiceImpl validateSearchParameters throws excepton if errorMap is not empty, which makes LookupAction search call unusable in some situations

    Details

    • Type: Enhancement Enhancement
    • Status: Rice Roadblock Rice Roadblock
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: TBD
    • Sub-Committee:
      Tech / QA / PM
    • Impacted Modules:
      System

      Description

      We have a situation in budget where we are doing some extra processing of lookup results (overriding LookupAction), if there are errors we add them to GlobalVariables errorMap and then call LookupAction.search to redisplay the search
      results. LookupAction:search calls validateSearchParameters on lookupable, which calls lookupableHelperService and the default AbstractLookupableHelperServiceImpl implementation. The default implementation throws an exception at the
      end of processing if the errorMap is not empty:

      if (!GlobalVariables.getErrorMap().isEmpty())

      { throw new ValidationException("errors in search criteria"); }

      So if there were errors previous to the method call but the validation was OK an exception will still be thrown. I believe it would be better if the method just checked for errors encountered within the method itself (maybe by a boolean) and then throw
      an exception, allowing for the errorMap to contain errors from previous code.

        Issue Links

          Activity

          Ailish Byrne made changes -
          Field Original Value New Value
          Fix Version/s Release ? [ 13530 ]
          Assignee Rice Team [ riceteam ]
          Ailish Byrne made changes -
          Link This issue is duplicated by KULRICE-1979 [ KULRICE-1979 ]
          Kymber Horn made changes -
          KFS Test Item [ZZZ:Release ?]
          Ailish Byrne made changes -
          Lead abyrne jkneal
          Jerry Neal (Inactive) made changes -
          Link This issue is related to KRRM-66 [ KRRM-66 ]
          made changes -
          Link This issue is related to KRRM-87 [ KRRM-87 ]
          Jerry Neal (Inactive) made changes -
          Link This issue is related to KRRM-87 [ KRRM-87 ]
          Kymber Horn made changes -
          Module System
          Jerry Neal (Inactive) made changes -
          Lead jkneal dlemus
          Ailish Byrne made changes -
          Workflow custom [ 55332 ] KFSMI [ 105165 ]
          Ailish Byrne made changes -
          Contribution Indicator No
          Ailish Byrne made changes -
          Module System No Functional Impact (Technical Issue)
          Ailish Byrne made changes -
          Functional Impact(s) [No Functional Impact (Technical, QA or PM Issue)]
          Impacted Modules [System]
          Ailish Byrne made changes -
          Functional Impact(s) [No Functional Impact (Technical, QA or PM Issue)] [None: Tech/QA/PM]
          Ailish Byrne made changes -
          Functional Experts [None: Tech/QA/PM] [Tech / QA / PM]
          Ailish Byrne made changes -
          Workflow KFSMI [ 105165 ] KFSMI2 [ 115488 ]
          Ailish Byrne made changes -
          Workflow KFSMI2 [ 115488 ] KFSMI [ 123073 ]
          Ailish Byrne made changes -
          Contributing Partner Not Applicable
          Ailish Byrne made changes -
          Status Open [ 1 ] Awaiting Prioritization [ 10018 ]
          Hide
          Jerry Neal (Inactive) added a comment -

          This is still an issue, should fix in KRAD

          Show
          Jerry Neal (Inactive) added a comment - This is still an issue, should fix in KRAD
          Jerry Neal (Inactive) made changes -
          Link This issue discovered KULRICE-8554 [ KULRICE-8554 ]
          Ailish Byrne made changes -
          Workflow KFSMI [ 123073 ] Copy of KFSMI [ 169021 ]
          Ailish Byrne made changes -
          Workflow Copy of KFSMI [ 169021 ] KFSMI [ 178943 ]
          Ailish Byrne made changes -
          Status Awaiting Prioritization [ 10018 ] Open [ 1 ]
          Ailish Byrne made changes -
          Workflow KFSMI [ 178943 ] Copy of KFSMI [ 272128 ]
          Ailish Byrne made changes -
          Component/s Development [ 11760 ]
          Ailish Byrne made changes -
          Workflow Copy of KFSMI [ 272128 ] KFSMI [ 282838 ]
          Ailish Byrne made changes -
          Status Open [ 1 ] Rice Roadblock [ 10075 ]
          Ailish Byrne made changes -
          Assignee Rice Team [ riceteam ]
          Ailish Byrne made changes -
          Workflow KFSMI [ 282838 ] KFSMI 2 [ 361673 ]
          Ailish Byrne made changes -
          Workflow KFSMI 2 [ 361673 ] KFSMI [ 364506 ]

            People

            • Reporter:
              Jerry Neal (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:

                Structure Helper Panel