KFS Archive
  1. KFS Archive
  2. KFSOLD-23383

CAMS - NPE when initiating Asset Manual Payment Document

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: Canceled/Declined
    • Labels:
      None
    • Sub-Committee:
      CAM / CAB
    • Impacted Modules:
      Capital Asset Management
    • Contributing Partner:
      University of Maryland
    • Rice Change Required?:
      No
    • Rice Data:
      No Change
    • Data Structures:
      No Change
    • KFS Data:
      No Change
    • Configuration Properties:
      No Change
    • Libraries:
      No Change

      Description

      When initiating the manual asset payment document, the form is trying to retrieve the document from the session but if the session is disabled or document number is null then it will throw an null pointer exception. It may not be a problem at foundation but at UMD we are using rice 2.2.3 and we are seeing this NPE behavior.

        Issue Links

          Activity

          Barb Sutton made changes -
          Field Original Value New Value
          Sub-Committee CAM / CAB [ 13964 ]
          Source Branch TBD [ 13927 ]
          Boyd Shumaker (Inactive) made changes -
          Status Project Review [ 10009 ] Project Review [ 10009 ]
          Functional Proposal Accepted? Unspecified [ 14625 ] Yes [ 14166 ]
          Boyd Shumaker (Inactive) made changes -
          Status Project Review [ 10009 ] Project Review [ 10009 ]
          Functional Proposal Accepted? Yes [ 14166 ] Unspecified [ 14625 ]
          Barb Sutton made changes -
          Functional Liaison chenise
          Hide
          Boyd Shumaker (Inactive) added a comment -

          I can't reproduce this, however, I don't have an enviroment running rice 2.2.3. Possibly this will be needed in the future but right now, I'm not sure there is anything to fix.

          Show
          Boyd Shumaker (Inactive) added a comment - I can't reproduce this, however, I don't have an enviroment running rice 2.2.3. Possibly this will be needed in the future but right now, I'm not sure there is anything to fix.
          Hide
          Muddu Salem added a comment -

          Boyd,

          You are right about rice 2.2.3 or sessions support removed in an institute implementation. Code tries to retrieve MPAY document from a session and it will throw NPE if sessions are disabled. My understanding is that sessions support will be removed in rice 2.2.3

          Show
          Muddu Salem added a comment - Boyd, You are right about rice 2.2.3 or sessions support removed in an institute implementation. Code tries to retrieve MPAY document from a session and it will throw NPE if sessions are disabled. My understanding is that sessions support will be removed in rice 2.2.3
          Hide
          Shyam Gedela added a comment -

          Muddu,

          What does disabling session support mean? I am assuming you mean KRNS Session support (KRNS_SESN_DOC_T). Can you point us to a JIRA for this? Do you know if this is being done i Rice for performance reasons or to support functionality?

          Thanks

          Show
          Shyam Gedela added a comment - Muddu, What does disabling session support mean? I am assuming you mean KRNS Session support (KRNS_SESN_DOC_T). Can you point us to a JIRA for this? Do you know if this is being done i Rice for performance reasons or to support functionality? Thanks
          Hide
          Muddu Salem added a comment -

          Hi Shyam,

          The UMD rice group told us that in rice 2.2.3, session support will be removed because of performance issues. I believe the rice group talked to Jonathan and my understanding is that he confirmed that.

          Thanks,
          Muddu

          Show
          Muddu Salem added a comment - Hi Shyam, The UMD rice group told us that in rice 2.2.3, session support will be removed because of performance issues. I believe the rice group talked to Jonathan and my understanding is that he confirmed that. Thanks, Muddu
          Hide
          Muddu Salem added a comment -

          I checked my emails and found that Scott informed that Session Document Service was first removed in 2.3, but put back back because of some other issues, but is still slated to be removed.

          Show
          Muddu Salem added a comment - I checked my emails and found that Scott informed that Session Document Service was first removed in 2.3, but put back back because of some other issues, but is still slated to be removed.
          Bryan Hutchinson made changes -
          Link This issue relates to KULRICE-9148 [ KULRICE-9148 ]
          Hide
          Bryan Hutchinson added a comment - - edited

          Muddu,

          I linked some Rice JIRAs that I think are related.

          KULRICE-9148 - Rice JIRA for disabling the session document service in Rice 2.1.3/2.2.2
          KULRICE-9358 - Rice JIRA to put at least some of that functionality back in Rice 2.1.6/2.2.4 because of unintended side-effects.
          KULRICE-9380 - Rice JIRA for related future refactoring currently in 2.3-backlog

          Here's also a link to KTI meeting minutes where this was discussed: https://wiki.kuali.org/x/IB1UEw

          I'm wondering if you ran up against one of the unintended side-effects of the original change at UMD and if upgrading to Rice 2.2.4 (or pulling in the related fix to your 2.2.3) would address it?

          I don't think there is currently anything for us to do in KFS since the issues we originally found have been corrected, the important functionality was put back, and we don't have any plans to move KFS to the 2.2.x Rice line. We're on 2.1.6 and plan to stay on the 2.1.x line until we move to KRAD with 2.4.

          Thanks,
          Bryan

          Show
          Bryan Hutchinson added a comment - - edited Muddu, I linked some Rice JIRAs that I think are related. KULRICE-9148 - Rice JIRA for disabling the session document service in Rice 2.1.3/2.2.2 KULRICE-9358 - Rice JIRA to put at least some of that functionality back in Rice 2.1.6/2.2.4 because of unintended side-effects. KULRICE-9380 - Rice JIRA for related future refactoring currently in 2.3-backlog Here's also a link to KTI meeting minutes where this was discussed: https://wiki.kuali.org/x/IB1UEw I'm wondering if you ran up against one of the unintended side-effects of the original change at UMD and if upgrading to Rice 2.2.4 (or pulling in the related fix to your 2.2.3) would address it? I don't think there is currently anything for us to do in KFS since the issues we originally found have been corrected, the important functionality was put back, and we don't have any plans to move KFS to the 2.2.x Rice line. We're on 2.1.6 and plan to stay on the 2.1.x line until we move to KRAD with 2.4. Thanks, Bryan
          Bryan Hutchinson made changes -
          Link This issue relates to KULRICE-9358 [ KULRICE-9358 ]
          Bryan Hutchinson made changes -
          Link This issue relates to KULRICE-9380 [ KULRICE-9380 ]
          Hide
          Muddu Salem added a comment -

          Thanks, Bryan. I will look into the related rice jiras. I should mention that the NPE issue is not a problem with foundation code on int and we tested and confirmed that it works correctly there. If session document server ever removed then we need to refactor the code in KFS to fix the NPE issue

          Show
          Muddu Salem added a comment - Thanks, Bryan. I will look into the related rice jiras. I should mention that the NPE issue is not a problem with foundation code on int and we tested and confirmed that it works correctly there. If session document server ever removed then we need to refactor the code in KFS to fix the NPE issue
          Hide
          Bryan Hutchinson added a comment -

          Muddu,

          Given that, I think this contribution should be cancelled, and the linked KFSMI JIRA should be closed as "won't fix". If/when Rice makes more changes related to the session document service in a version we're using for KFS, we'll keep an eye out for the NPE you saw.

          Thanks,
          Bryan

          Show
          Bryan Hutchinson added a comment - Muddu, Given that, I think this contribution should be cancelled, and the linked KFSMI JIRA should be closed as "won't fix". If/when Rice makes more changes related to the session document service in a version we're using for KFS, we'll keep an eye out for the NPE you saw. Thanks, Bryan
          Hide
          Muddu Salem added a comment -

          This issue will be revisited when rice 2.2 removes session document service support.

          Show
          Muddu Salem added a comment - This issue will be revisited when rice 2.2 removes session document service support.
          Muddu Salem made changes -
          Status Project Review [ 10009 ] Cancelled [ 10017 ]
          Ailish Byrne made changes -
          Workflow KFSCNTRB [ 197933 ] KFSCNTRB - Non-Enhancements [ 252331 ]
          Ailish Byrne made changes -
          Workflow KFSCNTRB - Non-Enhancements [ 252331 ] KFSCNTRB Old [ 253734 ]
          Ailish Byrne made changes -
          Workflow KFSCNTRB Old [ 253734 ] KFSCNTRB - Non-Enhancements [ 255136 ]
          Ailish Byrne made changes -
          Workflow KFSCNTRB - Non-Enhancements [ 255136 ] Copy of KFSCNTRB - Non-Enhancements [ 264155 ]
          Ailish Byrne made changes -
          Workflow Copy of KFSCNTRB - Non-Enhancements [ 264155 ] KFSCNTRB - Non-Enhancements [ 265647 ]
          Hide
          Theresa Cain added a comment -

          IU contribution KFSCNTRB-1809 will fix this for the foundation.

          Show
          Theresa Cain added a comment - IU contribution KFSCNTRB-1809 will fix this for the foundation.
          Ailish Byrne made changes -
          Fix Version/s TBD [ 17544 ]
          Ailish Byrne made changes -
          Functionally Impacting Unspecified [ 16029 ]
          Technically Impacting Unspecified [ 16032 ]
          Ailish Byrne made changes -
          Code Reverted No [ 16034 ]
          Ailish Byrne made changes -
          Libraries Added? No [ 14165 ] Yes [ 14164 ]
          Libraries No Change [ 16045 ]
          Heather Elyea made changes -
          Project KFS Contribution [ 10670 ] KFS Archive [ 11293 ]
          Key KFSCNTRB-1565 KFSOLD-23383
          Workflow KFSCNTRB - Non-Enhancements [ 265647 ] KFSOLD [ 377736 ]
          Status Cancelled [ 10017 ] Closed [ 6 ]
          Required Deliverables Source Code,Functional Specification,Testing Scenario(s) or Selenium Test(s) [ 13858, 13859, 14192 ]
          Watchers Kris Keithly, Theresa Cain [ ktopher, tcain ]
          Technical Proposal Accepted? Unspecified [ 14626 ]
          Functional Proposal Accepted? Unspecified [ 14625 ]
          Fix Version/s Canceled/Declined [ 17951 ]
          Fix Version/s TBD [ 17544 ]
          Reporter Muddu Salem [ mksalem ]
          Development Hours 1
          Code Reverted No [ 16034 ]
          Functional Sponsor Chenise Patterson [ chenise ]
          Contributing Developer Muddu Salem [ mksalem ]
          Technical Liaison Muddu Salem [ mksalem ]
          Pending Deliverables Source Code,Functional Specification,Testing Scenario(s) or Selenium Test(s) [ 13829, 13830, 14191 ]
          CAG Representative Chenise Patterson [ chenise ]

            People

            • Assignee:
              Unassigned
              Reporter:
              Anonymous
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:

                Structure Helper Panel