KS Enrollment
  1. KS Enrollment
  2. KSENROLL-5152

KRAD renderning is slow due to Freemarker's FMParser initializing LookaheadSuccess multiple times

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: M8
    • Component/s: PDT - Red
    • Security Level: Public (Public: Anyone can view)
    • Labels:
    • KS Theme:
      Rice upgrade - Test bug fix
    • Story Points:
      1
    • KS PDT Workgroup:
      Development

      Description

      I was doing some profiling on our application and a huge amount of time is being spent in the initialization of FMParser which is creating an exception called LookaheadSuccess. The way the exception is initialized many times, it will always fill in the stacktrace which is a very expensive operation and could be made much faster using a static variable. This has the potential to give KRAD a noticeable performance gain.
      See: http://freemarker.624813.n4.nabble.com/Flow-control-by-Exception-td626112.html

        Issue Links

          Activity

          Hide
          Daniel Epstein (Inactive) added a comment -

          Added a temp fix. Shaved off ~5 seconds (although it's still taking a long time)

          Show
          Daniel Epstein (Inactive) added a comment - Added a temp fix. Shaved off ~5 seconds (although it's still taking a long time)
          Hide
          Michael Passarella-George added a comment -

          If the fix was only temporary and not really addressed by a desired KRAD enhancement, I think this ticket should remain open so that we know what on the KS side to review when we plan a KRAD upgrade.

          Show
          Michael Passarella-George added a comment - If the fix was only temporary and not really addressed by a desired KRAD enhancement, I think this ticket should remain open so that we know what on the KS side to review when we plan a KRAD upgrade.
          Hide
          Daniel Epstein (Inactive) added a comment -

          Hard to test, the sources are not available for the patched version of freemarker that is currently being used

          Show
          Daniel Epstein (Inactive) added a comment - Hard to test, the sources are not available for the patched version of freemarker that is currently being used
          Hide
          Daniel Epstein (Inactive) added a comment -

          As of version 18 the code was updated.

          Show
          Daniel Epstein (Inactive) added a comment - As of version 18 the code was updated.

            People

            • Assignee:
              Daniel Epstein (Inactive)
              Reporter:
              Daniel Epstein (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 4 hours
                4h
                Remaining:
                Remaining Estimate - 4 hours
                4h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Structure Helper Panel