Uploaded image for project: 'KS Enrollment'
  1. KS Enrollment
  2. KSENROLL-9616

Remove updateViewHeaderText JS workaround for context bar

    Details

    • Type: Story
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: M8
    • Fix Version/s: M8
    • Component/s: PDT - Green
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • KS Theme:
      Rice upgrade - Revert workaround
    • Story Points:
      3
    • KS PDT Workgroup:
      Development
    • Sprint:
      Sprint 11 WC1

      Description

      Remove updateViewHeaderText javascript workaround for KSENROLL-7481: "Static Unified Page Header - Header does not update after initial view load".

      The workaround appears in about 6 files which can be found by doing a text search in IJI for "This is a work-around".

      On a related note ... David Elyea reports "... just finished KSENROLL-9437 (it's linked to 7481) and it was having some same issues with that script. I was able to remove it and get the headerText updating correctly". So, I believe it should be a simple matter of just removing the onDocumentReadyScript property from those files and testing.

        Attachments

          Issue Links

            Activity

            sudduth Glenn Sudduth (Inactive) created issue -
            sudduth Glenn Sudduth (Inactive) made changes -
            Field Original Value New Value
            Link This issue relies on KSENROLL-7481 [ KSENROLL-7481 ]
            sudduth Glenn Sudduth (Inactive) made changes -
            Link This issue relies on KULRICE-9693 [ KULRICE-9693 ]
            sudduth Glenn Sudduth (Inactive) made changes -
            Link This issue relates to KSENROLL-9437 [ KSENROLL-9437 ]
            sbarnhar Steven Barnhart (Inactive) made changes -
            Sprint Sprint 11 WC1 [ 72 ]
            sbarnhar Steven Barnhart (Inactive) made changes -
            Rank Ranked higher
            tarynlee Taryn Pedigo (Inactive) made changes -
            Fix Version/s M8 [ 16425 ]
            KS PDT Workgroup Development [ 14968 ]
            sudduth Glenn Sudduth (Inactive) made changes -
            Rank Ranked lower
            sudduth Glenn Sudduth (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            sudduth Glenn Sudduth (Inactive) made changes -
            Assignee Glenn Sudduth [ sudduth ]
            Hide
            sudduth Glenn Sudduth (Inactive) added a comment -

            When I wrote this I was under the misconception that these workarounds were for the context bar, but there was also a problem getting the view header text to update when a page was refreshed was changed. It's now possible to override the view header text in the controller methods, but there are so many methods/paths on the CourseOfferingManagementController that in my opinion it is actually much cleaner to just leave the "update view header text with javascript" work-around in place because this method consolidates the logic in a single location within the KRAD markup (which is kinda where one would expect it).

            Show
            sudduth Glenn Sudduth (Inactive) added a comment - When I wrote this I was under the misconception that these workarounds were for the context bar, but there was also a problem getting the view header text to update when a page was refreshed was changed. It's now possible to override the view header text in the controller methods, but there are so many methods/paths on the CourseOfferingManagementController that in my opinion it is actually much cleaner to just leave the "update view header text with javascript" work-around in place because this method consolidates the logic in a single location within the KRAD markup (which is kinda where one would expect it).
            sudduth Glenn Sudduth (Inactive) made changes -
            Status In Progress [ 3 ] Resolved [ 5 ]
            Resolution Won't Fix [ 2 ]
            sudduth Glenn Sudduth (Inactive) made changes -
            Status Resolved [ 5 ] Closed [ 6 ]

              People

              • Assignee:
                sudduth Glenn Sudduth (Inactive)
                Reporter:
                sudduth Glenn Sudduth (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: