Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: 2.4
    • Component/s: Code Standards
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      In ObjectPropertyUtils.java...
      in indexOfExt, there is too much nesting

      in parsePathExpression, there is too much nesting, and the method is too large
      add blank lines around if blocks
      remove blank lines before else if (...

      in getPropertyDescriptors, add a blank line above and below the try block
      add a blank line before the return

      in getReadMethod, add blank lines before each if block and before the return

      in getPropertyType, for each one statement if, keep the statement on a single line; for the if or else statements that have nested code beneath them, add braces around them

      in static <V> V get...
      remove the blank lines before each: else if (...

        Attachments

          Activity

          Hide
          mwfyffe Mark Fyffe (Inactive) added a comment -

          ObjectPropertyUtils is not complete. Will address these items under KULRICE-10063.

          Show
          mwfyffe Mark Fyffe (Inactive) added a comment - ObjectPropertyUtils is not complete. Will address these items under KULRICE-10063 .
          Hide
          mwfyffe Mark Fyffe (Inactive) added a comment -

          KULRICE-10063 has been completed. The items referred to in this JIRA no longer refer to code present in ObjectPropertyUtils.

          Will look for a new code report if the completed version has issues

          Show
          mwfyffe Mark Fyffe (Inactive) added a comment - KULRICE-10063 has been completed. The items referred to in this JIRA no longer refer to code present in ObjectPropertyUtils. Will look for a new code report if the completed version has issues

            People

            • Assignee:
              mwfyffe Mark Fyffe (Inactive)
              Reporter:
              matthew.wuertz Matthew Wuertz (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: