Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-10149

Remove all reference to now deprecated SequenceAccessorService and DatabasePlatform.getNextValueSQL

    Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.4
    • Component/s: Development, JPA, Roadmap
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-4387Remove all deprecated code
      KULRICE-1735Deprecate DocumentBase.getDocumentRepresentationForSerialization()
      KULRICE-11616Replace usage of SequenceAccessorService with MaxValueIncrementerFactory in KRMS
      KULRICE-11617Replace usage of SequenceAccessorService with MaxValueIncrementerFactory in KIM
      KULRICE-10023Deprecate SequenceAccessorService in favor of MaxValueIncrementerFactory
      KULRICE-12481Fix/remove all references to OJB in the KRAD Guide
      KULRICE-4460Replace all references to oracle.jdbc.driver.OracleDriver with oracle.jdbc.OracleDriver
      KULRICE-2322Remove all references to "Onestart" in the Rice codebase
      KULRICE-4637Remove deprecated code
      KULRICE-1290Remove/Rename all references to "eden", "en", "Onestart"
    • Sprint:
      2.4.0-m4 JPA Sprint 2
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      These are deprecated now. We need to make sure all references use the new setup. In a lot of cases this may mean having to have a DataSource or similar injected. I actually thought it might not be a bad idea to crate a MaxValueIncrementerFactoryBean which can be configured as a FactoryBean in spring and produces a DataFieldMaxValueIncrementer when created. That would allow for the incrementer to be injected where needed rather than having to inject a whole DataSource instance. Elsewhere, we need to use MaxValueIncrementerFactory to accomplish this.

        Issue Links

          Activity

          Hide
          Eric Westfall added a comment -

          Resolving this issue as I had already replaced a number of these awhile back. The references remaining are in KIM, KRMS, and the KNS. The KNS ones can stay because SequenceAccessorService is still used by KNS code. But KIM and KRMS should be converted upon conversion of those modules to JPA. I created separate jiras for those (see linked jiras).

          Show
          Eric Westfall added a comment - Resolving this issue as I had already replaced a number of these awhile back. The references remaining are in KIM, KRMS, and the KNS. The KNS ones can stay because SequenceAccessorService is still used by KNS code. But KIM and KRMS should be converted upon conversion of those modules to JPA. I created separate jiras for those (see linked jiras).

            People

            • Assignee:
              Eric Westfall
              Reporter:
              Eric Westfall
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1 hour
                1h
                Remaining:
                0m
                Logged:
                Time Not Required
                Not Specified

                  Agile

                    Structure Helper Panel