Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Complete
    • Affects Version/s: 2.3
    • Fix Version/s: 2.5
    • Labels:
      None
    • Similar issues:
      KULRICE-14271Blanket approve displays "Confirm Navigation" dialog
      KULRICE-11850Create Confirmation Dialog on Maintenance Document Submit
      KULRICE-13187Change to dialog default size from small to default
      KULRICE-12643Select box in dialog not posted to server
      KULRICE-12806Add "Do not show me this again" on Multi-file Upload collection line delete confirmation
      KULRICE-8397Breadcrumbs sometimes display with weird structure when the page is using Dialog lightbox
      KULRICE-8654Client Ajax Dialog's buttons render as check boxes
      KULRICE-12793Dialog box display issues
      KULRICE-13131Confirmation Dialog is hidden when Action defaults to hidden
      KULRICE-10593Confirmation dialog comes up when moving from one control to the other in the KRAD Library
    • Epic Link:
    • Rice Module:
      KRAD
    • KRAD Feature Area:
      UIF Component
    • Application Requirement:
      KS
    • Sprint:
      2.5.0-m1 Sprint 3, 2.5.0-m2 Sprint 1
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      KS would like to have a common look-and-feel with all of the various types of dialog we use.

      One common case we have is the use of a Confirmation Dialog. Ie. A user wants to delete something from the screen, it will pop-up a confirmation messaging asking if this is what the user wants to do.

      Right now this isn't possible because the DialogGroup requires a round trip to the server, which for a confirmation dialog isn't necessary or wanted.

      We would like a pure, client side, confirmation dialog. We would need to be able to put it on an action, have it pop-up and block the action until the user has input, then do nothing, or let the action take place.

      1. confirmationDialogs.patch
        7 kB
        Jerry Neal
      1. screenshot-1.jpg
        119 kB

        Issue Links

          Activity

          Hide
          Jerry Neal (Inactive) added a comment -

          Peter,

          This is a really important issue for KS.

          Jerry

          Show
          Jerry Neal (Inactive) added a comment - Peter, This is a really important issue for KS. Jerry
          Hide
          Jerry Neal (Inactive) added a comment -

          I put together some code I think will allow you to use dialogs for confirmations. We should be able to make it easier in the framework, but I wanted to get you something you can apply without code changes.

          First, add these bean:

          <bean id="Uif-Confirmation" parent="Uif-Yes-No-DialogGroup">
          <property name="onDialogResponseScript">
          <null/>
          </property>
          </bean>

          Second, apply the included patch to krad.request.js.

          Now you can use the confirmations like this:

          <bean parent="Uif-PrimaryActionButton" p:methodToCall="refresh" p:actionLabel="Confirm Me"
          p:preSubmitCall="return kradRequest.confirm('Demo-Confirmation');"/>

          The key is the preSubmitCall, you can put this on any action you want to confirm. The argument to the confirm method is the id for the confirmation dialog.

          Then you also need to include the dialog group as usual:

          <bean id="Demo-Confirmation" parent="Uif-Confirmation"
          p:headerText="Are you sure you want to confirm this action?"/>

          Let me know if you have any questions.

          I looked into the Bootstrap modal a bit as well. We likely will end up moving our dialogs this. However, they don’t do blocking either so we would need to add code as well (there are some other plugins out there that help). Note this is only built into the action right now, if you want to just show a confirmation from any script we’ll need something else. I hope to look into this when we have time to work on the Jira.

          Show
          Jerry Neal (Inactive) added a comment - I put together some code I think will allow you to use dialogs for confirmations. We should be able to make it easier in the framework, but I wanted to get you something you can apply without code changes. First, add these bean: <bean id="Uif-Confirmation" parent="Uif-Yes-No-DialogGroup"> <property name="onDialogResponseScript"> <null/> </property> </bean> Second, apply the included patch to krad.request.js. Now you can use the confirmations like this: <bean parent="Uif-PrimaryActionButton" p:methodToCall="refresh" p:actionLabel="Confirm Me" p:preSubmitCall="return kradRequest.confirm('Demo-Confirmation');"/> The key is the preSubmitCall, you can put this on any action you want to confirm. The argument to the confirm method is the id for the confirmation dialog. Then you also need to include the dialog group as usual: <bean id="Demo-Confirmation" parent="Uif-Confirmation" p:headerText="Are you sure you want to confirm this action?"/> Let me know if you have any questions. I looked into the Bootstrap modal a bit as well. We likely will end up moving our dialogs this. However, they don’t do blocking either so we would need to add code as well (there are some other plugins out there that help). Note this is only built into the action right now, if you want to just show a confirmation from any script we’ll need something else. I hope to look into this when we have time to work on the Jira.
          Hide
          David Poindexter (Inactive) added a comment - - edited

          There probably are solutions for the blocking modal. A quick searched turned up this one that is based on both Bootstrap and jQuery:

          http://bootboxjs.com/

          Additionally, v3 of bootstrap does do blocking out of the box via a modal option (not sure if it could be backported to 2.3.2):

          http://getbootstrap.com/javascript/#modals

          Show
          David Poindexter (Inactive) added a comment - - edited There probably are solutions for the blocking modal. A quick searched turned up this one that is based on both Bootstrap and jQuery: http://bootboxjs.com/ Additionally, v3 of bootstrap does do blocking out of the box via a modal option (not sure if it could be backported to 2.3.2): http://getbootstrap.com/javascript/#modals
          Hide
          Jessica Coltrin (Inactive) added a comment -

          moving to 2.4 since it's not a bug fix.

          Show
          Jessica Coltrin (Inactive) added a comment - moving to 2.4 since it's not a bug fix.
          Hide
          Jerry Neal (Inactive) added a comment -
          Show
          Jerry Neal (Inactive) added a comment - Related to https://jira.kuali.org/browse/KULRICE-10756
          Hide
          Christie Heitkamp (Inactive) added a comment -

          This is a much needed enhancement. The confirmation messages displaying on a separate page and requiring browser refresh was identified as a usability issue previously. Need to make sure in mobile that the confirmation message is not off of the viewport.

          Show
          Christie Heitkamp (Inactive) added a comment - This is a much needed enhancement. The confirmation messages displaying on a separate page and requiring browser refresh was identified as a usability issue previously. Need to make sure in mobile that the confirmation message is not off of the viewport.

            People

            • Assignee:
              Jerry Neal (Inactive)
              Reporter:
              Garey Taylor
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 2 days Original Estimate - 2 days
                2d
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 days
                4d

                  Agile

                    Structure Helper Panel