Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-10455

Support for retrieving attachments which have been linked to properties on the business object itself

        Details

        • Type: Bug Fix Bug Fix
        • Status: Closed Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: 2.3
        • Fix Version/s: 2.4
        • Component/s: Development
        • Security Level: Public (Public: Anyone can view)
        • Labels:
          None
        • Similar issues:
          KULRICE-13808Create smoke test for retrieving attachments which have been linked to properties on the business object itself
          KULRICE-11379sample for M29
          KULRICE-9526Document which classes have been deprecated and why they have been deprecated
          KULRICE-3911Business Object copy needs to be flexible
          KULRICE-3716Create a "Business Object Observer" framework
          KULRICE-8034Business object validation is validating reference objects when it should not
          KULRICE-9287KualiLookupableTest fails in CI with Lookup not defined for business object class org.kuali.rice.krad.test.document.bo.Account
          KULRICE-8467JS error in IE8 " Object doesn't support this property or method "
          KULRICE-2279Add support to retrieve the user authentication Id directly from the workflowUser object
          KULRICE-4736Support for dynamic business objects
        • Rice Module:
          KRAD
        • Sprint:
          2.4.0-m2 KRAD Sprint 4, 2.4.0-m3 KRAD Sprint 1
        • KAI Review Status:
          Not Required
        • KTI Review Status:
          Not Required
        • Code Review Status:
          Not Required
        • Include in Release Notes?:
          Yes

          Description

          Convert KNS functionality to retrieve attachments that are linked to a BO property. You probably just need to convert struts file form to spring for populateDocumentAttachment() in MaintenanceDocumentBase. A sample of the KNS functionality is at https://jira.kuali.org/browse/KULRICE-5130.

          1. Text File
            AttachmentSample1.patch
            19 kB
            Jeff Ruch
          2. Text File
            KULRICE-10455.patch
            13 kB
            Kristina Taylor

            Issue Links

            is related to

            Task - A task that needs to be done. KULRICE-13808 Create smoke test for retrieving attachments which have been linked to properties on the business object itself

            • Major - Major loss of function.
            • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
            is relied upon by

            Task - A task that needs to be done. KULRICE-5363 Inquiry - Support for displaying bo attachments and downloading

            • Major - Major loss of function.
            • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
            relates to

            New Feature - A new feature of the product, which has yet to be developed. KULRICE-5130 Sample Maintenance Document for testing attachments

            • Minor - Minor loss of function, or other problem where easy workaround is present.
            • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

              Activity

              Ascending order - Click to sort in descending order
              Jeff Ruch made changes -
              Field Original Value New Value
              Link This issue relates to KULRICE-5130 [ KULRICE-5130 ]
              Hide
              Permalink
              Jeff Ruch added a comment -

              This is a good example of the functionality in KNS

              Show
              Jeff Ruch added a comment - This is a good example of the functionality in KNS
              Hide
              Permalink
              Jeff Ruch added a comment -

              Note there are two types of attachments (PersistableAttachment and PersistableAttachmentList).

              Show
              Jeff Ruch added a comment - Note there are two types of attachments (PersistableAttachment and PersistableAttachmentList).
              Jeff Ruch made changes -
              Link This issue is related to KULRICE-10456 [ KULRICE-10456 ]
              Jeff Ruch made changes -
              Link This issue relates to KULRICE-10463 [ KULRICE-10463 ]
              Jeff Ruch made changes -
              Link This issue relates to KULRICE-10463 [ KULRICE-10463 ]
              Peter Giles (Inactive) made changes -
              Fix Version/s 2.4 [ 16913 ]
              Fix Version/s 2.3.1 [ 17053 ]
              Kristina Taylor (Inactive) made changes -
              Link This issue is relied upon by KULRICE-5363 [ KULRICE-5363 ]
              Hide
              Permalink
              Kristina Taylor (Inactive) added a comment -

              I was working on attachments for another issue and adapted this example for an attachment maintenance document. The patch should help jumpstart this issue.

              Show
              Kristina Taylor (Inactive) added a comment - I was working on attachments for another issue and adapted this example for an attachment maintenance document. The patch should help jumpstart this issue.
              Kristina Taylor (Inactive) made changes -
              Attachment KULRICE-10455.patch [ 72476 ]
              Peter Giles (Inactive) made changes -
              Original Estimate 1 day, 4 hours [ 43200 ]
              Remaining Estimate 1 day, 4 hours [ 43200 ]
              Peter Giles (Inactive) made changes -
              Sprint 2.4.0-m2 KRAD Sprint 4 [ 92 ]
              Peter Giles (Inactive) made changes -
              Rank Ranked lower
              Jeff Ruch made changes -
              Assignee Jeff Ruch [ jruch ]
              Jeff Ruch made changes -
              Status Open [ 1 ] In Progress [ 3 ]
              Permalink
              Jeff Ruch logged work - 15/Oct/13 11:13 AM
              • Time Spent:
                2 days, 4 hours
                 
                <No comment>
              Jeff Ruch made changes -
              Remaining Estimate 1 day, 4 hours [ 43200 ] 0 minutes [ 0 ]
              Time Spent 2 days, 4 hours [ 72000 ]
              Worklog Id 89416 [ 89416 ]
              Jeff Ruch made changes -
              Original Estimate 1 day, 4 hours [ 43200 ] 4 days [ 115200 ]
              Hide
              Permalink
              Jeff Ruch added a comment -

              Converted all fileForm to multiPartFiles.

              Show
              Jeff Ruch added a comment - Converted all fileForm to multiPartFiles.
              Hide
              Permalink
              Jeff Ruch added a comment -

              JPA breaks existing implementation (including KNS). Need to remove refreshAttachment and refreshAttachmentList from MaintenanceDocumentBase to resolve.

              Show
              Jeff Ruch added a comment - JPA breaks existing implementation (including KNS). Need to remove refreshAttachment and refreshAttachmentList from MaintenanceDocumentBase to resolve.
              Jessica Coltrin (Inactive) made changes -
              Rank Ranked higher
              Jessica Coltrin (Inactive) made changes -
              Sprint 2.4.0-m2 KRAD Sprint 4 [ 92 ] 2.4.0-m2 KRAD Sprint 4, 2.4.0-m3 KRAD Sprint 1 [ 92, 99 ]
              Hide
              Permalink
              Jeff Ruch added a comment -

              BO Attachments Sample

              Show
              Jeff Ruch added a comment - BO Attachments Sample
              Jeff Ruch made changes -
              Attachment AttachmentSample.patch [ 73148 ]
              Permalink
              Jeff Ruch logged work - 19/Oct/13 1:30 AM
              • Time Spent:
                1 day, 4 hours
                 
                Removed changes that matched functionality of KNS. Ended up overriding downloadBOAttachment method. Tested with sample (attached) both BO and regular attachments that are linked to a note.
              Jeff Ruch made changes -
              Time Spent 2 days, 4 hours [ 72000 ] 4 days [ 115200 ]
              Worklog Id 89577 [ 89577 ]
              Hide
              Permalink
              Jeff Ruch added a comment -

              Sample attached. Notice that the main issue with attachments is that the multiPartFile needs to be converted into file name, content type, and byte[]. The easiest way to do this is in the BO (as you can see in the sample). Once a multiPartFile attachmentFile is set, the BO sets the relevant fields so that it can be saved in the data.

              For downloads, the old KNS action used a downloadAttachment method. This method was flawed because it could not support documents with both attachments and bo attachments. In order to fix that, I overrode the downloadBOAttachment method on the maintenance document controller.

              Show
              Jeff Ruch added a comment - Sample attached. Notice that the main issue with attachments is that the multiPartFile needs to be converted into file name, content type, and byte[]. The easiest way to do this is in the BO (as you can see in the sample). Once a multiPartFile attachmentFile is set, the BO sets the relevant fields so that it can be saved in the data. For downloads, the old KNS action used a downloadAttachment method. This method was flawed because it could not support documents with both attachments and bo attachments. In order to fix that, I overrode the downloadBOAttachment method on the maintenance document controller.
              Jeff Ruch made changes -
              Status In Progress [ 3 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Jeff Ruch made changes -
              Attachment AttachmentSample.patch [ 73148 ]
              Hide
              Permalink
              Jeff Ruch added a comment -

              BO Attachment sample

              Show
              Jeff Ruch added a comment - BO Attachment sample
              Jeff Ruch made changes -
              Attachment AttachmentSample1.patch [ 73151 ]
              Jessica Coltrin (Inactive) made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Jeff Ruch
                  Reporter:
                  Jeff Ruch
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Time Tracking

                    Estimated:
                    Original Estimate - 4 days
                    4d
                    Remaining:
                    Remaining Estimate - 0 minutes
                    0m
                    Logged:
                    Time Spent - 4 days
                    4d

                      Agile

                        Structure Helper Panel