Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-10466

Inquiry Links in Travel Account are not being rendered

    Details

    • Type: Bug Fix
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.4
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • KRAD Feature Area:
      Inquiry, Lookup
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      In the 2.4 environments, the inquiry links are no longer rendering when doing a simple lookup on TravelAccount. This seems to be due to commits from JPA via KULRICE-9988, which replaced code in InquirableImpl.buildInquirableLink from

      // if not title, then get primary relationship
      DataObjectRelationship relationship = null;
      if (inquiryObjectClass == null) {
        relationship = getDataObjectMetaDataService().getDataObjectRelationship(dataObject, objectClass, propertyName, "", true, false, true);
        if (relationship != null) {
          inquiryObjectClass = relationship.getRelatedClass();
        }
      }
      

      with

      // if not title, then get primary relationship
      inquiryObjectClass = getLegacyDataAdapter().getInquiryObjectClassIfNotTitle(dataObject,propertyName);
      

      As shown in the previous version, this needs to be surrounded by if (inquiryObjectClass == null). I confirmed that this fixes the problem but there could be a different solution possible.

        Attachments

          Issue Links

            Activity

            Hide
            kbtaylor Kristina Taylor (Inactive) added a comment -

            This may be blocked in turn by KULRICE-10462, but you can remove <bean parent="Uif-LookupCriteriaInputField" p:propertyName="fiscalOfficer.principalName" /> from TravelAccountLookup.xml to get past the block.

            Show
            kbtaylor Kristina Taylor (Inactive) added a comment - This may be blocked in turn by KULRICE-10462 , but you can remove <bean parent="Uif-LookupCriteriaInputField" p:propertyName="fiscalOfficer.principalName" /> from TravelAccountLookup.xml to get past the block.
            Hide
            cniesen Claus Niesen added a comment -

            This Jira may fix KULRICE-10493 as well. Please check this when resolved.

            Show
            cniesen Claus Niesen added a comment - This Jira may fix KULRICE-10493 as well. Please check this when resolved.
            Hide
            gilesp Peter Giles (Inactive) added a comment -

            Let's commit this, create a code review for it with an accompanying new jira for the review, and assign that to Eric. He can give it to the appropriate person on the JPA team. Sound good?

            Show
            gilesp Peter Giles (Inactive) added a comment - Let's commit this, create a code review for it with an accompanying new jira for the review, and assign that to Eric. He can give it to the appropriate person on the JPA team. Sound good?
            Hide
            kbtaylor Kristina Taylor (Inactive) added a comment -

            Created KULRICE-10558 for the code review.

            Show
            kbtaylor Kristina Taylor (Inactive) added a comment - Created KULRICE-10558 for the code review.
            Hide
            acampbell Adam Campbell (Inactive) added a comment -

            On http://env14.rice.kuali.org, performed Travel Account lookup, then clicked account number for one of the results. Inquiry successfully rendered (see screenshot).

            closing as fixed

            Show
            acampbell Adam Campbell (Inactive) added a comment - On http://env14.rice.kuali.org , performed Travel Account lookup, then clicked account number for one of the results. Inquiry successfully rendered (see screenshot). closing as fixed

              People

              • Assignee:
                kbtaylor Kristina Taylor (Inactive)
                Reporter:
                kbtaylor Kristina Taylor (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 1 hour
                  1h
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h