Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-10505

Fix Tomcat 7 jsp compilation errors in WorkgroupTab.jsp & RemoveReplaceDisplay.jsp

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3.3
    • Component/s: User Interface
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-5812JSP error on Service Registry page in Tomcat 7
      KULRICE-5843JSP Errors in Tomcat 7
      KULRICE-50721.0.3.2 fixes for Tomcat 7 support
      KULRICE-4237recursive tag on linux using a tag alias causes an error during jsp compiling on Jetty 7
      KULRICE-5124Tomcat 7 fixes for rice 2.0
      KULRICE-7386Rice doesn't compile on JDK 7 on the cli
      KULRICE-3383KualiIncidentReport.jsp doesn't work on Tomcat 5.5.27+/Tomcat 6.0 (and possibly other screens?)
      KULRICE-4434Fix issues with compilation in Eclipse
      KULRICE-4990fixing log4j errors in rice on tomcat startup
      KULRICE-3729JSPs are erroring without tomcat jasper jars
    • Rice Module:
      KEW
    • Application Requirement:
      KC
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      When doing a jsp precompilation in order to root out our app server compatibility issues we discovered a couple issues in rice. These are really simple issues to fix related to adding a space before an attribute name. Since rice support Tomcat 7, I'm wondering how these issues weren't noticed. Are these jsps still used?

      See below:

      5) simple. add a space.

      [ERROR] Failed to execute goal org.jasig.mojo.jspc:jspc-maven-plugin:2.0.0:compile (default) on project kc_project: Failed to compile JSPS: org.apache.jasper.JasperException: file:/Users/Travis/Documents/idea/ws/kuali/kc/trunk/src/main/webapp/kew/WEB-INF/jsp/removereplace/RemoveReplaceDisplay.jsp (line: 88, column: 112) The JSP specification requires that an attribute name is preceded by whitespace -> [Help 1]

      6) simple. add a space.

      [ERROR] Failed to execute goal org.jasig.mojo.jspc:jspc-maven-plugin:2.0.0:compile (default) on project kc_project: Failed to compile JSPS: org.apache.jasper.JasperException: file:/Users/Travis/Documents/idea/ws/kuali/kc/trunk/src/main/webapp/kew/WEB-INF/jsp/removereplace/WorkgroupTab.jsp (line: 72, column: 112) The JSP specification requires that an attribute name is preceded by whitespace -> [Help 1]

        Activity

        Hide
        Travis Schneeberger added a comment -

        See the linked jiras for details on how to precompile with maven. You may want to do this on trunk rice to make sure there aren't other issues lurking around.

        Show
        Travis Schneeberger added a comment - See the linked jiras for details on how to precompile with maven. You may want to do this on trunk rice to make sure there aren't other issues lurking around.
        Hide
        Gayathri Athreya added a comment -

        I have fixed the issues listed here and while krad-web seems to be alright, I see problems in the rice-middleware/web directory. For example, this is the first error I get.

        [ERROR] Failed to execute goal org.jasig.mojo.jspc:jspc-maven-plugin:2.0.0:compile (default) on project rice-web: Failed to compile JSPS: org.apache.jasper.JasperException: file:/home/gathreya/workspace2/rice-2.3/rice-middleware/web/src/main/webapp/WEB-INF/jsp/recurseTreeNode.jsp (line: 18, column: 1) File "/krad/WEB-INF/jsp/tldHeader.jsp" not found -> [Help 1]
        [ERROR] 
        

        I believe this file is in kr/WEB_INF/jsp . I am going to resolve this jira and file another one to completely investigate the JSP compilation failures.

        Show
        Gayathri Athreya added a comment - I have fixed the issues listed here and while krad-web seems to be alright, I see problems in the rice-middleware/web directory. For example, this is the first error I get. [ERROR] Failed to execute goal org.jasig.mojo.jspc:jspc-maven-plugin:2.0.0:compile ( default ) on project rice-web: Failed to compile JSPS: org.apache.jasper.JasperException: file:/home/gathreya/workspace2/rice-2.3/rice-middleware/web/src/main/webapp/WEB-INF/jsp/recurseTreeNode.jsp (line: 18, column: 1) File "/krad/WEB-INF/jsp/tldHeader.jsp" not found -> [Help 1] [ERROR] I believe this file is in kr/WEB_INF/jsp . I am going to resolve this jira and file another one to completely investigate the JSP compilation failures.
        Hide
        Gayathri Athreya added a comment - - edited

        I've checked rice-middleware and rice-framework/krad-web. The only change that is required is in recurseTreeNode.jsp. I get the above error while using tomcat7.

        <%@ include file="/krad/WEB-INF/jsp/tldHeader.jsp"%>
        

        should be

        <%@ include file="/kr/WEB-INF/jsp/tldHeader.jsp"%>
        

        Will fix in 2.3.3 as soon as 2.3.2 is out.

        Show
        Gayathri Athreya added a comment - - edited I've checked rice-middleware and rice-framework/krad-web. The only change that is required is in recurseTreeNode.jsp. I get the above error while using tomcat7. <%@ include file= "/krad/WEB-INF/jsp/tldHeader.jsp" %> should be <%@ include file= "/kr/WEB-INF/jsp/tldHeader.jsp" %> Will fix in 2.3.3 as soon as 2.3.2 is out.
        Hide
        Gayathri Athreya added a comment -

        We've decided to remove this recurseTreMode.jsp altogether since Peter says it is not used anywhere.

        Show
        Gayathri Athreya added a comment - We've decided to remove this recurseTreMode.jsp altogether since Peter says it is not used anywhere.
        Hide
        Gayathri Athreya added a comment - - edited

        Removed recurseTreeNode.jsp which fixes the last compilation issue with tomcat7. Resolving this jira.

        Show
        Gayathri Athreya added a comment - - edited Removed recurseTreeNode.jsp which fixes the last compilation issue with tomcat7. Resolving this jira.
        Hide
        Travis Schneeberger added a comment -

        Thanks a ton G

        Show
        Travis Schneeberger added a comment - Thanks a ton G

          People

          • Assignee:
            Gayathri Athreya
            Reporter:
            Travis Schneeberger
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Structure Helper Panel