Details

    • Type: Bug Fix
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3, 2.3.3, 2.4
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Rice Module:
      KNS
    • Application Requirement:
      KFS
    • Sprint:
      2.4.0-m3 KRAD Sprint 1
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      There’s a method : protected void populateFieldLevelHelpEnabled(HttpServletRequest request) in org.kuali.rice.kns.web.struts.form.KualiForm.java (the Rice version we’re working on is 2.1.7).

      This method will only invoke the CoreFrameworkServiceLocator.getParameterService().getParameterValueAsBoolean when the ENABLE_FIELD_LEVEL_HELP_IND == null, which only happens to us one time when the server start up.

      We suspect that this might be a defect because if different applications connecting to shared rice have different values for ENABLE_FIELD_LEVEL_HELP_IND parameters, they will be ignored. But we’re not sure how was this method intended to be working. Do you think this is working as designed or is it a defect ?

        Attachments

          Activity

          Hide
          gilesp Peter Giles (Inactive) added a comment -

          Hi Kristina, please fix this in 2.3. Bonus points for going test first

          My take on this one is that we should:

          • remove ENABLE_FIELD_LEVEL_HELP_IND from KualiForm
          • make the parameter check every time populateFieldLevelHelpEnabled is invoked
          • let the parameter service caching do its job to make these checks efficient
          Show
          gilesp Peter Giles (Inactive) added a comment - Hi Kristina, please fix this in 2.3. Bonus points for going test first My take on this one is that we should: remove ENABLE_FIELD_LEVEL_HELP_IND from KualiForm make the parameter check every time populateFieldLevelHelpEnabled is invoked let the parameter service caching do its job to make these checks efficient

            People

            • Assignee:
              kbtaylor Kristina Taylor (Inactive)
              Reporter:
              ctan Cathy Tan
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 4 hours
                4h
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours Time Not Required
                2h