Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-10684

Adding duplicate item to maintenance collection does not throw an error

    Details

    • Similar issues:
      KULRICE-13296Highlight duplicate property when adding duplicate item to maintenance collection
      KULRICE-13522Create Web Tests for KRAD Maintenance Collection Features
      KULRICE-11449in TermSpecification maintenance doc, items added to the Context collection should not be editable
      KULRICE-1900Problems deleting collection items in maintenance documents
      KULRICE-7418Edit maintenance docs - added collections causes old/new items alignment to be out
      KULRICE-13974 items within a collection that have a label with expression does not evaluate
      KULRICE-13214Create AFT for Duplicate Collection Item Check
      KULRICE-8073duplicated add line and items on maintenance sub-collection edit
      KULRICE-7593Problem adding content elements to collection items.
      KULRICE-5137Collection errors are being displayed twice. /work/src/org/kuali/rice/kns/service/impl/DictionaryValidationServiceImpl.java needs qualification added to validateUpdatabableReferencesRecursively(...
    • Epic Link:
    • Rice Module:
      KRAD
    • KRAD Feature Area:
      Maintenance
    • Sprint:
      UXI 2.5.0-m7 Sprint 1
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes
    • Story Points:
      5

      Description

      In the KNS, you could specify keys to check for duplicates when adding items to a maintenance collection via attributeToHighlightOnDuplicateKey. When adding a duplicate entry, it would highlight this attribute as an error. There is no such ability specify this in KRAD. Where in the KNS, this was checked on save, no code is called to do this in KRAD. If you add a duplicate entry, it will just overwrite the old one and only see one entry.

      The name we use here may not be the best solution, so we may want to adapt this in a better way for KRAD.

        Issue Links

          Activity

          Hide
          Jerry Neal (Inactive) added a comment -

          This is an item that has not been implemented in KRAD yet.

          I would suggest we can do add this to the general collection group so it can be used in places outside of KRAD. When the line is added in ViewHelperServiceImpl, it would add this check.

          Jerry

          Show
          Jerry Neal (Inactive) added a comment - This is an item that has not been implemented in KRAD yet. I would suggest we can do add this to the general collection group so it can be used in places outside of KRAD. When the line is added in ViewHelperServiceImpl, it would add this check. Jerry
          Hide
          Jerry Neal (Inactive) added a comment -

          Kristina,

          Can we close this issue now that you have implemented the functionality?

          thanks,
          Jerry

          Show
          Jerry Neal (Inactive) added a comment - Kristina, Can we close this issue now that you have implemented the functionality? thanks, Jerry
          Hide
          Kristina Taylor (Inactive) added a comment -

          No, I don't know of any way to specify attributeToHighlightOnDuplicateKey in KRAD. In fact, that would have probably helped my other issue when implementing duplicateLinePropertyNames, which currently just throws a general error. That still needs to be mixed in to KRAD (maybe with a different name). Probably an easy issue to implement. You might want to chat with Claus to see if we can fit it in the feature sprint.

          Show
          Kristina Taylor (Inactive) added a comment - No, I don't know of any way to specify attributeToHighlightOnDuplicateKey in KRAD. In fact, that would have probably helped my other issue when implementing duplicateLinePropertyNames , which currently just throws a general error. That still needs to be mixed in to KRAD (maybe with a different name). Probably an easy issue to implement. You might want to chat with Claus to see if we can fit it in the feature sprint.
          Hide
          Jerry Neal (Inactive) added a comment -

          Kristina,

          I think we can add attributeToHighlightOnDuplicateKey (I would prefer propertyToHighlightOnDuplicateKey) to collection group.

          Jerry

          Show
          Jerry Neal (Inactive) added a comment - Kristina, I think we can add attributeToHighlightOnDuplicateKey (I would prefer propertyToHighlightOnDuplicateKey) to collection group. Jerry
          Hide
          Jerry Neal (Inactive) added a comment -

          Unassigning for now until the work gets prioritized

          Show
          Jerry Neal (Inactive) added a comment - Unassigning for now until the work gets prioritized
          Hide
          Kristina Taylor (Inactive) added a comment - - edited

          I've found for the analysis of KULRICE-5364 that the method MaintenanceDocumentDictionaryServiceImpl.validateMaintainableCollectionsForDuplicateEntries does the KNS work for this feature. Nothing like this is called in the KRAD method MaintenanceDocumentRuleBase.dataDictionaryValidate. Either something similar needs to be called here or the feature needs to be implemented in a different way.

          The KNS functionality seems to indicate that this needs to be run on route and approve as well, just in case something in the collection was changed without adding/removing a line. I would guess it needs to be run on save as well.

          Show
          Kristina Taylor (Inactive) added a comment - - edited I've found for the analysis of KULRICE-5364 that the method MaintenanceDocumentDictionaryServiceImpl.validateMaintainableCollectionsForDuplicateEntries does the KNS work for this feature. Nothing like this is called in the KRAD method MaintenanceDocumentRuleBase.dataDictionaryValidate . Either something similar needs to be called here or the feature needs to be implemented in a different way. The KNS functionality seems to indicate that this needs to be run on route and approve as well, just in case something in the collection was changed without adding/removing a line. I would guess it needs to be run on save as well.
          Hide
          Tadas Paegle (Inactive) added a comment -

          Looking through what we currently have in KRAD there is a duplicates property that can be configured on a collection.
          <property name="duplicateLinePropertyNames">
          <list>
          <value>field1</value>
          </list>
          </property>

          If field1 is duplicated it will throw an error message at the top explaining field1 is a duplicate. It's not highlighting the field but we feel this is sufficient.

          Show
          Tadas Paegle (Inactive) added a comment - Looking through what we currently have in KRAD there is a duplicates property that can be configured on a collection. <property name="duplicateLinePropertyNames"> <list> <value>field1</value> </list> </property> If field1 is duplicated it will throw an error message at the top explaining field1 is a duplicate. It's not highlighting the field but we feel this is sufficient.

            People

            • Assignee:
              Tadas Paegle (Inactive)
              Reporter:
              Kristina Taylor (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1 week
                1w
                Remaining:
                Remaining Estimate - 1 week
                1w
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Agile

                    Structure Helper Panel