Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-10756

Implement Workflow Prompts for Actions Like Disapprove

    Details

    • Similar issues:
      KULRICE-6848RouteLog: future action requests show invalid nodes when document is disapproved
      KULRICE-8978Allow acknowledgements to be suppressed on DISAPPROVE action.
      KULRICE-8680Question forms prompt the wrong question.
      KULRICE-8300problems with implementation of super user tab
      KULRICE-2157Cancel and Disapprove actions should not cause eDoc Lite form to validate
      KULRICE-13748Create Web Tests for KRAD Transactional Document Actions
      KULRICE-889New workflow API
      KULRICE-7588Implement maintenance Delete action
      KULRICE-12696Implement Pessimistic Locking in KRAD Documents
      KULRICE-5057improved user experience after clicking a workflow action
    • Epic Link:
    • Rice Module:
      KRAD
    • KRAD Feature Area:
      Transactional
    • Sprint:
      2.5.0-m1 Sprint 3, 2.5.0-m2 Sprint 1
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      In the KNS, certain actions like Disapprove had a hook to the question framework that would ask for the user doing the disapproval to make a comment on the reason for the disapproval. In KRAD, this is only listed as TODOs in the code and needs to be implemented. See the KNS for the complete list of actions where this occurred.

        Issue Links

          Activity

          Hide
          Jerry Neal (Inactive) added a comment -

          Thanks Neeraj. Would you mind to share what you created for KPME?

          Show
          Jerry Neal (Inactive) added a comment - Thanks Neeraj. Would you mind to share what you created for KPME?
          Hide
          Neeraj Khanolkar added a comment - - edited

          Sure Jerry, if you look at the comments and the first commit for KPME-2368, you can see that all I did was deploy a new maintenance controller (in place of Rice's maintenance controller) which intercepts user actions like 'save', 'route', 'approve' etc. to check for existence of newer versions of the BO. If a newer version exists, then the controller causes a KRAD dialog to pop-up asking the user for confirmation to proceed with the particular action. Since my new controller extends rice's MaintenanceDocumentController, on user confirmation I just pass on to the superclass action. Please see EffectiveDateMaintenanceController.java in KPME trunk.

          That gives us functionality in KRAD maintenance which is more or less equivalent with what we had with KNS maintenance screens and the promptBeforeValidationClass property.

          Show
          Neeraj Khanolkar added a comment - - edited Sure Jerry, if you look at the comments and the first commit for KPME-2368 , you can see that all I did was deploy a new maintenance controller (in place of Rice's maintenance controller) which intercepts user actions like 'save', 'route', 'approve' etc. to check for existence of newer versions of the BO. If a newer version exists, then the controller causes a KRAD dialog to pop-up asking the user for confirmation to proceed with the particular action. Since my new controller extends rice's MaintenanceDocumentController , on user confirmation I just pass on to the superclass action. Please see EffectiveDateMaintenanceController.java in KPME trunk. That gives us functionality in KRAD maintenance which is more or less equivalent with what we had with KNS maintenance screens and the promptBeforeValidationClass property.
          Hide
          Kristina Taylor (Inactive) added a comment -

          We also have a Rice demo for this:

          http://env14.rice.kuali.org/kr-krad/account?methodToCall=start&dataObjectClassName=org.kuali.rice.krad.demo.travel.dataobject.TravelAccount&viewId=LabsMaintenance-PromptBeforeRoutingView

          KPME was the premier project we did this research for and I'm really glad it's working for them

          Show
          Kristina Taylor (Inactive) added a comment - We also have a Rice demo for this: http://env14.rice.kuali.org/kr-krad/account?methodToCall=start&dataObjectClassName=org.kuali.rice.krad.demo.travel.dataobject.TravelAccount&viewId=LabsMaintenance-PromptBeforeRoutingView KPME was the premier project we did this research for and I'm really glad it's working for them
          Hide
          Tadas Paegle (Inactive) added a comment -

          Tom is reviewing a css issues with the modals in Travel Demo

          Show
          Tadas Paegle (Inactive) added a comment - Tom is reviewing a css issues with the modals in Travel Demo
          Hide
          Nisha Gupta (Inactive) added a comment -

          Even though this issue was resolved, there seemed to be a piece of logic missing with the generation and validation of the disapproval note text, which I committed a fix for in today. There isn't an existing JIRA for the missing logic so I attributed my commit towards this existing JIRA since it is related. I also paired with Tadas on this issue so it seemed more appropriate to assign the commit to the issue.

          Show
          Nisha Gupta (Inactive) added a comment - Even though this issue was resolved, there seemed to be a piece of logic missing with the generation and validation of the disapproval note text, which I committed a fix for in today. There isn't an existing JIRA for the missing logic so I attributed my commit towards this existing JIRA since it is related. I also paired with Tadas on this issue so it seemed more appropriate to assign the commit to the issue.

            People

            • Assignee:
              Tadas Paegle (Inactive)
              Reporter:
              Kristina Taylor (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 3 days
                3d
                Remaining:
                Time Spent - 2 days, 6 hours Remaining Estimate - 2 hours
                2h
                Logged:
                Time Spent - 2 days, 6 hours Remaining Estimate - 2 hours
                2d 6h

                  Agile

                    Structure Helper Panel