Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • KRAD Feature Area:
      Document
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      Currently the quickfinder posts the page which sends back a redirect URL, which is then rendered in the lightbox. This is a lot of overhead. Instead, we should be able to build the URL through script and invoke the lightbox without posting the page

        Attachments

          Issue Links

            Activity

            Hide
            cniesen Claus Niesen added a comment -

            Quickfinder content doesn't get rendered in lightbox. The browser console shows a GET 400 bad request error.

            Reverting commit 46253 fixes this.

            Show
            cniesen Claus Niesen added a comment - Quickfinder content doesn't get rendered in lightbox. The browser console shows a GET 400 bad request error. Reverting commit 46253 fixes this.
            Hide
            jkneal Jerry Neal (Inactive) added a comment -

            All,

            Looks like this code was reverted on the 2.4 branch. We still have it on 2.5 and ran into the same issues. So we are going to revert it there as well. But we should reopen this issue to take a look at implementing this functionality again right?

            I will take a look at the initial work to see if I can provide some suggestions.

            thanks,
            Jerry

            Show
            jkneal Jerry Neal (Inactive) added a comment - All, Looks like this code was reverted on the 2.4 branch. We still have it on 2.5 and ran into the same issues. So we are going to revert it there as well. But we should reopen this issue to take a look at implementing this functionality again right? I will take a look at the initial work to see if I can provide some suggestions. thanks, Jerry
            Hide
            jkneal Jerry Neal (Inactive) added a comment -

            Matt,

            A few things with the initial implementation of this. First, the code that broke lookups was around the baseURL:

            var baseURI = this.documentURI;
            if (baseURI.indexOf("?") > -1)

            { baseURI = baseURI.substring(0, baseURI.indexOf("?")); }

            var lookupUrl = baseURI.replace("kradsampleapp", "lookup?");

            Instead of this, we can get the baseUrl through the action parameters:

            var lookupUrl = data['actionParameters[baseLookupUrl]'];

            Also, take a look at performLookup in UifControllerBase. Instead of hard-coding the URL parameters, we should be able to pull those from the actionParameters map like is being done in the base controller.

            thanks,
            Jerry

            Show
            jkneal Jerry Neal (Inactive) added a comment - Matt, A few things with the initial implementation of this. First, the code that broke lookups was around the baseURL: var baseURI = this.documentURI; if (baseURI.indexOf("?") > -1) { baseURI = baseURI.substring(0, baseURI.indexOf("?")); } var lookupUrl = baseURI.replace("kradsampleapp", "lookup?"); Instead of this, we can get the baseUrl through the action parameters: var lookupUrl = data['actionParameters [baseLookupUrl] ']; Also, take a look at performLookup in UifControllerBase. Instead of hard-coding the URL parameters, we should be able to pull those from the actionParameters map like is being done in the base controller. thanks, Jerry
            Hide
            sonam Sona Sona (Inactive) added a comment -

            Reopening because this causes KULRICE-12730. Using KIM User Control throws "lookupable is null" error.

            This is happening because Person is an externalizableDataObject and the performLookup in UifControllerBase was translating the externalizableDataObject to a new lookupURL with the dataObjectClass changed to PersonImpl.

            With the fix for this jira we are now skipping the initial call to performLookup and this won't work for any externalizableDataObjects.

            One solution I thought was to override baseLookupURL in quickFinder in the UserControl, but that won't work because the quickFinder lifecycle runs after that and overrides the baseLookupURL.

            We need to come up with a mechanism to deal with the lookups for EBO.

            Show
            sonam Sona Sona (Inactive) added a comment - Reopening because this causes KULRICE-12730 . Using KIM User Control throws "lookupable is null" error. This is happening because Person is an externalizableDataObject and the performLookup in UifControllerBase was translating the externalizableDataObject to a new lookupURL with the dataObjectClass changed to PersonImpl. With the fix for this jira we are now skipping the initial call to performLookup and this won't work for any externalizableDataObjects. One solution I thought was to override baseLookupURL in quickFinder in the UserControl, but that won't work because the quickFinder lifecycle runs after that and overrides the baseLookupURL. We need to come up with a mechanism to deal with the lookups for EBO.
            Hide
            jruch Jeff Ruch added a comment -

            This issue caused KULRICE-12744 Quickfinder Lookup doesn't populate criteria fields with data from calling field. The form data (lookupCriteria) is no longer posted. I verified that reverting the changes to krad.widget.js.createLightBoxPost() resolves KULRICE-12744.

            Show
            jruch Jeff Ruch added a comment - This issue caused KULRICE-12744 Quickfinder Lookup doesn't populate criteria fields with data from calling field. The form data (lookupCriteria) is no longer posted. I verified that reverting the changes to krad.widget.js.createLightBoxPost() resolves KULRICE-12744 .
            Hide
            jruch Jeff Ruch added a comment -
            Show
            jruch Jeff Ruch added a comment - KULRICE-10909 causes KULRICE-12744
            Hide
            matthew.wuertz Matthew Wuertz (Inactive) added a comment -

            I have addressed 12744 and 12730.

            Show
            matthew.wuertz Matthew Wuertz (Inactive) added a comment - I have addressed 12744 and 12730.

              People

              • Assignee:
                matthew.wuertz Matthew Wuertz (Inactive)
                Reporter:
                jkneal Jerry Neal (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 2 days, 2 hours
                  2d 2h
                  Remaining:
                  Remaining Estimate - 2 days, 2 hours
                  2d 2h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified