Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-10933

Input field validation tooltips displays twice in lightbox

    Details

    • Type: Bug Fix
    • Status: Closed
    • Priority: Critical
    • Resolution: Cannot Reproduce
    • Affects Version/s: 2.3.2
    • Fix Version/s: 2.4.2, 2.5
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Application Requirement:
      KS
    • Sprint:
      2.4.0-m4 Dev Sprint 4 (Real), Core 2.5.0-m4 Sprint 1, Core 2.5.0-m5 Sprint 1, Core 2.5.0-m5 Sprint 2
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      If we use inputfields with client side validations in a lightbox, the validation tooltips are displaying at the input field as well as in other place. Pl. find the attached img.

        Attachments

          Issue Links

            Activity

            Hide
            kbtaylor Kristina Taylor (Inactive) added a comment -

            Please attach an example with your XML and any relevant Java. We cannot reproduce this in our sample app.

            Show
            kbtaylor Kristina Taylor (Inactive) added a comment - Please attach an example with your XML and any relevant Java. We cannot reproduce this in our sample app.
            Hide
            vpremcha Venkat PremChandran (Inactive) added a comment -

            This is the krad view which is having issue.
            https://fisheye.kuali.org/browse/~br=trunk/ks/enrollment/ks-enroll/trunk/ks-enroll-ui/src/main/resources/org/kuali/student/enrollment/timeslot/TimeSlotView.xml?r=70490

            KS-TimeSlot-AddTimeSlotPopupForm and KS-TimeSlot-EditTimeSlotPopupForm are the sections which we display as lightbox

            This is the JS file which displays the sections as lightbox. JS Function: showTimeSlotLightBox(), which calls showLightboxComponent('KS-TimeSlot-EditTimeSlotPopupForm',overrideOptions); for editing a timeslot
            openPopupContent(event,'KS-TimeSlot-AddTimeSlotPopupForm',overrideOptions); to add a timeslot

            https://fisheye.kuali.org/browse/~br=trunk/ks/enrollment/ks-core/trunk/ks-common/ks-common-web/src/main/webapp/themes/ksboot/scripts/timeslot.js?r=63703

            Rightnow, we're using server side validation. To reproduce the issue, we need to add p:required="true" to the input fields available at the sections I mentioned above. I tried reproducing the issue today but it's not displaying twice. The 'Required' client side popup stays at the screen after I close the lightbox (Please see attached TimeSlots-screen-Jun27.png).

            Show
            vpremcha Venkat PremChandran (Inactive) added a comment - This is the krad view which is having issue. https://fisheye.kuali.org/browse/~br=trunk/ks/enrollment/ks-enroll/trunk/ks-enroll-ui/src/main/resources/org/kuali/student/enrollment/timeslot/TimeSlotView.xml?r=70490 KS-TimeSlot-AddTimeSlotPopupForm and KS-TimeSlot-EditTimeSlotPopupForm are the sections which we display as lightbox This is the JS file which displays the sections as lightbox. JS Function: showTimeSlotLightBox(), which calls showLightboxComponent('KS-TimeSlot-EditTimeSlotPopupForm',overrideOptions); for editing a timeslot openPopupContent(event,'KS-TimeSlot-AddTimeSlotPopupForm',overrideOptions); to add a timeslot https://fisheye.kuali.org/browse/~br=trunk/ks/enrollment/ks-core/trunk/ks-common/ks-common-web/src/main/webapp/themes/ksboot/scripts/timeslot.js?r=63703 Rightnow, we're using server side validation. To reproduce the issue, we need to add p:required="true" to the input fields available at the sections I mentioned above. I tried reproducing the issue today but it's not displaying twice. The 'Required' client side popup stays at the screen after I close the lightbox (Please see attached TimeSlots-screen-Jun27.png).
            Hide
            vpremcha Venkat PremChandran (Inactive) added a comment - - edited

            Also, I noticed input fields which uses the same ids (addOrEditTermKey, addOrEditTermKey, addOrEditTermKey etc) on those 2 sections (KS-TimeSlot-AddTimeSlotPopupForm and KS-TimeSlot-EditTimeSlotPopupForm). I renamed those to make it unique. Looks like i'm not getting that issue again when I edit a Timeslot, which displays in lightbox. For Add, the required popup displays at the view instead of the popup

            Add calls: openPopupContent(event,'KS-TimeSlot-AddTimeSlotPopupForm',overrideOptions);
            Edit Calls: showLightboxComponent('KS-TimeSlot-EditTimeSlotPopupForm',overrideOptions);

            (attached: Timeslot-required-error.png)

            Show
            vpremcha Venkat PremChandran (Inactive) added a comment - - edited Also, I noticed input fields which uses the same ids (addOrEditTermKey, addOrEditTermKey, addOrEditTermKey etc) on those 2 sections (KS-TimeSlot-AddTimeSlotPopupForm and KS-TimeSlot-EditTimeSlotPopupForm). I renamed those to make it unique. Looks like i'm not getting that issue again when I edit a Timeslot, which displays in lightbox. For Add, the required popup displays at the view instead of the popup Add calls: openPopupContent(event,'KS-TimeSlot-AddTimeSlotPopupForm',overrideOptions); Edit Calls: showLightboxComponent('KS-TimeSlot-EditTimeSlotPopupForm',overrideOptions); (attached: Timeslot-required-error.png)
            Hide
            kbtaylor Kristina Taylor (Inactive) added a comment - - edited

            It appears from your comments that the issue is no longer happening once you have done some adjusting. Am I correct that you are reporting two additional issues, that

            1. The 'Required' client side popup stays at the screen after I close the lightbox (Please see attached TimeSlots-screen-Jun27.png).
            2. For Add, the required popup displays at the view instead of the popup

            and is it possible you can talk to Larry Symms about scheduling those for 2.4.3?

            Show
            kbtaylor Kristina Taylor (Inactive) added a comment - - edited It appears from your comments that the issue is no longer happening once you have done some adjusting. Am I correct that you are reporting two additional issues, that The 'Required' client side popup stays at the screen after I close the lightbox (Please see attached TimeSlots-screen-Jun27.png). For Add, the required popup displays at the view instead of the popup and is it possible you can talk to Larry Symms about scheduling those for 2.4.3?
            Hide
            lsymms Larry Symms added a comment -

            The issue as described in the title was due to copy/paste errors with duplicate field ids so rendering of tooltips would happen on all matching fields. New issue was created KULRICE-12901 for rendering issues with tooltips and bubblepopups

            Show
            lsymms Larry Symms added a comment - The issue as described in the title was due to copy/paste errors with duplicate field ids so rendering of tooltips would happen on all matching fields. New issue was created KULRICE-12901 for rendering issues with tooltips and bubblepopups

              People

              • Assignee:
                kbtaylor Kristina Taylor (Inactive)
                Reporter:
                lsymms Larry Symms
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 1 day
                  1d
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day
                  1d