Cleanup items noted by Jerry for another pass at this issue:

1) Quick style thing: We decided for ternary operators they should be very simple and fit on one line. For example, we would rather see this as an if:

Component parentComponent = parent == null ? null
: parent.getElement() instanceof Component ? (Component) parent.getElement()
: parent.getParent();
2) With the latest changes we moved task initialization more to the lifecycle element. I would rather keep them in the phase and have one place to look. Could we do this if we made tasks that were only applied to certain elements? In general, it would be great if we could isolate all the lifecycle code (besides the phase callbacks) to the lifecycle packages.

3) The clearIndex(); call on View causes issues with getting components by id. For example in Action we need to get a component to set the refreshedByAction flag, but if the phase has not been run on that component yet it is not in the index:

Action:

else if (StringUtils.isNotBlank(refreshId)) {
Component component = view.getViewIndex().getComponentById(refreshId);
if (component != null)

Unknown macro: { refreshComponent = component; }

}

4) We need to make another pass and cleanup javadocs and method ordering. Lots of incorrect Javadocs are present, and style problems. Does Eclipse highlight problems in the Javadoc (for example when the doc has a unmatched param tag)? Here is more on doc standards:

https://wiki.kuali.org/display/KULRICE/Documentation+Standards

Addressed item #2:

I have moved lifecycle task initialization back to the default methods in ComponentIntitializePhase, ComponentApplyModelPhase, and ComponentFinalizePhase. To eliminate instanceof checking, and other complex branching logic during this setup, I added a check while executing tasks to ensure that the lifecycle element for the current phase is an instance of an "elementClass" defined for the task.

I've switched development over to IntelliJ to complete a final pass at JavaDoc cleanup. TODOs from 12/23 are still outstanding.

Work is in progress on the 2.4 performance branch for converting the pre-process phase to a fully formed lifecycle phase.

Implementation is fully complete, but I am working through a few null pointers - related to the model being null during the pre-process phase.

I expect to have this issue resolved early this week.

Committed updates to performance branch:

1. Added "viewPath" bean property to both LifecycleElement and ViewLifecyclePhase for the full path relative to the view, and clarified the use of the "path" property as relative to the element's parent component.
2. Converted pre-process to a fully formed lifecycle phase.
3. Added recycling to lifecycle element maps.

Last step is to investigate impact related to clearIndex()

Removed clearIndex() calls and performed regression testing to check for fallout. With the planned removal of ViewIndex, this should have minimal long-term impact.

As a final item for this issue, I modified ProcessLoggingUnitTest to facilitate multiple repetitions of the test. It is up to the test itself to alter the test expectations for each run. I set each ViewLifecycleTest method to run 2 times: once with asynchronous lifecycle, and once synchronous.