Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-11197

DirtyCheck should not be performed on dialog return.

    Details

    • Similar issues:
      KULRICE-7446Implement return from dialog
      KULRICE-5100StyleServiceImpl.getStyle should perform caching of styles
      KULRICE-11854Dialog takes more screen space than it should
      KULRICE-9614Dialogs not correctly returning to controller method
      KULRICE-12545Need ability to trigger a lookup from a dialog (and wizard group)
      KULRICE-13923Lookup return doesn't work when using a nested lookup within a dialog
      KULRICE-10890Perform analysis & implementation on Key Personnel dialog
      KULRICE-8318Error on clicking 'return value' in lookup dialog
      KULRICE-8827Dialog methods in UifControllerBase should not throw exception
      KULRICE-8958ScriptUtils convertToJsValue Performance Improvement
    • Rice Module:
      KRAD
    • Sprint:
      2.4.0-m3 KRAD UXI Sprint 2
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      A dirtycheck is performed when user moves away from the current screen with browser based actions ie. back, url change etc. This check is ignored on form posts that originate from within the page for example submits or refresh but does not currently ignore dialogs. When returning from a dialog, the methodToCall is null.

      The behavior is that on expected user interactions within a dialog, the dirty flag is set and the user is prompted with a "Confirm Navigation" dialog even though that is not the case.

        Issue Links

          Activity

          Hide
          Brian Smith (Inactive) added a comment -

          Jira description is too vague, need XML configuration and pictures. The additional description in the linked jira helps but does not provide enough information.

          Show
          Brian Smith (Inactive) added a comment - Jira description is too vague, need XML configuration and pictures. The additional description in the linked jira helps but does not provide enough information.
          Hide
          SW Genis (Inactive) added a comment - - edited

          Also see KSENROLL-10567 for more information on original issue.

          Controller method code:

              if (!hasDialogBeenAnswered(KRMSConstants.KSKRMS_DIALOG_YESNO_WARNING, form)) {
                  return showDialog(KRMSConstants.KSKRMS_DIALOG_YESNO_WARNING, form, request, response);
              }
          
              String dialogResponse = getStringDialogResponse(KRMSConstants.KSKRMS_DIALOG_YESNO_WARNING, form, request, response);
              if ("N".equals(dialogResponse)) {
                  form.getDialogManager().resetDialogStatus(KRMSConstants.KSKRMS_DIALOG_YESNO_WARNING);
                  return getUIFModelAndView(form);
              }
          

          XML Bean configuration:

              <bean id="KRMS-WarningMessagedYesNo" parent="Uif-DialogGroup">
                  <property name="header.render" value="false"/>
                  <property name="promptText" value="Single value entered for plural rule statement, Are you sure you want to continue?"/>
                  <property name="availableResponses">
                      <list>
                          <bean parent="Uif-KeyLabelPair" p:key="Y" p:value="Yes"/>
                          <bean parent="Uif-KeyLabelPair" p:key="N" p:value="No"/>
                      </list>
                  </property>
              </bean>
          
          Show
          SW Genis (Inactive) added a comment - - edited Also see KSENROLL-10567 for more information on original issue. Controller method code: if (!hasDialogBeenAnswered(KRMSConstants.KSKRMS_DIALOG_YESNO_WARNING, form)) { return showDialog(KRMSConstants.KSKRMS_DIALOG_YESNO_WARNING, form, request, response); } String dialogResponse = getStringDialogResponse(KRMSConstants.KSKRMS_DIALOG_YESNO_WARNING, form, request, response); if ("N".equals(dialogResponse)) { form.getDialogManager().resetDialogStatus(KRMSConstants.KSKRMS_DIALOG_YESNO_WARNING); return getUIFModelAndView(form); } XML Bean configuration: <bean id="KRMS-WarningMessagedYesNo" parent="Uif-DialogGroup"> <property name="header.render" value="false"/> <property name="promptText" value="Single value entered for plural rule statement, Are you sure you want to continue?"/> <property name="availableResponses"> <list> <bean parent="Uif-KeyLabelPair" p:key="Y" p:value="Yes"/> <bean parent="Uif-KeyLabelPair" p:key="N" p:value="No"/> </list> </property> </bean>
          Hide
          Brian Smith (Inactive) added a comment -

          Why is this reopened?

          Show
          Brian Smith (Inactive) added a comment - Why is this reopened?
          Hide
          SW Genis (Inactive) added a comment - - edited

          I have added the xml configuration and the pictures that you have asked for, that is why i reopened it. Is that a problem?

          How else would you know that you can look at it again, the problems is definitely not fixed yet, is it?

          Show
          SW Genis (Inactive) added a comment - - edited I have added the xml configuration and the pictures that you have asked for, that is why i reopened it. Is that a problem? How else would you know that you can look at it again, the problems is definitely not fixed yet, is it?
          Hide
          Larry Symms added a comment -

          apparently Brian was able to fix it without the xml config and screenshots. This was confirmed yesterday by Jessica.

          Show
          Larry Symms added a comment - apparently Brian was able to fix it without the xml config and screenshots. This was confirmed yesterday by Jessica.
          Hide
          Brian Smith (Inactive) added a comment -

          Sorry for the confusion I was able to figure out the additional details after getting some more information from others in a skype chat on where to reproduce in your environment. It is fixed in 2.3.3 (and the fix should work when you upgrade, with any luck).

          Show
          Brian Smith (Inactive) added a comment - Sorry for the confusion I was able to figure out the additional details after getting some more information from others in a skype chat on where to reproduce in your environment. It is fixed in 2.3.3 (and the fix should work when you upgrade, with any luck).
          Hide
          Larry Symms added a comment -

          Still an issue. See comments in KSENROLL-10716

          Show
          Larry Symms added a comment - Still an issue. See comments in KSENROLL-10716
          Hide
          Brian Smith (Inactive) added a comment -

          Related but not directly related to:

          https://jira.kuali.org/browse/KULRICE-12737

          Show
          Brian Smith (Inactive) added a comment - Related but not directly related to: https://jira.kuali.org/browse/KULRICE-12737

            People

            • Assignee:
              Brian Smith (Inactive)
              Reporter:
              Larry Symms
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 2 hours Original Estimate - 2 hours
                2h
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours
                4h

                  Agile

                    Structure Helper Panel