Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-11278

Add caching annotations to translate Natural Language methods in the KRMS RuleManagementService

    Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.2
    • Fix Version/s: 2.3.3, 2.4
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-7368Implement KRMS Natural Language Translation feature
      KULRICE-12433KRMS Natural Language not properly translated when using certain integer values
      KULRICE-6807Modify KRMS ERD to include natural language
      KULRICE-10167add caching to RuleManagementService methods related to Context, ReferenceObjectBinding, NaturalLanguage
      KULRICE-10147add caching to RuleManagementService methods related to Agenda, Rule, Action, Proposition
      KULRICE-7370Implement RuleManagementService methods for existing KRMS entities
      KULRICE-10145add RuleManagementService tests for ContextDefinition, ReferenceObjectBinding related methods
      KULRICE-10146add RuleManagementService tests for NaturalLanguageUsage, NaturalLanguageTemplate related methods
      KULRICE-5152Add version number to KRMS DTOs
      KULRICE-7258Implement caching on ExtensionRepositoryService
    • Rice Module:
      KRMS
    • Sprint:
      2.4.0-m3 KRAD Sprint 4
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      KS made a shadow copy of the RuleManagementService and it triggered a sonar issue related to TODO's in code comments without an associated jira.

      The purpose of this jira is to represent the work noted with the TODO on line 993 of the RuleManagementService.

      To add caching annotations to the translateNaturalLanguage methods in the RuleManagementService.

      When completed the TODO on line 993 should also be removed.

        Activity

        Hide
        Peter Giles (Inactive) added a comment - - edited

        When we were doing our caching work on the RuleManagementService, I had our devs leave the natural language translation methods alone. I was concerned that it would be tricky to cache those correctly.

        As an example, if anything was done based on the user session (or anything else that isn't an explicit argument) to generate the text, then using a cached translation would be likely to yield invalid results.

        Show
        Peter Giles (Inactive) added a comment - - edited When we were doing our caching work on the RuleManagementService, I had our devs leave the natural language translation methods alone. I was concerned that it would be tricky to cache those correctly. As an example, if anything was done based on the user session (or anything else that isn't an explicit argument) to generate the text, then using a cached translation would be likely to yield invalid results.
        Hide
        Peter Giles (Inactive) added a comment -

        Chatted w/ Larry about this one. I think we should take the TODOs out of the doc comments, and probably leave it there for now. If we do have to come back and address performance in these methods, we might consider some different approaches.

        Show
        Peter Giles (Inactive) added a comment - Chatted w/ Larry about this one. I think we should take the TODOs out of the doc comments, and probably leave it there for now. If we do have to come back and address performance in these methods, we might consider some different approaches.
        Hide
        Michael O'Cleirigh added a comment -

        I'm fine with that.

        Show
        Michael O'Cleirigh added a comment - I'm fine with that.
        Hide
        Peter Giles (Inactive) added a comment -

        removed the todo

        Show
        Peter Giles (Inactive) added a comment - removed the todo

          People

          • Assignee:
            Peter Giles (Inactive)
            Reporter:
            Michael O'Cleirigh
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Agile

                Structure Helper Panel