Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.0-m3
    • Fix Version/s: 2.4
    • Component/s: HTTP Unit Testing
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-9827Split Js files further into other functional areas
      KULRICE-10608JS Error on env2 KRAD kitchen sink Progressive Disclosure tab (page functionality broken)
      KULRICE-12383KRAD Library Navigation Group with Toggle js error on ActionScript 4 in Firefox
      KULRICE-10401Uif-Suggest not working in Google Chrome
      KULRICE-13000js error in dialog "disclosureId is not defined"
      KULRICE-8155JS error going to collections page
      KULRICE-3985portalTop tag only works with a single portal CSS/JS file
      KULRICE-12515DemoControlCheckboxDefaultAft acting different with checboxes between Chrome and Firefox
      KULRICE-6861JS error with refreshWhenChanged
      KULRICE-5799JS errors appear after going to doc search and then to another view
    • Rice Module:
      KRAD
    • Sprint:
      2.4.0-m3 KRAD Sprint 3, 2.4.0-m3 KRAD Sprint 4
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      Get a java script error
      Uncaught TypeError: Cannot call method 'close' of undefined<br/>http://localhost:8080/krad-dev/krad/scripts/krad.utility.js<br/>900

      when trying to configure help links in the section headers via the DD. A new window does not open and if you step through the debugger the above error shows up on the console. The same works in firefox. The chrome version is 30.0.1599.101 m. The firefox version is 25.0 Here is the config I was using

      <bean id="TravelCompany-MaintenanceHelpView" parent="Uif-MaintenanceView">
      <property name="headerText" value="Travel Company Maintenance"/>
      <property name="dataObjectClassName" value="edu.sampleu.travel.dataobject.TravelCompany"/>
      <property name="viewName" value="TravelCompany-MaintenanceHelpView"/>
      <property name="items">
      <list merge="true">
      <bean parent="Uif-MaintenanceGridSection">
      <property name="headerText" value="Company Information"/>
      <property name="help">
      <bean parent="Uif-Help">
      <property name="externalHelpUrl" value="http://www.kuali.org/"/>
      </bean>
      </property>
      <property name="items">
      <list>
      <bean parent="Uif-DataField"
      p:propertyName="travelCompanyId"
      p:defaultValue="@

      { #sequence('TRVL_CO_ID_S') }

      " />
      <bean parent="Uif-InputField" p:propertyName="travelCompanyName"/>
      </list>
      </property>
      </bean>
      </list>
      </property>
      </bean>

        Activity

        Hide
        Kristina Taylor (Inactive) added a comment -

        I'm able to get the popup to work with no errors in Chrome 31.0.1650.57. I did have to make sure to disable the popup blocker for the page, but other than that, it seems to be working ok for me. Can you upgrade and try again?

        Show
        Kristina Taylor (Inactive) added a comment - I'm able to get the popup to work with no errors in Chrome 31.0.1650.57. I did have to make sure to disable the popup blocker for the page, but other than that, it seems to be working ok for me. Can you upgrade and try again?
        Hide
        Corey Pedersen (Inactive) added a comment -

        Issue is based on the fact that chrome will only allow one window.open per event. Part of their popup blocking. The current code does open,close,open and the second open is thus ignored by chrome.

        Update 43262 will bypass the first open and close for chrome and execute the same as before for other browsers.

        Note: Chrome will not resize a window with a url differing host than that of the current window. This remains a reduced function for openHelpWindow where existing help window exists with different host.

        Show
        Corey Pedersen (Inactive) added a comment - Issue is based on the fact that chrome will only allow one window.open per event. Part of their popup blocking. The current code does open,close,open and the second open is thus ignored by chrome. Update 43262 will bypass the first open and close for chrome and execute the same as before for other browsers. Note: Chrome will not resize a window with a url differing host than that of the current window. This remains a reduced function for openHelpWindow where existing help window exists with different host.
        Hide
        Corey Pedersen (Inactive) added a comment -

        Test URL maintenance?methodToCall=maintenanceEdit&travelCompanyId=10000&dataObjectClassName=edu.sampleu.travel.dataobject.TravelCompany&viewId=TravelCompany-MaintenanceHelpView

        Show
        Corey Pedersen (Inactive) added a comment - Test URL maintenance?methodToCall=maintenanceEdit&travelCompanyId=10000&dataObjectClassName=edu.sampleu.travel.dataobject.TravelCompany&viewId=TravelCompany-MaintenanceHelpView
        Hide
        Claus Niesen added a comment -

        FYI: Chromes pop up blocker.

        • Without the default the pop-up blocker blocks popups.
        • With having the pop-up blocker set to "allow all popups from this site" the original open-close-open help works.
        • With the shiftkey-click feature of the pop-up blocker the open-close-open fails on the second open because the shiftkey-click takes only affect for the first pop-up.

        There is a potential that other pop-up blockers might work the same and have the same issue. I haven't found an issue with IE 9 or FF

        IE 9:

        • With the default the pop-up blocker blocks popups and displays a message bar.
        • Message bar "Allow once" will allow the popup after the user clicks the help for a second time.
        • With the Ctrl-Alt-click feature the open-close-open help works.

        FF:
        For some strange reason FF isn't blocking the help pop-ups.

        Show
        Claus Niesen added a comment - FYI: Chromes pop up blocker. Without the default the pop-up blocker blocks popups. With having the pop-up blocker set to "allow all popups from this site" the original open-close-open help works. With the shiftkey-click feature of the pop-up blocker the open-close-open fails on the second open because the shiftkey-click takes only affect for the first pop-up. There is a potential that other pop-up blockers might work the same and have the same issue. I haven't found an issue with IE 9 or FF IE 9: With the default the pop-up blocker blocks popups and displays a message bar. Message bar "Allow once" will allow the popup after the user clicks the help for a second time. With the Ctrl-Alt-click feature the open-close-open help works. FF: For some strange reason FF isn't blocking the help pop-ups.

          People

          • Assignee:
            Corey Pedersen (Inactive)
            Reporter:
            Sona Sona (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1 day, 4 hours
              1d 4h
              Remaining:
              Time Spent - 1 day, 1 hour Remaining Estimate - 3 hours
              3h
              Logged:
              Time Spent - 1 day, 1 hour Remaining Estimate - 3 hours
              1d 1h

                Agile

                  Structure Helper Panel