Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Not version specific
    • Component/s: Code Standards
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-9391Code Report
      KULRICE-11724Code Report
      KULRICE-12587Code Report
      KULRICE-10659Code Report
      KULRICE-11546Code Report
      KULRICE-9154Code Report
      KULRICE-10099Code Report
      KULRICE-8989Code Report
      KULRICE-8990Code Report
      KULRICE-9036Code Report
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required

      Description

      In DataObjectWrapperBase.java, in getPrimaryKeyValue, you call getPrimaryKeyValues twice. First, you set it to primaryKeyValues and then you use it again one line later in the if statement. At that point, you should be using primaryKeyValues.

      In getForeignKeyValue, add a blank line before:
      for (DataObjectAttributeRelationship attributeRelationship : attributeRelationships) {

      Also, add a blank line before: attributeMap.put(attributeName, attributeValue);
      and a blank line before: if (allPopulated) {
      and a blank line before the return

      In asSingleKey, add a blank line before the return.

      In refreshRelationship, add a blank line before comments:
      // if the foreignKey value is null...
      and // only execute the refresh...

      In linkForeignKeyAttributes, add a blank line before the for loop.

        Activity

        There are no comments yet on this issue.

          People

          • Assignee:
            Eric Westfall
            Reporter:
            Matthew Wuertz (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Structure Helper Panel