Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-11460

Maintenance Conversion Script - M89 Collection deletion

    Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.4
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-11487M89 labs
      KULRICE-11355Create Conversion Guide Documenation for M88, M89
      KULRICE-11332Conversion Script: Maintenance
      KULRICE-11563Check that Maintenance conversion guide and conversion scripts are up to date
      KULRICE-11711Maintenance Conversion Script for M80 LookupReadonlyControlDefinition
      KULRICE-11457Maintenance Conversion Script - M82 & M83 ReadOnly
      KULRICE-11222Conversion Script: Maintenance
      KULRICE-11510Maintenance Conversion Script - documentAuthorizerClass property
      KULRICE-5346Delete collection line on editing maintenance doc - not deleting old collection line
      KULRICE-11454Maintenance Conversion Script - M41 OnBlur
    • Rice Module:
      KRAD
    • KRAD Feature Area:
      Maintenance
    • Application Requirement:
      Rice
    • Sprint:
      2.4.0-m4 KRAD Sprint 1
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      This is a tricky one. KNS's default is that only newly added lines can be deleted while in KRAD all lines can be deleted by default. Let me bring this up to the focus group to see if changing the default is OK otherwise we need to create the KRAD property even when KNS doesn't have it specified.

      KRAD delete only newly added

      <property name="lineActions">
        <list>
          <bean parent="Uif-DeleteLineAction" p:render="@{isAddedCollectionItem(#line)}"/>
          <bean parent="Uif-SaveLineAction"/>
        </list>
      </property>
      

      KRAD delete none:

      <property name="lineActions">
        <list>
          <bean parent="Uif-SaveLineAction"/>
        </list>
      </property>
      

      Don't forget the tests.

        Issue Links

          Activity

          Hide
          Claus Niesen added a comment -

          The focus group is OK with the KRAD implementation defaulting that all lines can be deleted. For the conversion script the same behavior of KNS is required. So with the conversion script only newly added items should have the delete option.

          Show
          Claus Niesen added a comment - The focus group is OK with the KRAD implementation defaulting that all lines can be deleted. For the conversion script the same behavior of KNS is required. So with the conversion script only newly added items should have the delete option.
          Hide
          Erik Meade added a comment -

          Re KRAD Delete none it looks like this doesn't need to be addressed in the conversion.

          [1/6/14 5:08:43 PM] Dan Seibert: KNS:
          1. (default) only allows added items to be deleted
          2. alwaysAllowCollectionDeletion = true (allow new and existing items to be deleted)
          3: cant delete new or existing. Don't know if this exists
          [1/6/14 5:15:23 PM] Dan Seibert: Looking at the KNS code SectionBridge.java, it looks like delete buttons are always available on new collection records.

          Show
          Erik Meade added a comment - Re KRAD Delete none it looks like this doesn't need to be addressed in the conversion. [1/6/14 5:08:43 PM] Dan Seibert: KNS: 1. (default) only allows added items to be deleted 2. alwaysAllowCollectionDeletion = true (allow new and existing items to be deleted) 3: cant delete new or existing. Don't know if this exists [1/6/14 5:15:23 PM] Dan Seibert: Looking at the KNS code SectionBridge.java, it looks like delete buttons are always available on new collection records.

            People

            • Assignee:
              Erik Meade
              Reporter:
              Claus Niesen
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 6 hours Original Estimate - 6 hours
                6h
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 1 hour
                1d 1h

                  Agile

                    Structure Helper Panel