Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 2.5.1
    • Component/s: Code Standards
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Sprint:
      Middleware 2.5.1 Sprint 3, Middleware 2.5.2 Sprint 1, Middleware 2.5.2 Sprint 2, Middleware 2.5.2 Sprint 3
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required

      Description

      In RoleServiceImpl.java, you reuse the same code in multiple places:

      Iterator<RoleResponsibilityActionBo> actions = roleMemberBo.getRoleRspActions().iterator();
      List<RoleResponsibilityAction> newActionList = new ArrayList( roleMember.getRoleRspActions() );
      // loop over the existing actions
      ...

      Put this in a helper method. Also, within that code, add a blank line before the comment: // loop over the existing actions
      add a blank line before: // look for a match in the new list
      add a blank line before: if ( !matched ) {

      Also, rather than commenting out a large chunk of code, this should be deleted. If we need to bring the old code back at some point, source control can take care of that for us.

        Attachments

          Activity

          There are no comments yet on this issue.

            People

            • Assignee:
              jkeller Jonathan Keller
              Reporter:
              matthew.wuertz Matthew Wuertz (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: