Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-12040

Allow for overridding of view lifecycle phases and tasks

    Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Complete
    • Affects Version/s: None
    • Fix Version/s: 2.5
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-10980Analysis on performance tasks
      KULRICE-12690Performance issues at the apply-model phase in KS
      KULRICE-11868Expression error in testColumnCalculations during apply model phase
      KULRICE-11062Do POC on changing lifecycle to use reflection
      KULRICE-9431Add options to disable lifecycle functions
      KULRICE-10548Freemarker rendering phase extension
      KULRICE-10547Component lifecycle processing task and execution context
      KULRICE-7072Default values are applied at the end of the view lifecycle so not seen by inquiry
      KULRICE-12255Add rule cannot read proposition property at initialization phase
      KULRICE-13147Inefficiencies in view lifecycle and rendering
    • Epic Link:
    • Rice Module:
      KRAD
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      We need to allow for overriding of the lifecycle phase and tasks classes. One way we could do this:

      Make ViewLifecycleBuild a bean we pull from spring from ViewLifecycle. Then create beans for each of the phases, and inject into viewlifecycle build. Finally, for each of the tasks create a bean, and inject into the corresponding phase.

      One issue with moving the tasks to an injected list, there is a condition around one to only run with the component is the refresh component. We can move this into the task interface as an injected property that is checked.

        Issue Links

          Activity

          Hide
          Mark Fyffe (Inactive) added a comment -

          Resumed progress. Will need to review patch file implementing this feature for 2.4, then revisit on the current trunk and work to identify the cause of the stability issues noted earlier.

          Show
          Mark Fyffe (Inactive) added a comment - Resumed progress. Will need to review patch file implementing this feature for 2.4, then revisit on the current trunk and work to identify the cause of the stability issues noted earlier.
          Hide
          Jerry Neal (Inactive) added a comment -

          Hi Mark,

          Let's just put this in 2.5 instead of 2.4.

          thanks,
          Jerry

          Show
          Jerry Neal (Inactive) added a comment - Hi Mark, Let's just put this in 2.5 instead of 2.4. thanks, Jerry
          Hide
          Mark Fyffe (Inactive) added a comment -

          The patch was made against 2.4 in March, so there are quite a few rejects now against 2.5 - sorry for any confusion, I will definitely leave this change off of the 2.4 branch.

          I've applied patch to 2.5, and am working through rejects now - captured below for reference. Targeting Sunday to have this update working.

          $ patch -p0 < KULRICE-12040-freemarker_error.patch.txt
          patching file rice-framework/krad-sampleapp/web/pom.xml
          Hunk #1 succeeded at 350 (offset 14 lines).
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/datadictionary/DataDictionary.java
          Hunk #2 succeeded at 69 (offset 1 line).
          Hunk #3 succeeded at 741 (offset 16 lines).
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/service/KRADServiceLocatorWeb.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/component/ComponentBase.java
          Hunk #1 succeeded at 21 with fuzz 1.
          Hunk #2 succeeded at 36 with fuzz 1.
          Hunk #3 FAILED at 50.
          Hunk #4 succeeded at 252 (offset 18 lines).
          Hunk #5 FAILED at 253.
          Hunk #6 succeeded at 288 (offset 17 lines).
          Hunk #7 FAILED at 285.
          Hunk #8 FAILED at 306.
          Hunk #9 FAILED at 315.
          Hunk #10 FAILED at 323.
          Hunk #11 FAILED at 334.
          Hunk #12 succeeded at 359 (offset 14 lines).
          Hunk #13 succeeded at 554 (offset 42 lines).
          Hunk #14 succeeded at 614 (offset 58 lines).
          Hunk #15 succeeded at 864 (offset 59 lines).
          Hunk #16 succeeded at 1002 (offset 78 lines).
          Hunk #17 succeeded at 1020 (offset 78 lines).
          Hunk #18 succeeded at 1088 (offset 78 lines).
          Hunk #19 succeeded at 1141 (offset 78 lines).
          Hunk #20 succeeded at 1160 (offset 78 lines).
          Hunk #21 succeeded at 1179 (offset 78 lines).
          Hunk #22 FAILED at 1263.
          Hunk #23 FAILED at 1361.
          Hunk #24 succeeded at 1456 (offset 81 lines).
          Hunk #25 FAILED at 1771.
          Hunk #26 succeeded at 1933 with fuzz 1 (offset 115 lines).
          Hunk #27 succeeded at 1963 (offset 115 lines).
          Hunk #28 succeeded at 1978 with fuzz 1 (offset 115 lines).
          Hunk #29 succeeded at 1988 (offset 115 lines).
          Hunk #30 succeeded at 1998 (offset 115 lines).
          Hunk #31 succeeded at 2008 (offset 115 lines).
          Hunk #32 succeeded at 2018 (offset 115 lines).
          Hunk #33 succeeded at 2027 (offset 115 lines).
          Hunk #34 succeeded at 2037 with fuzz 1 (offset 115 lines).
          Hunk #35 succeeded at 2064 with fuzz 1 (offset 115 lines).
          Hunk #36 succeeded at 2079 (offset 115 lines).
          Hunk #37 succeeded at 2103 (offset 115 lines).
          Hunk #38 succeeded at 2122 (offset 115 lines).
          Hunk #39 succeeded at 2178 with fuzz 1 (offset 115 lines).
          Hunk #40 succeeded at 2194 (offset 115 lines).
          Hunk #41 succeeded at 2223 (offset 115 lines).
          Hunk #42 succeeded at 2231 with fuzz 1 (offset 115 lines).
          Hunk #43 succeeded at 2246 (offset 115 lines).
          Hunk #44 succeeded at 2257 with fuzz 1 (offset 107 lines).
          Hunk #45 succeeded at 2369 (offset 115 lines).
          Hunk #46 FAILED at 2332.
          Hunk #47 FAILED at 2356.
          Hunk #48 succeeded at 2586 (offset 193 lines).
          Hunk #49 succeeded at 2621 (offset 193 lines).
          12 out of 49 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/component/ComponentBase.java.rej
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/container/InitializeContainerFromHelperTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/container/ProcessRemoteFieldsHolderTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/field/DataFieldBase.java
          Reversed (or previously applied) patch detected!  Assume -R? [n] n
          Apply anyway? [n] n
          Skipping patch.
          3 out of 3 hunks ignored -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/field/DataFieldBase.java.rej
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/field/InitializeDataFieldFromDictionaryTask.java
          Hunk #1 succeeded at 24 with fuzz 1 (offset 1 line).
          Hunk #2 succeeded at 38 (offset -2 lines).
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/freemarker/RenderComponentTask.java
          Hunk #1 FAILED at 18.
          Hunk #2 FAILED at 35.
          Hunk #4 FAILED at 82.
          3 out of 4 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/freemarker/RenderComponentTask.java.rej
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/layout/LayoutManagerBase.java
          Hunk #1 succeeded at 21 with fuzz 1.
          Hunk #2 FAILED at 28.
          Hunk #3 succeeded at 210 (offset -1 lines).
          1 out of 3 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/layout/LayoutManagerBase.java.rej
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ApplyModelComponentPhase.java
          Hunk #1 FAILED at 17.
          Hunk #2 FAILED at 66.
          Hunk #3 FAILED at 83.
          Hunk #4 FAILED at 119.
          Hunk #5 succeeded at 138 (offset -35 lines).
          Hunk #6 FAILED at 184.
          Hunk #7 succeeded at 204 (offset -17 lines).
          5 out of 7 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ApplyModelComponentPhase.java.rej
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/FinalizeComponentPhase.java
          Hunk #1 FAILED at 15.
          Hunk #2 succeeded at 63 (offset 1 line).
          Hunk #3 FAILED at 120.
          Hunk #4 succeeded at 179 (offset 4 lines).
          Hunk #5 succeeded at 202 (offset 4 lines).
          2 out of 5 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/FinalizeComponentPhase.java.rej
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/InitializeComponentPhase.java
          Hunk #2 succeeded at 90 (offset 10 lines).
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/LifecycleBase.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/LifecyclePhaseFactory.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/LifecycleTaskFactory.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/PreProcessElementPhase.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/RenderComponentPhase.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/RunComponentModifiersTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ViewLifecycle.java
          Hunk #1 succeeded at 18 with fuzz 2 (offset -1 lines).
          Hunk #2 succeeded at 75 with fuzz 2 (offset -4 lines).
          Hunk #3 succeeded at 555 (offset -11 lines).
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ViewLifecycleBuild.java
          Hunk #1 succeeded at 18 (offset -1 lines).
          Hunk #2 succeeded at 125 (offset 1 line).
          Hunk #3 succeeded at 140 (offset 1 line).
          Hunk #4 succeeded at 159 (offset 1 line).
          Hunk #5 succeeded at 185 (offset 4 lines).
          Hunk #6 succeeded at 203 (offset 4 lines).
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ViewLifecyclePhase.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ViewLifecyclePhaseBase.java
          Hunk #1 FAILED at 43.
          Hunk #2 FAILED at 110.
          Hunk #3 FAILED at 147.
          Hunk #4 FAILED at 191.
          Hunk #5 succeeded at 313 (offset -15 lines).
          Hunk #6 FAILED at 338.
          Hunk #7 succeeded at 391 (offset -14 lines).
          Hunk #8 succeeded at 403 (offset -14 lines).
          Hunk #9 succeeded at 458 (offset -14 lines).
          Hunk #10 succeeded at 493 (offset -14 lines).
          Hunk #11 FAILED at 515.
          Hunk #12 succeeded at 520 (offset -12 lines).
          Hunk #13 succeeded at 545 (offset -12 lines).
          Hunk #14 succeeded at 561 (offset -12 lines).
          Hunk #15 succeeded at 608 (offset -4 lines).
          Hunk #16 succeeded at 644 (offset -4 lines).
          6 out of 16 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ViewLifecyclePhaseBase.java.rej
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ViewLifecyclePhaseBuilder.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ViewLifecyclePhaseBuilderBase.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ViewLifecyclePreProcessBuild.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ViewLifecycleTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ViewLifecycleTaskBase.java
          Hunk #5 succeeded at 121 (offset 5 lines).
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/finalize/AddViewTemplatesTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/finalize/ComponentDefaultFinalizeTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/finalize/FinalizeViewTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/finalize/HelperCustomFinalizeTask.java
          Hunk #1 FAILED at 17 (different line endings).
          Hunk #2 FAILED at 29 (different line endings).
          2 out of 2 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/finalize/HelperCustomFinalizeTask.java.rej
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/finalize/InvokeFinalizerTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/finalize/RegisterPropertyEditorTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/finalize/SetReadOnlyOnDataBindingTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/AssignIdsTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/ComponentDefaultInitializeTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/HelperCustomInitializeTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/InitializeContainerFromHelperTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/InitializeDataFieldFromDictionaryTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/PopulateComponentFromExpressionGraphTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/PopulatePathTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/PopulateReplacersAndModifiersFromExpressionGraphTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/PrepareForCacheTask.java
          Hunk #1 FAILED at 16.
          Hunk #2 succeeded at 31 (offset 2 lines).
          1 out of 2 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/PrepareForCacheTask.java.rej
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/ProcessRemoteFieldsHolderTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/SortContainerTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/model/ApplyAuthAndPresentationLogicTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/model/ComponentDefaultApplyModelTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/model/EvaluateExpressionsTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/model/HelperCustomApplyModelTask.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/model/PopulateComponentContextTask.java
          Hunk #1 FAILED at 20.
          Hunk #2 succeeded at 30 (offset -2 lines).
          1 out of 2 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/model/PopulateComponentContextTask.java.rej
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/model/RefreshStateModifyTask.java
          Hunk #1 FAILED at 16.
          Hunk #2 succeeded at 29 (offset 3 lines).
          1 out of 2 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/model/RefreshStateModifyTask.java.rej
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/model/SyncClientSideStateTask.java
          Hunk #1 succeeded at 23 with fuzz 2.
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/util/LifecycleElement.java
          Reversed (or previously applied) patch detected!  Assume -R? [n] n
          Apply anyway? [n] n
          Skipping patch.
          2 out of 2 hunks ignored -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/util/LifecycleElement.java.rej
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/util/RecycleUtils.java
          patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/view/View.java
          Hunk #1 FAILED at 21.
          Hunk #2 FAILED at 45.
          Hunk #3 FAILED at 52.
          Hunk #4 succeeded at 458 (offset 5 lines).
          Hunk #5 succeeded at 474 (offset 5 lines).
          3 out of 5 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/view/View.java.rej
          patching file rice-framework/krad-web-framework/src/main/resources/org/kuali/rice/krad/config/KRADSpringBeans.xml
          Hunk #1 succeeded at 687 (offset 38 lines).
          patching file rice-framework/krad-web-framework/src/main/resources/org/kuali/rice/krad/uif/UifConfigurationDefinitions.xml
          patching file rice-framework/krad-web-framework/src/test/java/org/kuali/rice/krad/uif/lifecycle/ComponentFreemarkerTest.java
          Hunk #1 FAILED at 18.
          Hunk #2 succeeded at 35 (offset 3 lines).
          Hunk #3 FAILED at 122.
          Hunk #4 FAILED at 133.
          3 out of 4 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/test/java/org/kuali/rice/krad/uif/lifecycle/ComponentFreemarkerTest.java.rej
          patching file rice-framework/krad-web-framework/src/test/java/org/kuali/rice/krad/uif/lifecycle/ViewLifecycleTest.java
          patching file rice-framework/krad-web-framework/src/test/resources/KRAD-UifDefaults-test-context.xml
          Hunk #1 succeeded at 51 with fuzz 2 (offset 4 lines).
          
          Show
          Mark Fyffe (Inactive) added a comment - The patch was made against 2.4 in March, so there are quite a few rejects now against 2.5 - sorry for any confusion, I will definitely leave this change off of the 2.4 branch. I've applied patch to 2.5, and am working through rejects now - captured below for reference. Targeting Sunday to have this update working. $ patch -p0 < KULRICE-12040-freemarker_error.patch.txt patching file rice-framework/krad-sampleapp/web/pom.xml Hunk #1 succeeded at 350 (offset 14 lines). patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/datadictionary/DataDictionary.java Hunk #2 succeeded at 69 (offset 1 line). Hunk #3 succeeded at 741 (offset 16 lines). patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/service/KRADServiceLocatorWeb.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/component/ComponentBase.java Hunk #1 succeeded at 21 with fuzz 1. Hunk #2 succeeded at 36 with fuzz 1. Hunk #3 FAILED at 50. Hunk #4 succeeded at 252 (offset 18 lines). Hunk #5 FAILED at 253. Hunk #6 succeeded at 288 (offset 17 lines). Hunk #7 FAILED at 285. Hunk #8 FAILED at 306. Hunk #9 FAILED at 315. Hunk #10 FAILED at 323. Hunk #11 FAILED at 334. Hunk #12 succeeded at 359 (offset 14 lines). Hunk #13 succeeded at 554 (offset 42 lines). Hunk #14 succeeded at 614 (offset 58 lines). Hunk #15 succeeded at 864 (offset 59 lines). Hunk #16 succeeded at 1002 (offset 78 lines). Hunk #17 succeeded at 1020 (offset 78 lines). Hunk #18 succeeded at 1088 (offset 78 lines). Hunk #19 succeeded at 1141 (offset 78 lines). Hunk #20 succeeded at 1160 (offset 78 lines). Hunk #21 succeeded at 1179 (offset 78 lines). Hunk #22 FAILED at 1263. Hunk #23 FAILED at 1361. Hunk #24 succeeded at 1456 (offset 81 lines). Hunk #25 FAILED at 1771. Hunk #26 succeeded at 1933 with fuzz 1 (offset 115 lines). Hunk #27 succeeded at 1963 (offset 115 lines). Hunk #28 succeeded at 1978 with fuzz 1 (offset 115 lines). Hunk #29 succeeded at 1988 (offset 115 lines). Hunk #30 succeeded at 1998 (offset 115 lines). Hunk #31 succeeded at 2008 (offset 115 lines). Hunk #32 succeeded at 2018 (offset 115 lines). Hunk #33 succeeded at 2027 (offset 115 lines). Hunk #34 succeeded at 2037 with fuzz 1 (offset 115 lines). Hunk #35 succeeded at 2064 with fuzz 1 (offset 115 lines). Hunk #36 succeeded at 2079 (offset 115 lines). Hunk #37 succeeded at 2103 (offset 115 lines). Hunk #38 succeeded at 2122 (offset 115 lines). Hunk #39 succeeded at 2178 with fuzz 1 (offset 115 lines). Hunk #40 succeeded at 2194 (offset 115 lines). Hunk #41 succeeded at 2223 (offset 115 lines). Hunk #42 succeeded at 2231 with fuzz 1 (offset 115 lines). Hunk #43 succeeded at 2246 (offset 115 lines). Hunk #44 succeeded at 2257 with fuzz 1 (offset 107 lines). Hunk #45 succeeded at 2369 (offset 115 lines). Hunk #46 FAILED at 2332. Hunk #47 FAILED at 2356. Hunk #48 succeeded at 2586 (offset 193 lines). Hunk #49 succeeded at 2621 (offset 193 lines). 12 out of 49 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/component/ComponentBase.java.rej patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/container/InitializeContainerFromHelperTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/container/ProcessRemoteFieldsHolderTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/field/DataFieldBase.java Reversed (or previously applied) patch detected! Assume -R? [n] n Apply anyway? [n] n Skipping patch. 3 out of 3 hunks ignored -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/field/DataFieldBase.java.rej patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/field/InitializeDataFieldFromDictionaryTask.java Hunk #1 succeeded at 24 with fuzz 1 (offset 1 line). Hunk #2 succeeded at 38 (offset -2 lines). patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/freemarker/RenderComponentTask.java Hunk #1 FAILED at 18. Hunk #2 FAILED at 35. Hunk #4 FAILED at 82. 3 out of 4 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/freemarker/RenderComponentTask.java.rej patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/layout/LayoutManagerBase.java Hunk #1 succeeded at 21 with fuzz 1. Hunk #2 FAILED at 28. Hunk #3 succeeded at 210 (offset -1 lines). 1 out of 3 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/layout/LayoutManagerBase.java.rej patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ApplyModelComponentPhase.java Hunk #1 FAILED at 17. Hunk #2 FAILED at 66. Hunk #3 FAILED at 83. Hunk #4 FAILED at 119. Hunk #5 succeeded at 138 (offset -35 lines). Hunk #6 FAILED at 184. Hunk #7 succeeded at 204 (offset -17 lines). 5 out of 7 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ApplyModelComponentPhase.java.rej patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/FinalizeComponentPhase.java Hunk #1 FAILED at 15. Hunk #2 succeeded at 63 (offset 1 line). Hunk #3 FAILED at 120. Hunk #4 succeeded at 179 (offset 4 lines). Hunk #5 succeeded at 202 (offset 4 lines). 2 out of 5 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/FinalizeComponentPhase.java.rej patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/InitializeComponentPhase.java Hunk #2 succeeded at 90 (offset 10 lines). patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/LifecycleBase.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/LifecyclePhaseFactory.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/LifecycleTaskFactory.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/PreProcessElementPhase.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/RenderComponentPhase.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/RunComponentModifiersTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ViewLifecycle.java Hunk #1 succeeded at 18 with fuzz 2 (offset -1 lines). Hunk #2 succeeded at 75 with fuzz 2 (offset -4 lines). Hunk #3 succeeded at 555 (offset -11 lines). patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ViewLifecycleBuild.java Hunk #1 succeeded at 18 (offset -1 lines). Hunk #2 succeeded at 125 (offset 1 line). Hunk #3 succeeded at 140 (offset 1 line). Hunk #4 succeeded at 159 (offset 1 line). Hunk #5 succeeded at 185 (offset 4 lines). Hunk #6 succeeded at 203 (offset 4 lines). patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ViewLifecyclePhase.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ViewLifecyclePhaseBase.java Hunk #1 FAILED at 43. Hunk #2 FAILED at 110. Hunk #3 FAILED at 147. Hunk #4 FAILED at 191. Hunk #5 succeeded at 313 (offset -15 lines). Hunk #6 FAILED at 338. Hunk #7 succeeded at 391 (offset -14 lines). Hunk #8 succeeded at 403 (offset -14 lines). Hunk #9 succeeded at 458 (offset -14 lines). Hunk #10 succeeded at 493 (offset -14 lines). Hunk #11 FAILED at 515. Hunk #12 succeeded at 520 (offset -12 lines). Hunk #13 succeeded at 545 (offset -12 lines). Hunk #14 succeeded at 561 (offset -12 lines). Hunk #15 succeeded at 608 (offset -4 lines). Hunk #16 succeeded at 644 (offset -4 lines). 6 out of 16 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ViewLifecyclePhaseBase.java.rej patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ViewLifecyclePhaseBuilder.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ViewLifecyclePhaseBuilderBase.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ViewLifecyclePreProcessBuild.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ViewLifecycleTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/ViewLifecycleTaskBase.java Hunk #5 succeeded at 121 (offset 5 lines). patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/finalize/AddViewTemplatesTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/finalize/ComponentDefaultFinalizeTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/finalize/FinalizeViewTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/finalize/HelperCustomFinalizeTask.java Hunk #1 FAILED at 17 (different line endings). Hunk #2 FAILED at 29 (different line endings). 2 out of 2 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/finalize/HelperCustomFinalizeTask.java.rej patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/finalize/InvokeFinalizerTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/finalize/RegisterPropertyEditorTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/finalize/SetReadOnlyOnDataBindingTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/AssignIdsTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/ComponentDefaultInitializeTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/HelperCustomInitializeTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/InitializeContainerFromHelperTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/InitializeDataFieldFromDictionaryTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/PopulateComponentFromExpressionGraphTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/PopulatePathTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/PopulateReplacersAndModifiersFromExpressionGraphTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/PrepareForCacheTask.java Hunk #1 FAILED at 16. Hunk #2 succeeded at 31 (offset 2 lines). 1 out of 2 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/PrepareForCacheTask.java.rej patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/ProcessRemoteFieldsHolderTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/initialize/SortContainerTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/model/ApplyAuthAndPresentationLogicTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/model/ComponentDefaultApplyModelTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/model/EvaluateExpressionsTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/model/HelperCustomApplyModelTask.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/model/PopulateComponentContextTask.java Hunk #1 FAILED at 20. Hunk #2 succeeded at 30 (offset -2 lines). 1 out of 2 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/model/PopulateComponentContextTask.java.rej patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/model/RefreshStateModifyTask.java Hunk #1 FAILED at 16. Hunk #2 succeeded at 29 (offset 3 lines). 1 out of 2 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/model/RefreshStateModifyTask.java.rej patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/lifecycle/model/SyncClientSideStateTask.java Hunk #1 succeeded at 23 with fuzz 2. patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/util/LifecycleElement.java Reversed (or previously applied) patch detected! Assume -R? [n] n Apply anyway? [n] n Skipping patch. 2 out of 2 hunks ignored -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/util/LifecycleElement.java.rej patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/util/RecycleUtils.java patching file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/view/View.java Hunk #1 FAILED at 21. Hunk #2 FAILED at 45. Hunk #3 FAILED at 52. Hunk #4 succeeded at 458 (offset 5 lines). Hunk #5 succeeded at 474 (offset 5 lines). 3 out of 5 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/main/java/org/kuali/rice/krad/uif/view/View.java.rej patching file rice-framework/krad-web-framework/src/main/resources/org/kuali/rice/krad/config/KRADSpringBeans.xml Hunk #1 succeeded at 687 (offset 38 lines). patching file rice-framework/krad-web-framework/src/main/resources/org/kuali/rice/krad/uif/UifConfigurationDefinitions.xml patching file rice-framework/krad-web-framework/src/test/java/org/kuali/rice/krad/uif/lifecycle/ComponentFreemarkerTest.java Hunk #1 FAILED at 18. Hunk #2 succeeded at 35 (offset 3 lines). Hunk #3 FAILED at 122. Hunk #4 FAILED at 133. 3 out of 4 hunks FAILED -- saving rejects to file rice-framework/krad-web-framework/src/test/java/org/kuali/rice/krad/uif/lifecycle/ComponentFreemarkerTest.java.rej patching file rice-framework/krad-web-framework/src/test/java/org/kuali/rice/krad/uif/lifecycle/ViewLifecycleTest.java patching file rice-framework/krad-web-framework/src/test/resources/KRAD-UifDefaults-test-context.xml Hunk #1 succeeded at 51 with fuzz 2 (offset 4 lines).
          Hide
          Mark Fyffe (Inactive) added a comment -

          Patch has been reapplied locally, and all unit tests are passing. The issues noted in March, of missing and/or broken page elements are no longer happening. So far full build lifecycle is working properly for views in KRAD sampleapp, but some AJAX calls are returning in error - nothing concerning so far, but it'll take another hour or two to clean everything up and complete regression testing.

          I'm continue running through regression testing today and will commit as soon as everything appears to be stable.

          Show
          Mark Fyffe (Inactive) added a comment - Patch has been reapplied locally, and all unit tests are passing. The issues noted in March, of missing and/or broken page elements are no longer happening. So far full build lifecycle is working properly for views in KRAD sampleapp, but some AJAX calls are returning in error - nothing concerning so far, but it'll take another hour or two to clean everything up and complete regression testing. I'm continue running through regression testing today and will commit as soon as everything appears to be stable.
          Hide
          Mark Fyffe (Inactive) added a comment -

          Corrected issues with viewPath and refreshPaths population left over from original patch. In regression testing this evening, all full view builds and refresh calls were working as expected.

          Committed to 2.5 trunk.

          Show
          Mark Fyffe (Inactive) added a comment - Corrected issues with viewPath and refreshPaths population left over from original patch. In regression testing this evening, all full view builds and refresh calls were working as expected. Committed to 2.5 trunk.

            People

            • Assignee:
              Mark Fyffe (Inactive)
              Reporter:
              Jerry Neal (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1 day Original Estimate - 1 day
                1d
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 days, 3 hours
                3d 3h

                  Structure Helper Panel