Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-12233

workflowDocument should not be a field on the DocumentHeader

    Details

    • Type: Improvement Improvement
    • Status: Open Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 2.4
    • Fix Version/s: 2.6
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
    • Similar issues:
      KULRICE-9380refactor DocumentHeader so that we can remove special logic for stashing the WorkflowDocument in the UserSession
      KULRICE-12914The documentHeaderService is not repopulating the workflowDocument
      KULRICE-13965In dev environment, WorkflowDocument is null in DocumentHeader on maintenance doc submit
      KULRICE-5937Add javadocs to WorkflowDocument and WorkflowDocumentFactory
      KULRICE-9102Determine how best to handle linking to DocumentHeader using JPA as was done with OJB
      KULRICE-2423Convert DocumentHeader into an interface and make into an EBO.
      KULRICE-5325Get rid of KualiWorkflowDocument, replace with standard WorkflowDocument KEW api
      KULRICE-11664DocumentBase JPA versus OJB change regarding saving/restoring documentHeader
      KULRICE-4778Too much logic in eDocLite class "WorkflowDocument" related to population of the valid actions map
      KULRICE-7130Asterisk should not be displayed for read only fields
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      It doesn't make sense for workflowDocument to be a field on the DocumentHeader, instead it should be passed around separately as needed. The getWorkflowDocument method should be deprecated, and usages of it within Rice should be removed.

        Issue Links

          Activity

          Hide
          Jonathan Keller added a comment -

          This will be a huge impact to KFS if the getWorkflowDocument() method is used. (knowing how many times that is used.)

          Given how it is used - DocumentHeader will need to retain a cache of the value, since much KFS code does not hold the reference, but instead calls getWorkflowDocument() a number of times to make changes and then assumes it will be saved with the DocumentService.save/route call.

          Show
          Jonathan Keller added a comment - This will be a huge impact to KFS if the getWorkflowDocument() method is used. (knowing how many times that is used.) Given how it is used - DocumentHeader will need to retain a cache of the value, since much KFS code does not hold the reference, but instead calls getWorkflowDocument() a number of times to make changes and then assumes it will be saved with the DocumentService.save/route call.

            People

            • Assignee:
              Unassigned
              Reporter:
              Eric Westfall
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:

                Time Tracking

                Estimated:
                Original Estimate - 1 day, 4 hours
                1d 4h
                Remaining:
                Remaining Estimate - 1 day, 4 hours
                1d 4h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Structure Helper Panel