Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-12374

Provide method to create disapproval note text in DocumentControllerBase

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.4
    • Fix Version/s: 2.3.5
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-12561Add Dialogs to DocumentControllerBase methods
      KULRICE-5334Docs - Finish DocumentControllerBase (all workflow methods)
      KULRICE-12562Gap Analysis of DocumentControllerBase
      KULRICE-8290Reload on Note Text (13)
      KULRICE-13841Create controller/form for transactional documents
      KULRICE-11735AFT Failure ActionList Disapprove JpaOptimisticLockingFailureException org.kuali.rice.krad.bo.Note
      KULRICE-11682Decide on provided help text
      KULRICE-12559Document controller is missing recall method
      KULRICE-11829AFT Failure PeopleFlowCreateNewNotesAndAttachmentsAft Note Text is a required field is not present
      KULRICE-7594Provide input field instance to key value finder method getKeyValues
    • Rice Module:
      KRAD
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      KPME wants to create some text when a document is disapproved.

      In DocumentControllerBase.performWorkflowAction there is:

      case DISAPPROVE:
                          // TODO: need to get disapprove note from user
                          String disapprovalNoteText = "";
                          getDocumentService().disapproveDocument(document, disapprovalNoteText);
                          successMessageKey = RiceKeyConstants.MESSAGE_ROUTE_DISAPPROVED;
                          break;
      

      Instead of defaulting the disapprovalNoteText to an empty string, it would be better to create a protected method that returns an empty string that could be overridden (preventing this very large method from being totally overridden).

      something liike:

        protected generateDissaprovalNote(DocumentFormBase form, boolean checkSensitiveData) {
           return "";
      }
      

      and then calling this instead.

        Issue Links

          Activity

          Hide
          Jeremy Hanson added a comment -

          attached patch

          Show
          Jeremy Hanson added a comment - attached patch

            People

            • Assignee:
              Jeremy Hanson
              Reporter:
              Jeremy Hanson
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1 hour
                1h
                Remaining:
                Remaining Estimate - 1 hour
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Structure Helper Panel