Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-12477

Update DocumentRefreshQueueImpl to properly delete old action requests

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.4.1
    • Component/s: Development, Performance
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-12430Fix excessive memory usage on requests with many action requests
      KULRICE-13531 reduce the Action List CI Jobs history so old artifacts get deleted
      KULRICE-11245Create Automated Functional (Smoke) Tests for Action list (old sample app)
      KULRICE-14188DocOps: Deleting an action request which shares an action taken id with another request causes an error
      KULRICE-5346Delete collection line on editing maintenance doc - not deleting old collection line
      KULRICE-2729The "Future Action Requests" tab on the Route Log does not work properly with a client application using "embedded" mode
      KULRICE-12117Problems with "Future Action Requests" involving initiator routing
      KULRICE-7113Delete generated action items on request deactivation to prevent emails from being sent
      KULRICE-5681Implement ability for RequestNode to be called multiple times to generate action requests
      KULRICE-3718Allow Ad Hoc action requests on documents with no route nodes
    • Sprint:
      2.5.0-m3 Sprint 1
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      Patch the DocumentRefreshQueueImpl class' refreshDocument method to properly delete action requests when it's supposed to.

      There is a bug in the implementation. It looks at the generated top-level request and uses that to determine that it should not remove the old requests. (In the case of first-approve role routing, the top level one is always system-generated as a wrapper around the "real" requests.)

      I've patched the code so that it checks the first present child request to see if it should remove the action request tree.

        Issue Links

          Activity

          Hide
          Jonathan Keller added a comment -

          Related to KULRICE-12430 as this is one of the reasons we have so many action requests building up.

          Show
          Jonathan Keller added a comment - Related to KULRICE-12430 as this is one of the reasons we have so many action requests building up.
          Hide
          Kristina Taylor (Inactive) added a comment -

          Please remember to apply this performance patch to the 2.4 branch and clean it up as per Rice standards.

          Show
          Kristina Taylor (Inactive) added a comment - Please remember to apply this performance patch to the 2.4 branch and clean it up as per Rice standards.

            People

            • Assignee:
              Kristina Taylor (Inactive)
              Reporter:
              Jonathan Keller
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 2 hours
                2h
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour Time Not Required
                1h

                  Agile

                    Structure Helper Panel