Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-12477

Update DocumentRefreshQueueImpl to properly delete old action requests

          Details

          • Type: Bug Fix
          • Status: Closed
          • Priority: Major
          • Resolution: Fixed
          • Affects Version/s: None
          • Fix Version/s: 2.4.1
          • Component/s: Development, Performance
          • Security Level: Public (Public: Anyone can view)
          • Labels:
            None
          • Sprint:
            2.5.0-m3 Sprint 1
          • KAI Review Status:
            Not Required
          • KTI Review Status:
            Not Required
          • Code Review Status:
            Not Required
          • Include in Release Notes?:
            Yes

            Description

            Patch the DocumentRefreshQueueImpl class' refreshDocument method to properly delete action requests when it's supposed to.

            There is a bug in the implementation. It looks at the generated top-level request and uses that to determine that it should not remove the old requests. (In the case of first-approve role routing, the top level one is always system-generated as a wrapper around the "real" requests.)

            I've patched the code so that it checks the first present child request to see if it should remove the action request tree.

              Attachments

                Issue Links

                relates to

                Task - A task that needs to be done. KULRICE-12430 Fix excessive memory usage on requests with many action requests

                • Critical - Crashes, loss of data, severe memory leak.
                • Closed

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  jkeller Jonathan Keller added a comment -

                  Related to KULRICE-12430 as this is one of the reasons we have so many action requests building up.

                  Show
                  jkeller Jonathan Keller added a comment - Related to KULRICE-12430 as this is one of the reasons we have so many action requests building up.
                  Hide
                  Permalink
                  kbtaylor Kristina Taylor (Inactive) added a comment -

                  Please remember to apply this performance patch to the 2.4 branch and clean it up as per Rice standards.

                  Show
                  kbtaylor Kristina Taylor (Inactive) added a comment - Please remember to apply this performance patch to the 2.4 branch and clean it up as per Rice standards.

                    People

                    • Assignee:
                      kbtaylor Kristina Taylor (Inactive)
                      Reporter:
                      jkeller Jonathan Keller
                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      2 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:

                        Time Tracking

                        Estimated:
                        Original Estimate - 2 hours
                        2h
                        Remaining:
                        Remaining Estimate - 0 minutes
                        0m
                        Logged:
                        Time Spent - 1 hour Time Not Required
                        1h