Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-12477

Update DocumentRefreshQueueImpl to properly delete old action requests

    Details

    • Type: Bug Fix
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.4.1
    • Component/s: Development, Performance
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Sprint:
      2.5.0-m3 Sprint 1
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      Patch the DocumentRefreshQueueImpl class' refreshDocument method to properly delete action requests when it's supposed to.

      There is a bug in the implementation. It looks at the generated top-level request and uses that to determine that it should not remove the old requests. (In the case of first-approve role routing, the top level one is always system-generated as a wrapper around the "real" requests.)

      I've patched the code so that it checks the first present child request to see if it should remove the action request tree.

        Attachments

          Issue Links

            Activity

            jkeller Jonathan Keller created issue -
            jkeller Jonathan Keller made changes -
            Field Original Value New Value
            Link This issue relates to KULRICE-12430 [ KULRICE-12430 ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Fix Version/s 2.4.1 [ 17516 ]
            kbtaylor Kristina Taylor (Inactive) made changes -
            Sprint 2.5.0-m3 Sprint 2 [ 299 ]
            kbtaylor Kristina Taylor (Inactive) made changes -
            Rank Ranked lower
            kbtaylor Kristina Taylor (Inactive) made changes -
            Original Estimate 2 hours [ 7200 ]
            Remaining Estimate 2 hours [ 7200 ]
            kbtaylor Kristina Taylor (Inactive) made changes -
            Assignee Kristina Taylor [ kbtaylor ]
            kbtaylor Kristina Taylor (Inactive) made changes -
            Sprint 2.5.0-m3 Sprint 2 [ 299 ] 2.5.0-m3 Sprint 1 [ 286 ]
            kbtaylor Kristina Taylor (Inactive) made changes -
            Rank Ranked lower
            kbtaylor Kristina Taylor (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            kbtaylor Kristina Taylor (Inactive) made changes -
            Remaining Estimate 2 hours [ 7200 ] 0 minutes [ 0 ]
            Time Spent 1 hour [ 3600 ]
            Worklog Id 95657 [ 95657 ]
            kbtaylor Kristina Taylor (Inactive) made changes -
            Status In Progress [ 3 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            masargen Matt Sargent made changes -
            Status Resolved [ 5 ] Closed [ 6 ]

              People

              • Assignee:
                kbtaylor Kristina Taylor (Inactive)
                Reporter:
                jkeller Jonathan Keller
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 2 hours
                  2h
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour Time Not Required
                  1h