Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-12542

Prevent KRAD views from opening in doc search iframe

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-5993doc search view of krad maintenance doc shows hidden fields
      KULRICE-13224Hitting cancel after opening KRAD doc from document search throws an error
      KULRICE-5990View content in iFrame analysis
      KULRICE-5799JS errors appear after going to doc search and then to another view
      KULRICE-7833After iFrame removal support - do not allow KRAD content to be in an iframe
      KULRICE-11740KRAD screen that handles attempts to open unsaved documents is broken in Rice 2.3.x
      KULRICE-925Super user doc search not working?
      KULRICE-13504Fill AFT Gap: Edit travel app doc from search results
      KULRICE-13210STE when attempting to open KRMS agenda doc from Doc Search
      KULRICE-2548Docs opened from action list and document search are opening in a new window
    • Epic Link:
    • Rice Module:
      KRAD
    • Application Requirement:
      KC
    • Sprint:
      2.5.0-m2 Sprint 3, 2.5.0-m3 Sprint 1
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes
    • Story Points:
      1

      Description

      If you open doc search in an iframe (surrounded by an app header). Then doc search has a link to open a document. This document will open in the iframe with the app header, so now you have two app headers.

      There are a few different ways we could approach this issue.

      One, we could support a request parameter that indicates whether the app header should be rendered (then the app header would have a render condition that looks at this, similar to renderedInLightbox). All URLs opening a view would need to pass this to suppress the app header. The problem with this is the following. If you add it to the action list or doc search handler URL, it would be fine if doc search/action list was in an iframe and the user clicked the URL. But if doc search/action list was not in an iframe, or the user select open in new window, the app header would not render (and in this case we would need it to).

      Another option would be to add script on document ready that would check whether the view is within an iframe, and if so, hide (or remove) the app header.

        Activity

        Hide
        Jeff Heckel (Inactive) added a comment -

        i added a toLowerCase call before returning the target.
        can you test ASAP and let me know if that solves it.

        Show
        Jeff Heckel (Inactive) added a comment - i added a toLowerCase call before returning the target. can you test ASAP and let me know if that solves it.
        Hide
        Douglas Pace added a comment -

        Jeff - Sorry I didn't get to test this until now, but difficult due to needing to upgrade Rice. Looks like this might fix it for action lists, but doesn't fix it for doc search. Docsearch still exhibits the same problem.

        Show
        Douglas Pace added a comment - Jeff - Sorry I didn't get to test this until now, but difficult due to needing to upgrade Rice. Looks like this might fix it for action lists, but doesn't fix it for doc search. Docsearch still exhibits the same problem.
        Hide
        Douglas Pace added a comment -

        Jeff - I also notice that the value is being stored in the DB in all uppercase. Is there a reason why it doesn't just store the value as defined in the XML?

        Show
        Douglas Pace added a comment - Jeff - I also notice that the value is being stored in the DB in all uppercase. Is there a reason why it doesn't just store the value as defined in the XML?
        Hide
        Jeff Heckel (Inactive) added a comment -

        I cannot speak to how ingesting XML gets stored into the database. I would think that is core Rice and I am not familiar with that.

        Show
        Jeff Heckel (Inactive) added a comment - I cannot speak to how ingesting XML gets stored into the database. I would think that is core Rice and I am not familiar with that.
        Hide
        Jeff Heckel (Inactive) added a comment -

        Ok. I committed another attempt. I also noted that this parameter is involved:

        KR-WKFLW DocumentSearch DOCUMENT_SEARCH_POPUP_IND E78100F6F14C4932B54F7719FA5C27E9 2 CONFG Y Flag to specify if clicking on a Document ID from Document Search will load the Document in a new window. A KUALI

        When this is true/Y (the default) it would set target as '_blank'. Now it will use what the doc type policy says. If this was false/N it should have behaved properly for document search.

        Show
        Jeff Heckel (Inactive) added a comment - Ok. I committed another attempt. I also noted that this parameter is involved: KR-WKFLW DocumentSearch DOCUMENT_SEARCH_POPUP_IND E78100F6F14C4932B54F7719FA5C27E9 2 CONFG Y Flag to specify if clicking on a Document ID from Document Search will load the Document in a new window. A KUALI When this is true/Y (the default) it would set target as '_blank'. Now it will use what the doc type policy says. If this was false/N it should have behaved properly for document search.

          People

          • Assignee:
            Jeff Heckel (Inactive)
            Reporter:
            Jerry Neal (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1 day Original Estimate - 1 day
              1d
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 1 day, 6 hours
              1d 6h

                Agile

                  Structure Helper Panel