Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-12617

Remove updateActionAttributes from AgendaBoServiceImpl

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5.1
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-14012deleteAgenda() AgendaBoServiceImpl incorrectly implemented
      KULRICE-10178Remove SessionDocumentService from KRAD
      KULRICE-5005Remove getDefaultCountry from CountryService
      KULRICE-5121Remove JsValue from ValidCharactersConstraint
      KULRICE-1767Remove org.kuali.core.util.UnitTestSqlDao from Rice
      KULRICE-3381Remove "setSearchableAttributes" from the DocumentSearchGenerator
      KULRICE-1996Remove lockCode from DocumentRouteHeaderValue
      KULRICE-1994Remove overrideIndicator from DocumentRouteHeaderValue
      KULRICE-2537Remove KEWUserNotFoundException from the codebase
      KULRICE-2248Remove KOM module from Rice
    • Rice Team:
      Middleware
    • Rice Module:
      KRMS
    • Application Requirement:
      KS
    • Sprint:
      Core 2.5.0-m6 Sprint 2, Middleware 2.5.1 Sprint 1, Middleware 2.5.1 Sprint 2
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes
    • Story Points:
      5

      Description

      1) Remove updateActionAttribute call and methods from AgendaBoServiceImpl, it was only required for OJB that did not properly removed the old action attributes.

      2) AgendaBoServiceImpl should not be a "final" class as we my need to override it to fix things like #1.

      Workaround: See attached patch file in linked issue

        Issue Links

          Activity

          Hide
          Larry Symms added a comment -

          workaround: Duplicate AgendaBoServiceImpl with different name and rework the service wiring to point to that

          Show
          Larry Symms added a comment - workaround: Duplicate AgendaBoServiceImpl with different name and rework the service wiring to point to that
          Hide
          Kristina Taylor (Inactive) added a comment -

          I'm hesitant to remove methods this late in 2.5. I think removing the "final" should be okay so you don't have to rework everything, but we will probably have to revisit removing these methods as I see they were caused by a Rice 2.4.x upgrade.

          Show
          Kristina Taylor (Inactive) added a comment - I'm hesitant to remove methods this late in 2.5. I think removing the "final" should be okay so you don't have to rework everything, but we will probably have to revisit removing these methods as I see they were caused by a Rice 2.4.x upgrade.
          Hide
          Kristina Taylor (Inactive) added a comment - - edited

          I've removed final from the following classes and their tests. The rest of the work will need to be pushed to later.

          ActionBoServiceImpl
          AgendaBoServiceImpl
          ContextBoServiceImpl
          NaturalLanguageTemplateBoServiceImpl
          NaturalLanguageUsageBoServcieImpl
          PropositionBoServiceImpl
          ReferenceObjectBindingBoServiceImpl
          RuleBoServiceImpl
          TypeTypeRelationBoServiceImpl
          
          Show
          Kristina Taylor (Inactive) added a comment - - edited I've removed final from the following classes and their tests. The rest of the work will need to be pushed to later. ActionBoServiceImpl AgendaBoServiceImpl ContextBoServiceImpl NaturalLanguageTemplateBoServiceImpl NaturalLanguageUsageBoServcieImpl PropositionBoServiceImpl ReferenceObjectBindingBoServiceImpl RuleBoServiceImpl TypeTypeRelationBoServiceImpl
          Hide
          Kristina Taylor (Inactive) added a comment -

          I was able to reproduce your bug in test and confirmed that your fix will work. I also will make some additional changes to help you extend our services without hacks. Please let us know in a new issue if there are additional places where you need to extend services and found it difficult.

          Show
          Kristina Taylor (Inactive) added a comment - I was able to reproduce your bug in test and confirmed that your fix will work. I also will make some additional changes to help you extend our services without hacks. Please let us know in a new issue if there are additional places where you need to extend services and found it difficult.
          Hide
          Martin Taylor (Inactive) added a comment -

          Closing 2.5.1 Development

          Show
          Martin Taylor (Inactive) added a comment - Closing 2.5.1 Development

            People

            • Assignee:
              Kristina Taylor (Inactive)
              Reporter:
              Larry Symms
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Agile

                  Structure Helper Panel