Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-12622

KRAD Demo: Client side validation for search criteria

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Rice Module:
      KRAD
    • Application Requirement:
      Rice
    • Sprint:
      2.5.0-m3 Sprint 1
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      Requires KULRICE-12623 to be completed

      On the Travel Account Lookup with stacked layout (see KULRICE-12623) add the following client side validations:

      • required: on the Travel Account Number field
      • validation pattern: Basic Date constraint on the Date Created field (see KRAD Libary -> Validation -> Date Constraint -> Basic Date)

        Attachments

          Issue Links

            Activity

            Hide
            shahess Shannon Hess added a comment -

            The Date Created field is not currently a LookupCriteriaInputField for the LookupSampleViewStackedResults view. Should it be added? If so, what is the behavior that should occur when it is. i.e., should the search be halted before being submitted similar to what happens for a required search field?

            This is the current behavior when the BasicDatePatternConstraint is added to the Date Created input field (please also see attached screenshots):

            • If you enter a bad date and tab off of the field, the error constraint text will appear.
            • If you enter a bad date and hit search (either before or after tabbing off the field), an invalid date message is shown at the top of the screen but the date field is blanked out and the search results are still shown
            Show
            shahess Shannon Hess added a comment - The Date Created field is not currently a LookupCriteriaInputField for the LookupSampleViewStackedResults view. Should it be added? If so, what is the behavior that should occur when it is. i.e., should the search be halted before being submitted similar to what happens for a required search field? This is the current behavior when the BasicDatePatternConstraint is added to the Date Created input field (please also see attached screenshots): If you enter a bad date and tab off of the field, the error constraint text will appear. If you enter a bad date and hit search (either before or after tabbing off the field), an invalid date message is shown at the top of the screen but the date field is blanked out and the search results are still shown
            Hide
            shahess Shannon Hess added a comment -

            Attaching screenshots of current Date Created behavior

            Show
            shahess Shannon Hess added a comment - Attaching screenshots of current Date Created behavior
            Hide
            cniesen Claus Niesen added a comment -

            Yes to both: The Date Create field needs to be added. Client side validation should prevent submission if there is an error.

            If you enter a bad date and hit search (either before or after tabbing off the field), an invalid date message is shown at the top of the screen but the date field is blanked out and the search results are still shown

            This should not happen. Client side validation should prevent submission and server side validation should cause an error instead of blanking the date.

            Show
            cniesen Claus Niesen added a comment - Yes to both: The Date Create field needs to be added. Client side validation should prevent submission if there is an error. If you enter a bad date and hit search (either before or after tabbing off the field), an invalid date message is shown at the top of the screen but the date field is blanked out and the search results are still shown This should not happen. Client side validation should prevent submission and server side validation should cause an error instead of blanking the date.
            Hide
            shahess Shannon Hess added a comment - - edited

            For validCharactersConstraints, both the client side validation and server side validation for lookup criteria fields have been fixed. For testing purposes to verify it worked for any type of validCharactersConstraint, I tested various types of constraints to the account name field such as interger only & CharsetPatternConstraint. (removed the constraint from the name before committing)

            There was also a bug with the server side validation for required fields (message was "null is a required field." instead of "Travel account number is a required field.") That has also been fixed as part of this JIRA.

            DemoLookUpStackedResultsAft.java has also been updated to verify the error messages

            Link to lookup on env14 - http://env14.rice.kuali.org/kr-krad/lookup?methodToCall=start&viewId=LookupSampleViewStackedResults

            Show
            shahess Shannon Hess added a comment - - edited For validCharactersConstraints, both the client side validation and server side validation for lookup criteria fields have been fixed. For testing purposes to verify it worked for any type of validCharactersConstraint, I tested various types of constraints to the account name field such as interger only & CharsetPatternConstraint. (removed the constraint from the name before committing) There was also a bug with the server side validation for required fields (message was "null is a required field." instead of "Travel account number is a required field.") That has also been fixed as part of this JIRA. DemoLookUpStackedResultsAft.java has also been updated to verify the error messages Link to lookup on env14 - http://env14.rice.kuali.org/kr-krad/lookup?methodToCall=start&viewId=LookupSampleViewStackedResults

              People

              • Assignee:
                shahess Shannon Hess
                Reporter:
                cniesen Claus Niesen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 6 hours Original Estimate - 6 hours
                  6h
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day
                  1d