Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-12648

Maintenance Document cancel dialog causes scrollbars to disappear

    Details

    • Type: Bug Fix
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: User Experience (UX)
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Rice Module:
      KRAD
    • KRAD Feature Area:
      Maintenance
    • Sprint:
      2.5.0-m3 Sprint 2, 2.5.0-m4 Sprint 1
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      When cancelling a Maintenance document, a dialog will pop up asking whether the user wants to cancel or not. If the user selects "No" the document stays on the same page but the user can no longer scroll anywhere on the page and needs to back out to get to the main screens.

      Travel Account is a good place to see this. Create a new Travel Account document, go down to the bottom of the page, hit cancel, and then click "No" in the resulting dialog box. In the latest version of Firefox (at least) the scrollbar disappears and the screen is stuck in place.

        Attachments

          Issue Links

            Activity

            Hide
            cniesen Claus Niesen added a comment -

            Quite interesting. That behavior doesn't appear on the Travel Company submit dialog. Expand all sections to get the scroll bar on this page. The submit confirmation dialog is specially enabled on this document. Cancel on the Travel Company does remove the scroll bar, too.

            Show
            cniesen Claus Niesen added a comment - Quite interesting. That behavior doesn't appear on the Travel Company submit dialog. Expand all sections to get the scroll bar on this page. The submit confirmation dialog is specially enabled on this document. Cancel on the Travel Company does remove the scroll bar, too.
            Hide
            kbtaylor Kristina Taylor (Inactive) added a comment - - edited

            It looks like the two functions are implemented differently (for some reason). Cancel is

            <bean parent="Uif-CancelAction" p:confirmationPromptText="Are you sure you want to cancel?"
              p:render="@{#actionFlags[#Constants.KUALI_ACTION_CAN_CANCEL]}"/>
            

            while Submit is

            <bean parent="Uif-PrimaryActionButton" p:methodToCall="route" p:actionLabel="Submit"
              p:performClientSideValidation="true"
              p:render="@{#actionFlags[#Constants.KUALI_ACTION_CAN_ROUTE]}" p:defaultEnterKeyAction="true">
              <property name="confirmationDialog">
                <bean id="ConfirmSubmitDialog" parent="Uif-DialogGroup-OkCancel"
                  p:promptText="Are you sure you want to submit this document and send it into routing?"/>
              </property>
            </bean>
            

            I suppose you could fix it by switching to a specific dialog but that seems counterproductive since having the one confirmationPromptText is much easier to specify and maintain. It might also be that on Submit we want "OK" and "Cancel" instead of "Yes" and "No".

            Show
            kbtaylor Kristina Taylor (Inactive) added a comment - - edited It looks like the two functions are implemented differently (for some reason). Cancel is <bean parent= "Uif-CancelAction" p:confirmationPromptText= "Are you sure you want to cancel?" p:render= "@{#actionFlags[#Constants.KUALI_ACTION_CAN_CANCEL]}" /> while Submit is <bean parent= "Uif-PrimaryActionButton" p:methodToCall= "route" p:actionLabel= "Submit" p:performClientSideValidation= " true " p:render= "@{#actionFlags[#Constants.KUALI_ACTION_CAN_ROUTE]}" p:defaultEnterKeyAction= " true " > <property name= "confirmationDialog" > <bean id= "ConfirmSubmitDialog" parent= "Uif-DialogGroup-OkCancel" p:promptText= "Are you sure you want to submit this document and send it into routing?" /> </property> </bean> I suppose you could fix it by switching to a specific dialog but that seems counterproductive since having the one confirmationPromptText is much easier to specify and maintain. It might also be that on Submit we want "OK" and "Cancel" instead of "Yes" and "No".
            Hide
            tpaegle Tadas Paegle (Inactive) added a comment -

            Added handler binding for "hidden.bs.modal" event. Event wasn't firing to remove a modal style.

            Show
            tpaegle Tadas Paegle (Inactive) added a comment - Added handler binding for "hidden.bs.modal" event. Event wasn't firing to remove a modal style.
            Hide
            tpaegle Tadas Paegle (Inactive) added a comment -

            Ajax data submit was fired before the modal had a chance to close. Added more checking

            Show
            tpaegle Tadas Paegle (Inactive) added a comment - Ajax data submit was fired before the modal had a chance to close. Added more checking

              People

              • Assignee:
                tpaegle Tadas Paegle (Inactive)
                Reporter:
                kbtaylor Kristina Taylor (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 4 hours Original Estimate - 4 hours
                  4h
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 6 hours
                  6h