Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-12708

States are not taken into account when required indicator is set

    Details

    • Type: Bug Fix Bug Fix
    • Status: Open Open
    • Priority: Critical Critical
    • Resolution: Unresolved
    • Affects Version/s: 2.3.2, 2.4, 2.4.1
    • Fix Version/s: 2.6
    • Security Level: Public (Public: Anyone can view)
    • Labels:
    • Similar issues:
      KULRICE-12710Add ability to define the text for required for next state indicator
      KULRICE-7181WorkflowDocument.logAnnotation creates an Action Taken with a current indicator of 0
      KULRICE-8439Required indicator not appearing on table headers
      KULRICE-11914Travel Destination requires State even for non US locations
      KULRICE-10078Required indicator wraps below label when field is displayed in a dialog
      KULRICE-5434Missing and insufficient visual indication of focus
      KULRICE-9294Active indicator is not set properly on maintenance documents
      KULRICE-12396Remove required from Travel Account Type's active indicator
      KULRICE-10179Setting required="true" on field with file indicator does not require upload client side
      KULRICE-13277Demo Lookup Search subsidized percent required indicator not appearing for DD entry
    • Epic Link:
    • Rice Team:
      Framework
    • Rice Module:
      KRAD
    • Application Requirement:
      KS
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes
    • Story Points:
      3

      Description

      The required indicator for states beyond current+1 aren't being set correctly because the applicable state for the simpleConstraint isn't being taken into account.

      With this config ....

      <bean parent="WorkflowStateMapping">
           <property name="stateMapping">
                  <bean parent="WorkflowStateMapping">
                      <property name="customClientSideValidationStates">
                          <map>
                              <entry key="I" value="S" />
                              <entry key="S" value="S" />
                              <entry key="R" value="S" />
                              <entry key="P" value="S" />
      ...
      
      <bean id="CourseInfo.courseNumberSuffix" parent="CourseInfo.courseNumberSuffix-generated">
              <property name="simpleConstraint">
                  <bean parent="RequiredConstraint">
                      <property name="states">
                          <list>
                              <value>P</value>
      ...
      

      When the document state is "S" a required indicator ("*") is being displayed for courseNumberSuffix as well as other properties which are required for states "R+". This seems wrong since state "P" is "next state"+1.

      However, if I define the constraint like this (which I believe is just a more explicit version of the definition above)...

      <bean id="CourseInfo.courseNumberSuffix" parent="CourseInfo.courseNumberSuffix-generated">
              <property name="simpleConstraint">
                   <bean parent="SimpleConstraint">
                        <property name="required" value="false" />
                        <property name="states">
                             <list>
                                  <value>I,S,R</value>
                        ...          
                        <property name="constraintStateOverrides">
                             <list>
                                  <bean parent="RequiredConstraint">
                                       <property name="states">
                                            <list>
                                                 <value>P</value>
      

      ... I don't see the required indicator. IIRC it looked to me like the required indicator was being set based solely in the value of simpleConstraint#required and wasn't taking the value(s) of simpleConstraint#state into consideration.

        Issue Links

          Activity

          Hide
          Larry Symms added a comment -

          Confirmed occuring in 2.5 branch of KS

          Show
          Larry Symms added a comment - Confirmed occuring in 2.5 branch of KS

            People

            • Assignee:
              Unassigned
              Reporter:
              Glenn Sudduth (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:

                Structure Helper Panel