Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-12754

Krad Sample App Lookup Results are missing inquiry links

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Cannot Reproduce
    • Affects Version/s: 2.4.1
    • Fix Version/s: 2.4.2, 2.5
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-11475fix I11 sample
      KULRICE-11335samples for M35
      KULRICE-11119samples for I11
      KULRICE-11419KRAD Sample Travel App: Move unnecessary screens into their own menu section
      KULRICE-1200Get Rice sample app working again
      KULRICE-11130samples for I23
      KULRICE-11118samples for I10
      KULRICE-11131samples for I24, I25, I27
      KULRICE-11132samples for I26
      KULRICE-11127samples for I20
    • Rice Module:
      KRAD
    • KRAD Feature Area:
      Lookup
    • Application Requirement:
      Rice
    • Sprint:
      Core 2.5.0-m4 Sprint 1
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      Within the sample app (in 2.4), go to demo -> travel per diem lookup.
      Click on search.
      Notice that the Id and Primary Destination fields are not links, but should be.

        Issue Links

          Activity

          Hide
          Sona Sona (Inactive) added a comment -

          2.4.2 code in DataFieldBase which is causing the issue

          if (this.enableAutoInquiry && (this.inquiry == null) && isReadOnly() && bindingInfo != null) {
                      String bindingPath = bindingInfo.getBindingPath();
                      Object propertyValue = ObjectPropertyUtils.getPropertyValue(model, bindingPath);
          
                      if (propertyValue != null && !(propertyValue instanceof String) &&
                              KRADServiceLocator.getDataObjectService().supports(propertyValue.getClass())) {
                          this.inquiry = ComponentFactory.getInquiry();
                      }
                  }
          
                  if (isAddHiddenWhenReadOnly()) {
                      setReadOnly(true);
                      getAdditionalHiddenPropertyNames().add(getPropertyName());
                  }
          

          fails due to either one of these conditions
          !(propertyValue instanceof String)
          OR
          KRADServiceLocator.getDataObjectService().supports(propertyValue.getClass()).

          I do not understand why the propertyValue on which the inquiry is set cannot be a String and looks like KRADServiceLocator.getDataObjectService().supports() is returning a false for all the other datatypes.

          In 2.4.1 it used to be

          if (this.enableAutoInquiry && (this.inquiry == null) && isReadOnly()) {
                      buildAutomaticInquiry(model, false);
                  }
          
                  if (isAddHiddenWhenReadOnly()) {
                      setReadOnly(true);
                      getAdditionalHiddenPropertyNames().add(getPropertyName());
                  }
          
          Show
          Sona Sona (Inactive) added a comment - 2.4.2 code in DataFieldBase which is causing the issue if ( this .enableAutoInquiry && ( this .inquiry == null ) && isReadOnly() && bindingInfo != null ) { String bindingPath = bindingInfo.getBindingPath(); Object propertyValue = ObjectPropertyUtils.getPropertyValue(model, bindingPath); if (propertyValue != null && !(propertyValue instanceof String ) && KRADServiceLocator.getDataObjectService().supports(propertyValue.getClass())) { this .inquiry = ComponentFactory.getInquiry(); } } if (isAddHiddenWhenReadOnly()) { setReadOnly( true ); getAdditionalHiddenPropertyNames().add(getPropertyName()); } fails due to either one of these conditions !(propertyValue instanceof String) OR KRADServiceLocator.getDataObjectService().supports(propertyValue.getClass()). I do not understand why the propertyValue on which the inquiry is set cannot be a String and looks like KRADServiceLocator.getDataObjectService().supports() is returning a false for all the other datatypes. In 2.4.1 it used to be if ( this .enableAutoInquiry && ( this .inquiry == null ) && isReadOnly()) { buildAutomaticInquiry(model, false ); } if (isAddHiddenWhenReadOnly()) { setReadOnly( true ); getAdditionalHiddenPropertyNames().add(getPropertyName()); }
          Hide
          Mark Fyffe (Inactive) added a comment -

          I committed an update to rice-2.4 for KULRICE-12690 this morning that should resolve this issue. Can you confirm?

          Show
          Mark Fyffe (Inactive) added a comment - I committed an update to rice-2.4 for KULRICE-12690 this morning that should resolve this issue. Can you confirm?
          Hide
          Kristina Taylor (Inactive) added a comment -

          Yes, the inquiries and quickfinders are back, thanks!

          Show
          Kristina Taylor (Inactive) added a comment - Yes, the inquiries and quickfinders are back, thanks!
          Hide
          Kristina Taylor (Inactive) added a comment -

          Fixed via KULRICE-12690, resolving.

          Show
          Kristina Taylor (Inactive) added a comment - Fixed via KULRICE-12690 , resolving.

            People

            • Assignee:
              Kristina Taylor (Inactive)
              Reporter:
              Jeff Ruch
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1 day
                1d
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours Time Not Required
                2h

                  Agile

                    Structure Helper Panel