Details

    • Type: Bug Fix
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Rice Module:
      KRAD
    • Application Requirement:
      KC
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      When setting addWithDialog="true" on a collection, the resulting dialog contains no items from the collection definition.

      The following XML results in the attached screenshot when clicking on the add with dialog action.

      	<bean id="PropDev-CompliancePage-CollectionGroup" parent="PropDev-CompliancePage-CollectionGroup-parentBean" />
      	<bean id="PropDev-CompliancePage-CollectionGroup-parentBean"
      		parent="Uif-Disclosure-StackedCollectionSection" p:title="Compliance" p:propertyName="propSpecialReviews"
      		p:collectionObjectClass="org.kuali.coeus.propdev.impl.specialreview.ProposalSpecialReview"
      		p:layoutManager.summaryTitle="@{#line.specialReviewType.description} @{#line.approvalType.description} @{#line.protocolNumber}"
      		p:addWithDialog="true">
      		<property name="addWithDialogAction">
      			<bean parent="Uif-AddWithDialogAction" p:actionLabel="Add compliance entry" p:iconClass="icon-plus"/>
      		</property>
      		<property name="items">
      			<list>
      						<bean parent="Uif-InputField" p:propertyName="specialReviewTypeCode" p:order="10" />
      						<bean parent="Uif-InputField" p:propertyName="approvalTypeCode" p:order="20" />
      						<bean parent="Uif-InputField" p:propertyName="protocolNumber" p:order="30" />
      						<bean parent="Uif-InputField" p:propertyName="applicationDate" p:order="40" />
      						<bean parent="Uif-InputField" p:propertyName="approvalDate" p:order="50" />
      						<bean parent="Uif-InputField" p:propertyName="expirationDate" p:order="60" />
      						<bean parent="PropDev-CompliancePage-ExemptionTypeCodes" p:order="70" />
      						<bean parent="Uif-InputField" p:propertyName="comments" p:order="80" />
      			</list>
      		</property>
      		<property name="addLineActions">
      			<list>
      				<bean parent="Uif-AddLineAction" p:actionLabel="Add Entry"/>
      				<bean parent="Uif-CancelAction"/>
        			</list>
        		</property>
        		<property name="addLineLabel.messageText" value="Add New Protocol"/>
        		<property name="lineActions">
      			<list/>
      		</property>
      		<property name="layoutManager.lineGroupPrototype">
      			<bean parent="Uif-CollectionHorizontalBoxItem"
      				p:disclosure.render="true" p:disclosure.defaultOpen="false">
      				<property name="layoutManager">
      					<bean parent="Uif-SimpleLayout" />
      				</property>
      				<property name="header">
      					<bean parent="Uif-HeaderFour">
      						<property name="rightGroup">
      							<bean parent="Uif-VerticalBoxGroup">
      								<property name="items">
      									<list>
      										<bean parent="Uif-DeleteLineAction" p:actionLabel=""
      											p:iconClass="icon-close" p:order="10" />
      									</list>
      								</property>
      							</bean>
      						</property>
      					</bean>
      				</property>
      			</bean>
      		</property>
      	</bean>
      

        Attachments

          Issue Links

            Activity

            Hide
            jkneal Jerry Neal (Inactive) added a comment -

            Jeff,

            There were some recent changes put in that I hope will have fixed this issue. We just need a lab where we are configured the add line dialog like is done here and verify it is working.

            One thing that might be happening though is typically the add dialog is created from the addLineItems on the collection group. We should have a check to see if the items of the group are empty first. If they are not empty, do not override with the add line items.

            thanks,
            Jerry

            Show
            jkneal Jerry Neal (Inactive) added a comment - Jeff, There were some recent changes put in that I hope will have fixed this issue. We just need a lab where we are configured the add line dialog like is done here and verify it is working. One thing that might be happening though is typically the add dialog is created from the addLineItems on the collection group. We should have a check to see if the items of the group are empty first. If they are not empty, do not override with the add line items. thanks, Jerry
            Hide
            jheckel Jeff Heckel (Inactive) added a comment -

            Was an issue with stacked collection building the addLineGroup

            Show
            jheckel Jeff Heckel (Inactive) added a comment - Was an issue with stacked collection building the addLineGroup

              People

              • Assignee:
                jheckel Jeff Heckel (Inactive)
                Reporter:
                dpace Douglas Pace
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 1 day
                  1d
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day
                  1d