Details

    • Type: Bug Fix
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Epic Link:
    • Rice Module:
      KRAD
    • Application Requirement:
      KC
    • Sprint:
      UXI 2.5.0-m4 Sprint 2
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      In 2.5 the new dialog has display issues. See attachment for example. It appears, from reviewing the DOM and relevant CSS that this is due to the dialog layoutManager being a cssgrid, which is currently set to float:left. As best I can tell this causes the bootstrap dialog to shrink and display the content outside of its bounds. Here is some of the sample XML.

      	<bean id="PropDev-PersonnelPage-Wizard" parent="PropDev-PersonnelPage-Wizard-parentBean" />
      	<bean id="PropDev-PersonnelPage-Wizard-parentBean" abstract="true"
      		parent="Uif-DialogGroup" class="org.kuali.rice.contrib.uif.element.WizardGroup"
      		p:fieldBindingObjectPath="addKeyPersonHelper" p:resetDataOnRefresh="true"
      		p:retrieveViaAjax="true">
      		<property name="header">
      			<bean parent="Uif-HeaderOne" p:headerText="Add Personnel" />
      		</property>
      		<property name="items">
      			<list>
      				<bean parent="PropDev-PersonnelPage-WizardPage1" p:order="10" />
      				<bean parent="PropDev-PersonnelPage-WizardPage2" p:order="20" />
      				<bean parent="PropDev-PersonnelPage-WizardPage3" p:order="30" />
      			</list>
      		</property>
      	</bean>
      

        Attachments

          Activity

          Hide
          jkneal Jerry Neal (Inactive) added a comment -

          Doug,

          Are you ok with me resolving this issue?

          Jerry

          Show
          jkneal Jerry Neal (Inactive) added a comment - Doug, Are you ok with me resolving this issue? Jerry
          Hide
          dpace Douglas Pace added a comment -

          Jerry - Was there a jira for the 2.4 merge issue that fixed this? If you can link that, then sure. Resolve it and we'll test once we can update Rice.

          Show
          dpace Douglas Pace added a comment - Jerry - Was there a jira for the 2.4 merge issue that fixed this? If you can link that, then sure. Resolve it and we'll test once we can update Rice.
          Hide
          jkneal Jerry Neal (Inactive) added a comment -

          Hey Doug,

          I thought this was the one that you fixed by changing to vertical box layout? Once we get the wizard group into Rice, if similar problems exists we can revisit (however from my testing on the patch it seems to work).

          Jerry

          Show
          jkneal Jerry Neal (Inactive) added a comment - Hey Doug, I thought this was the one that you fixed by changing to vertical box layout? Once we get the wizard group into Rice, if similar problems exists we can revisit (however from my testing on the patch it seems to work). Jerry
          Hide
          dpace Douglas Pace added a comment -

          Jerry - You are right. That does work, but seems more like a workaround than a fix to me though? I agree its a strange problem, but having 2 cssgrid groups embedded in a dialog means you have rendering problems. Is that reasonable bug?

          Show
          dpace Douglas Pace added a comment - Jerry - You are right. That does work, but seems more like a workaround than a fix to me though? I agree its a strange problem, but having 2 cssgrid groups embedded in a dialog means you have rendering problems. Is that reasonable bug?
          Hide
          jkneal Jerry Neal (Inactive) added a comment -

          Good point. I was thinking it was specific to KCs wizard group, but you are right. It is possible someone could embed two CSS grids in a standard dialog group. We'll test that.

          thanks,
          Jerry

          Show
          jkneal Jerry Neal (Inactive) added a comment - Good point. I was thinking it was specific to KCs wizard group, but you are right. It is possible someone could embed two CSS grids in a standard dialog group. We'll test that. thanks, Jerry
          Hide
          tpaegle Tadas Paegle (Inactive) added a comment -

          Hi Doug,
          I was able to reproduce the issue. Looks like you need <property name="footer.items"> in the dialogGroup or the layout has rendering problems. I will investigate and see if we can fix the requirement of this property to render a dialog properly.

          Tadas

          Show
          tpaegle Tadas Paegle (Inactive) added a comment - Hi Doug, I was able to reproduce the issue. Looks like you need <property name="footer.items"> in the dialogGroup or the layout has rendering problems. I will investigate and see if we can fix the requirement of this property to render a dialog properly. Tadas
          Hide
          tpaegle Tadas Paegle (Inactive) added a comment -

          Added some css to fix float:left issue and re-centered the modal for the page

          Show
          tpaegle Tadas Paegle (Inactive) added a comment - Added some css to fix float:left issue and re-centered the modal for the page

            People

            • Assignee:
              tpaegle Tadas Paegle (Inactive)
              Reporter:
              dpace Douglas Pace
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: