Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-12799

AFT Failure DemoTravelAccountMaintenanceEditAft Blanket Approve doesn't go to FINAL or save changes

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Won't Fix
    • Affects Version/s: 2.4.2
    • Fix Version/s: 2.4.2
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-12777AFT Failure DemoTravelAccountMaintenanceEditAft Confirm prompt then are you sure you want to leave the page and page redirect changed
      KULRICE-12178AFT Failure Identity Blanket Approvals go to ENROUTE rather than FINAL
      KULRICE-13042AFT Failure DemoTravelAccountMaintenanceEditAft Subsidized Percent not saved on Blanket Approve and redirects to Home page
      KULRICE-12500AFT Failure DemoTravelAccountMaintenanceNewAft blanket approve doesn't work and no error message
      KULRICE-12103AFT Failure DemoTravelAccountMaintenanceEditAft no longer displays Save button
      KULRICE-11974AFT Failure DemoTravelAccountMaintenanceEditAft.testDemoTravelAccountMaintenanceEditFiscalOfficerBookmark Fiscal Officer Not Changed
      KULRICE-13895AFT Failure DemoTravelAccountMaintenanceEditAft Duplicate Sub Accounts error message with empty parentheses
      KULRICE-13924AFT Failure DemoTravelAccountMaintenanceEditAft Duplicate Sub Accounts error message with empty parentheses
      KULRICE-12083AFT Failure PeopleFlowCreateNewNavAft.testPeopleFlowBlanketApprove expected FINAL but is ENROUTE
      KULRICE-14170AFT Failure : AgendaEditorAndOrToggleSyncAft
    • Sprint:
      Core 2.5.0-m4 Sprint 1
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required

      Description

      AFT Step: Open /kr-krad/kradsampleapp?viewId=KradSampleAppHome
      AFT Step: Click Travel Account Maintenance (Edit) link.
      Fill in values and press blanket approve, notice no success message, no errors and doc status is not FINAL.
      If you change the Fiscal Officer you will also note it is not changed.

      There is a stack trace in the app log:

      
      
      ERROR org.kuali.rice.krad.web.controller.DocumentControllerBase - Validation Exception occured for document :3086
      org.kuali.rice.krad.exception.ValidationException: Unreported errors occured during business rule evaluation (rule developer needs to put meaningful error messages into global ErrorMap)
      	at org.kuali.rice.krad.maintenance.MaintenanceDocumentBase.validateBusinessRules(MaintenanceDocumentBase.java:895)
      	at org.kuali.rice.krad.service.impl.DocumentServiceImpl.validateAndPersistDocument(DocumentServiceImpl.java:846)
      	at org.kuali.rice.krad.service.impl.DocumentServiceImpl.blanketApproveDocument(DocumentServiceImpl.java:400)
      	at org.kuali.rice.krad.web.controller.DocumentControllerBase.performWorkflowAction(DocumentControllerBase.java:416)
      	at org.kuali.rice.krad.web.controller.DocumentControllerBase.blanketApprove(DocumentControllerBase.java:298)
      	at org.kuali.rice.krad.web.controller.DocumentControllerBase$$FastClassByCGLIB$$dd55d8ad.invoke(<generated>)
      	at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204)
      	at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:698)
      	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
      	at org.springframework.transaction.interceptor.TransactionInterceptor$1.proceedWithInvocation(TransactionInterceptor.java:96)
      	at org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:260)
      	at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:94)
      	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
      	at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
      	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
      	at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:631)
      	at org.kuali.rice.krad.web.controller.MaintenanceDocumentController$$EnhancerByCGLIB$$12766311.blanketApprove(<generated>)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:606)
      	at org.springframework.web.method.support.InvocableHandlerMethod.invoke(InvocableHandlerMethod.java:219)
      	at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:132)
      	at org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:104)
      	at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandleMethod(RequestMappingHandlerAdapter.java:745)
      	at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:686)
      	at org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:80)
      	at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:925)
      	at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:856)
      	at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:936)
      	at org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:838)
      	at javax.servlet.http.HttpServlet.service(HttpServlet.java:641)
      	at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:812)
      	at javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
      	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:304)
      	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
      	at org.kuali.rice.krad.web.filter.CharsetFilter.doFilter(CharsetFilter.java:58)
      	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
      	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
      	at org.kuali.rice.krad.web.filter.UserLoginFilter.doFilter(UserLoginFilter.java:89)
      	at org.kuali.rice.krad.web.filter.UserLoginFilter.doFilter(UserLoginFilter.java:77)
      	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
      	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
      	at org.kuali.rice.krad.web.filter.BootstrapFilterChain.doFilter(BootstrapFilter.java:327)
      	at org.kuali.rice.krad.web.filter.DummyLoginFilter.doFilter(DummyLoginFilter.java:82)
      	at org.kuali.rice.krad.web.filter.DummyLoginFilter.doFilter(DummyLoginFilter.java:62)
      	at org.kuali.rice.krad.web.filter.BootstrapFilterChain.doFilter(BootstrapFilter.java:320)
      	at org.kuali.rice.krad.web.filter.BootstrapFilter.doFilter(BootstrapFilter.java:199)
      	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
      	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
      	at org.kuali.rice.krad.web.filter.UifSessionTimeoutFilter.doFilter(UifSessionTimeoutFilter.java:128)
      	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
      	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
      	at org.kuali.rice.core.web.Log4JContextClearingFilter.doFilterInternal(Log4JContextClearingFilter.java:37)
      	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
      	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
      	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
      	at org.kuali.rice.krad.web.filter.HideWebInfFilter.doFilter(HideWebInfFilter.java:68)
      	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
      	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
      	at org.springframework.web.filter.AbstractRequestLoggingFilter.doFilterInternal(AbstractRequestLoggingFilter.java:213)
      	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
      	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
      	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
      	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:224)
      	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:169)
      	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472)
      	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:168)
      	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:100)
      	at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:929)
      	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
      	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:405)
      	at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:964)
      	at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:515)
      	at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:304)
      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
      	at java.lang.Thread.run(Thread.java:744)
      
      

      DemoTravelAccountMaintenanceEditAft.testDemoTravelAccountMaintenanceEditBookmark
      org.kuali.rice.krad.demo.travel.account.DemoTravelAccountMaintenanceEditAft.testDemoTravelAccountMaintenanceEditBookmark
      http://ci.rice.kuali.org/view/rice-2.4/job/rice-2.4-smoke-test-krad/lastCompletedBuild/testReport/org.kuali.rice.krad.demo.travel.account/DemoTravelAccountMaintenanceEditAft/testDemoTravelAccountMaintenanceEditBookmark/

      DemoTravelAccountMaintenanceEditAft.testDemoTravelAccountMaintenanceEditFiscalOfficerBookmark
      org.kuali.rice.krad.demo.travel.account.DemoTravelAccountMaintenanceEditAft.testDemoTravelAccountMaintenanceEditFiscalOfficerBookmark
      http://ci.rice.kuali.org/view/rice-2.4/job/rice-2.4-smoke-test-krad/lastCompletedBuild/testReport/org.kuali.rice.krad.demo.travel.account/DemoTravelAccountMaintenanceEditAft/testDemoTravelAccountMaintenanceEditFiscalOfficerBookmark/

      DemoTravelAccountMaintenanceEditAft.testDemoTravelAccountMaintenanceEditFiscalOfficerNav
      org.kuali.rice.krad.demo.travel.account.DemoTravelAccountMaintenanceEditAft.testDemoTravelAccountMaintenanceEditFiscalOfficerNav
      http://ci.rice.kuali.org/view/rice-2.4/job/rice-2.4-smoke-test-krad/lastCompletedBuild/testReport/org.kuali.rice.krad.demo.travel.account/DemoTravelAccountMaintenanceEditAft/testDemoTravelAccountMaintenanceEditFiscalOfficerNav/

      DemoTravelAccountMaintenanceEditAft.testDemoTravelAccountMaintenanceEditNav
      org.kuali.rice.krad.demo.travel.account.DemoTravelAccountMaintenanceEditAft.testDemoTravelAccountMaintenanceEditNav
      http://ci.rice.kuali.org/view/rice-2.4/job/rice-2.4-smoke-test-krad/lastCompletedBuild/testReport/org.kuali.rice.krad.demo.travel.account/DemoTravelAccountMaintenanceEditAft/testDemoTravelAccountMaintenanceEditNav/

        Issue Links

          Activity

          Hide
          Shannon Hess added a comment -

          These tests were failing due to testTravelAccountMaintenanceEdit() trying to both submit and blanketapprove the document. I split out the blanket approve into a separate test and committed the fix on the 2.4 branch.

          Show
          Shannon Hess added a comment - These tests were failing due to testTravelAccountMaintenanceEdit() trying to both submit and blanketapprove the document. I split out the blanket approve into a separate test and committed the fix on the 2.4 branch.
          Hide
          Shannon Hess added a comment -

          I committed changes to fix the issue but noticed that there are still issues with the test in the CI environment.

          Show
          Shannon Hess added a comment - I committed changes to fix the issue but noticed that there are still issues with the test in the CI environment.
          Hide
          Erik Meade added a comment -

          A new one:

          Abbreviated test name: DemoTravelAccountMaintenanceEditAft.testDemoTravelAccountMaintenanceEditBlanketApproveNav
          Full test name: org.kuali.rice.krad.demo.travel.account.DemoTravelAccountMaintenanceEditAft.testDemoTravelAccountMaintenanceEditBlanketApproveNav
          Test results url: http://ci.rice.kuali.org/job/rice-2.4-smoke-test-krad/lastCompletedBuild/testReport/org.kuali.rice.krad.demo.travel.account/DemoTravelAccountMaintenanceEditAft/testDemoTravelAccountMaintenanceEditBlanketApproveNav/
          Error Message: BlanketApprove was not successful. subsidizedPercent should be 42

          Abbreviated test name: DemoTravelAccountMaintenanceEditAft.testDemoTravelAccountMaintenanceEditBlanketApproveBookmark
          Full test name: org.kuali.rice.krad.demo.travel.account.DemoTravelAccountMaintenanceEditAft.testDemoTravelAccountMaintenanceEditBlanketApproveBookmark
          Test results url: http://ci.rice.kuali.org/job/rice-2.4-smoke-test-krad/lastCompletedBuild/testReport/org.kuali.rice.krad.demo.travel.account/DemoTravelAccountMaintenanceEditAft/testDemoTravelAccountMaintenanceEditBlanketApproveBookmark/
          Error Message: BlanketApprove was not successful. subsidizedPercent should be 42

          Show
          Erik Meade added a comment - A new one: Abbreviated test name: DemoTravelAccountMaintenanceEditAft.testDemoTravelAccountMaintenanceEditBlanketApproveNav Full test name: org.kuali.rice.krad.demo.travel.account.DemoTravelAccountMaintenanceEditAft.testDemoTravelAccountMaintenanceEditBlanketApproveNav Test results url: http://ci.rice.kuali.org/job/rice-2.4-smoke-test-krad/lastCompletedBuild/testReport/org.kuali.rice.krad.demo.travel.account/DemoTravelAccountMaintenanceEditAft/testDemoTravelAccountMaintenanceEditBlanketApproveNav/ Error Message: BlanketApprove was not successful. subsidizedPercent should be 42 Abbreviated test name: DemoTravelAccountMaintenanceEditAft.testDemoTravelAccountMaintenanceEditBlanketApproveBookmark Full test name: org.kuali.rice.krad.demo.travel.account.DemoTravelAccountMaintenanceEditAft.testDemoTravelAccountMaintenanceEditBlanketApproveBookmark Test results url: http://ci.rice.kuali.org/job/rice-2.4-smoke-test-krad/lastCompletedBuild/testReport/org.kuali.rice.krad.demo.travel.account/DemoTravelAccountMaintenanceEditAft/testDemoTravelAccountMaintenanceEditBlanketApproveBookmark/ Error Message: BlanketApprove was not successful. subsidizedPercent should be 42
          Hide
          Shannon Hess added a comment -

          These test failures and the failures in KULRICE-12825 are due to the travel account create date being null in the database. They were working for me locally because I was running them against 2.5 data. When I updated my database to the 2.4 data, I realized they are failing because the fix for KULRICE-12713 was only made to 2.5. These tests are still not passing locally running with 2.5 due to the direct inquiry link being missing. However, they are passing if I run them using the 2.4 code against the 2.5 data.

          I assume that no database changes are being made in 2.4, but I'll verify with Kristina and see how she would like me to fix this issue for 2.4.

          Show
          Shannon Hess added a comment - These test failures and the failures in KULRICE-12825 are due to the travel account create date being null in the database. They were working for me locally because I was running them against 2.5 data. When I updated my database to the 2.4 data, I realized they are failing because the fix for KULRICE-12713 was only made to 2.5. These tests are still not passing locally running with 2.5 due to the direct inquiry link being missing. However, they are passing if I run them using the 2.4 code against the 2.5 data. I assume that no database changes are being made in 2.4, but I'll verify with Kristina and see how she would like me to fix this issue for 2.4.
          Hide
          Shannon Hess added a comment - - edited

          These tests have been failing for a long time (except between May 29th and June 4th - see note below for why that was the case.), going back to when the tests first started having failures on May 19.

          NOTE – As to why these tests were not failing between May 29th and June 4th, it was due to a bug in the code that was defaulting values during edits. The fix for KULRICE-12734 (Update default values to use a boolean variable rather than a list) was committed on May 29th, which caused edit screens to always apply default values including the create date when editing a travel account. It also applied defaults for items that should not be defaulted such as unique IDs. KULRICE-12782 fixed that issue on June 4th, so the tests went back to failing as before.

          I talked to Erik about this issue and the potential fixes. His feeling is that since things work in 2.5 and this would be difficult to fix without a database update in 2.4, we should leave the tests broke in 2.4.

          Show
          Shannon Hess added a comment - - edited These tests have been failing for a long time (except between May 29th and June 4th - see note below for why that was the case.), going back to when the tests first started having failures on May 19. NOTE – As to why these tests were not failing between May 29th and June 4th, it was due to a bug in the code that was defaulting values during edits. The fix for KULRICE-12734 (Update default values to use a boolean variable rather than a list) was committed on May 29th, which caused edit screens to always apply default values including the create date when editing a travel account. It also applied defaults for items that should not be defaulted such as unique IDs. KULRICE-12782 fixed that issue on June 4th, so the tests went back to failing as before. I talked to Erik about this issue and the potential fixes. His feeling is that since things work in 2.5 and this would be difficult to fix without a database update in 2.4, we should leave the tests broke in 2.4.

            People

            • Assignee:
              Shannon Hess
              Reporter:
              Erik Meade
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 4 hours
                4h
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours
                4h

                  Agile

                    Structure Helper Panel