Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-1281

There are 2 RiceConstants classes, remove/rename one of them

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.3
    • Component/s: Development
    • Labels:
      None
    • Similar issues:
      KULRICE-1290Remove/Rename all references to "eden", "en", "Onestart"
      KULRICE-2878Remove configuration parameter constants from Config onto appropriate constants classes
      KULRICE-4881Clean up utility classes
      KULRICE-13824Identify Smoke Test that create unique names, ids, etc. things that make them fail when run a second time add ITUtil.createUniqueDtsPlusTwoRandomChars to them
      KULRICE-649Channels - Should channels that are "subscribable" allow messages with no recipients if no one is subscribed to them?
      KULRICE-2926Verify that common Date and Time formats are being used at the UI layer across all modules
      KULRICE-3790Consolidate the two Criteria.java classes under one Criteria interface.
      KULRICE-9528Document how KRAD handles it's own internal classes (doc header, etc.) in terms of managing them in their own persistence unit
      KULRICE-13069Rename ReferencedDataObjects and CollectionDataObject classes
    • Rice Module:
      Rice Core
    • Application Requirement:
      Rice

      Description

      This is confusing, it should be corrected.

      I marked this as forced change because if we rename one of these than an application will need to fix any references they had to the original.

        Issue Links

          Activity

          Hide
          Aaron Godert (Inactive) added a comment -

          Is this left-over from the KNS extraction, or due to the change that Aaron H had to make because of the KEN and KEW label differences?

          Show
          Aaron Godert (Inactive) added a comment - Is this left-over from the KNS extraction, or due to the change that Aaron H had to make because of the KEN and KEW label differences?
          Hide
          Aaron Godert (Inactive) added a comment -

          Adding Nate since he was part of the extraction effort as well.

          Show
          Aaron Godert (Inactive) added a comment - Adding Nate since he was part of the extraction effort as well.
          Hide
          Aaron Godert (Inactive) added a comment -

          Hi George. Give this one a shot. If you have any questions, feel free to talk with Eric since he reported it.

          We'll need to account for upgrade documentation in the appropriate release notes under the upgrade section at the bottom of the page.

          You should also guesstimate what the time commitment will be on other applications parts to change their references. With the refactoring/replace tool in Eclipse, I would expect it to be constant regardless of how may references they have.

          Thanks!

          Show
          Aaron Godert (Inactive) added a comment - Hi George. Give this one a shot. If you have any questions, feel free to talk with Eric since he reported it. We'll need to account for upgrade documentation in the appropriate release notes under the upgrade section at the bottom of the page. You should also guesstimate what the time commitment will be on other applications parts to change their references. With the refactoring/replace tool in Eclipse, I would expect it to be constant regardless of how may references they have. Thanks!
          Hide
          Eric Westfall added a comment -

          If there are any KFS-specific constants in this file that need to be removed, we need to determine whether or not KFS is referencing them in their code.

          Show
          Eric Westfall added a comment - If there are any KFS-specific constants in this file that need to be removed, we need to determine whether or not KFS is referencing them in their code.
          Hide
          David Elyea added a comment -

          Work done in main 0.9.3 branch:

          1. Removed org.kuali.rice.RiceConstants (from /core/src/main/java)

          • Added org.kuali.rice.util.RiceConstants (to /core/src/main/java) - some global defaults went here like Date Formatters and Spring setup config parameter names
          • Added org.kuali.rice.ksb.util.KSBConstants (to /ksb/src/main/java) - most constants went here as they were KSB specific
            2. Removed org.kuali.RiceConstants (from /kns/src/main/java)
          • Added org.kuali.rice.kns.util.KNSConstants (to /kns/src/main/java) - direct copy of original RiceConstants file
          • Altered new KNSConstants file so that no KFS specific constants are contained within
          • Moved constant MAPPING_BASIC to org.kuali.rice.util.RiceConstants file - "basic" forward key used by most rice module struts-config files
            3. Deleted org.kuali.core.JstlConstants (from /kns/src/main/java)
          • Altered org.kuali.rice.util.JSTLConstants to include static, final and non-private fields (used to be final and non-private fields only)
          Show
          David Elyea added a comment - Work done in main 0.9.3 branch: 1. Removed org.kuali.rice.RiceConstants (from /core/src/main/java) Added org.kuali.rice.util.RiceConstants (to /core/src/main/java) - some global defaults went here like Date Formatters and Spring setup config parameter names Added org.kuali.rice.ksb.util.KSBConstants (to /ksb/src/main/java) - most constants went here as they were KSB specific 2. Removed org.kuali.RiceConstants (from /kns/src/main/java) Added org.kuali.rice.kns.util.KNSConstants (to /kns/src/main/java) - direct copy of original RiceConstants file Altered new KNSConstants file so that no KFS specific constants are contained within Moved constant MAPPING_BASIC to org.kuali.rice.util.RiceConstants file - "basic" forward key used by most rice module struts-config files 3. Deleted org.kuali.core.JstlConstants (from /kns/src/main/java) Altered org.kuali.rice.util.JSTLConstants to include static, final and non-private fields (used to be final and non-private fields only)

            People

            • Assignee:
              David Elyea
              Reporter:
              Eric Westfall
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Structure Helper Panel