Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-12850

Highlighting for existing accountType is incorrect when it has a default Existence Check

    Details

    • Type: Bug Fix
    • Status: Closed
    • Priority: Major
    • Resolution: Cannot Reproduce
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Sprint:
      Core 2.5.0-m6 Sprint 1
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes
    • Story Points:
      1

      Description

      IMPORTANT NOTE – This is only the case for highlighting the accountType field. For example, If I indicate that the Subsidized Percent should be highlighted if the account type is not found, it is correctly highlighted. It has to do with the field having two parts (input and lookup)

      • After you hit submit once, the popup error message appears if you roll over the account type. ("after hitting submit once" screenshot)
      • After you hit submit twice, the popup error message is still there and high level message appear. ("after hitting submit twice" screenshot)
      • If you change the html so the uif-hasError class is on the input-group div rather than the field div, the field has the red border that is expected. ("Manually moving uif-hasError to input-group" screenshot)

      The code that controls where the uif-hasError class is added is in krad.validate.js in the writeMessagesAtField function

      else {
         field.addClass(kradVariables.HAS_ERROR_CLASS);
         if (showImage) {
            jQuery(messagesDiv).before(errorImage);
         }
      }
      

        Attachments

          Issue Links

            Activity

            Hide
            jruch Jeff Ruch added a comment -

            Looks like this may already be fixed. The demo now uses radio buttons, so I tested with the Labs - Maintenance Demos - Existence Check. The link is

            http://env14.rice.kuali.org/kr-krad/maintenance?methodToCall=start&dataObjectClassName=org.kuali.rice.krad.demo.travel.dataobject.TravelAccount&viewId=LabsMaintenance-ExistenceCheck

            Shannon, can you confirm this is resolved?

            Show
            jruch Jeff Ruch added a comment - Looks like this may already be fixed. The demo now uses radio buttons, so I tested with the Labs - Maintenance Demos - Existence Check. The link is http://env14.rice.kuali.org/kr-krad/maintenance?methodToCall=start&dataObjectClassName=org.kuali.rice.krad.demo.travel.dataobject.TravelAccount&viewId=LabsMaintenance-ExistenceCheck Shannon, can you confirm this is resolved?
            Hide
            shahess Shannon Hess added a comment - - edited

            Sure, I'll verify that I can no longer reproduce this and let you know.

            Show
            shahess Shannon Hess added a comment - - edited Sure, I'll verify that I can no longer reproduce this and let you know.
            Hide
            shahess Shannon Hess added a comment -

            Attaching screenprint of correct screen. All looks good now! Magically fixed - the best kind of jira.

            Show
            shahess Shannon Hess added a comment - Attaching screenprint of correct screen. All looks good now! Magically fixed - the best kind of jira.

              People

              • Assignee:
                jruch Jeff Ruch
                Reporter:
                shahess Shannon Hess
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h