Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-14165Super User Validations on Documents
      KULRICE-7799Create a separate permission for accessing the new super user tab
      KULRICE-7719Missing buttons on Super User Approval Tab
      KULRICE-8300problems with implementation of super user tab
      KULRICE-8658KC super user action tab open by default and does not show up until document is reloaded.
      KULRICE-7840Validation doesn't appear to be done correctly when completing a doc via the Super User Action tab
      KULRICE-8252Permission check for super user tab seems to be using the wrong namespace
      KULRICE-13077Investigate Implementing Super User Screen
      KULRICE-12866Implement Super User Functionality in KRAD
      KULRICE-7938Data for Creating a separate permission for accessing the new super user tab
    • Epic Link:
    • Sprint:
      Core 2.5.0-m6 Sprint 1, Core 2.5.0-m6 Sprint 2
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes
    • Story Points:
      5

      Description

      Super User needs AFTs written against it. The way to get the tab to show up on the interface is to be admin and submit a document with an ad-hoc user added. The following scenarios need to be tested:

      1. Submitted document throw an error when the annotation is not filled in while acted upon (Take Action, Approve, Disapprove)
      2. Submitted document throws an error when no checkbox is selected and the user presses the Take Action button
      3. Submitted document throws an error when a checkbox is selected and the user presses the Approve and Disapprove buttons
      4. Submitted document routes successfully on Take Action
      5. Submitted document routes successfully on Approve
      6. Submitted document routes successfully on Disapprove
      7. Super User tab does not show up when regular user (edna) routes the document
      8. Actions do not show up if there are no actions to perform. (After a single request like an FYI has been super user performed but the document has not been finalized, then there should be no more actions to perform.)

        Issue Links

          Activity

          Hide
          Shannon Hess added a comment -

          1 - 7 have been completed:

          1. Submitted doc throws an error when the annotation is not filled in (Take Action, Approve, Disapprove) - testDemoTravelCompanySuperUserErrors
          2. Submitted doc throws an error when no checkbox is selected and the user presses the Take Action button - testDemoTravelCompanySuperUserTakeActions
          3. Submitted doc throws an error when a checkbox is selected and the user presses the Approve and Disapprove buttons - testDemoTravelCompanySuperUserErrors
          4. Submitted document routes successfully on Take Action - testDemoTravelCompanySuperUserTakeActions
          5. Submitted document routes successfully on Approve - testDemoTravelCompanySuperUserApprove
          6. Submitted document routes successfully on Disapprove - testDemoTravelCompanySuperUserDisapprove
          7. Super User tab does not show up when regular user (edna) routes the document - testDemoTravelCompanySuperUserTabNotAppear

          Kristina – For Number 8 (Actions do not show up if there are no actions to perform), I'm not sure what that means exactly. If there are no actions to perform than the document will be final so the super user tab will not appear. If there is only an FYI or acknowledgement request on the document there will also not be a superuser tab. (I verified this works the same in KNS). Can you give me an example of when the super user tab would appear but there would be no actions to perform?

          Show
          Shannon Hess added a comment - 1 - 7 have been completed: Submitted doc throws an error when the annotation is not filled in (Take Action, Approve, Disapprove) - testDemoTravelCompanySuperUserErrors Submitted doc throws an error when no checkbox is selected and the user presses the Take Action button - testDemoTravelCompanySuperUserTakeActions Submitted doc throws an error when a checkbox is selected and the user presses the Approve and Disapprove buttons - testDemoTravelCompanySuperUserErrors Submitted document routes successfully on Take Action - testDemoTravelCompanySuperUserTakeActions Submitted document routes successfully on Approve - testDemoTravelCompanySuperUserApprove Submitted document routes successfully on Disapprove - testDemoTravelCompanySuperUserDisapprove Super User tab does not show up when regular user (edna) routes the document - testDemoTravelCompanySuperUserTabNotAppear Kristina – For Number 8 (Actions do not show up if there are no actions to perform), I'm not sure what that means exactly. If there are no actions to perform than the document will be final so the super user tab will not appear. If there is only an FYI or acknowledgement request on the document there will also not be a superuser tab. (I verified this works the same in KNS). Can you give me an example of when the super user tab would appear but there would be no actions to perform?
          Hide
          Kristina Taylor (Inactive) added a comment -

          If it's working like that in the KNS, then case 8 is probably invalid.

          Show
          Kristina Taylor (Inactive) added a comment - If it's working like that in the KNS, then case 8 is probably invalid.
          Hide
          Shannon Hess added a comment -

          Ok, in that case I won't add a test for number 8.

          It looks like most of the tests are failing in the CI environment, looking into that now.

          Link to latest tests - https://ci.kuali.org/view/rice/view/2.5/view/list/job/rice-2.5-test-functional-env14-jenkins-krad-sampleapp/lastCompletedBuild/testReport/org.kuali.rice.krad.demo.travel.application/DemoTravelCompanySuperUserTabAft/

          Show
          Shannon Hess added a comment - Ok, in that case I won't add a test for number 8. It looks like most of the tests are failing in the CI environment, looking into that now. Link to latest tests - https://ci.kuali.org/view/rice/view/2.5/view/list/job/rice-2.5-test-functional-env14-jenkins-krad-sampleapp/lastCompletedBuild/testReport/org.kuali.rice.krad.demo.travel.application/DemoTravelCompanySuperUserTabAft/
          Hide
          Shannon Hess added a comment -

          I committed a fix for the failing tests and will resolve this ticket after the next CI run if they are all successful.

          Show
          Shannon Hess added a comment - I committed a fix for the failing tests and will resolve this ticket after the next CI run if they are all successful.
          Hide
          Shannon Hess added a comment -

          Resolving this issue since all tests are now passing in CI

          Show
          Shannon Hess added a comment - Resolving this issue since all tests are now passing in CI

            People

            • Assignee:
              Shannon Hess
              Reporter:
              Kristina Taylor (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 2 hours, 10 minutes
                1d 2h 10m

                  Agile

                    Structure Helper Panel