Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-13177

DEFAULT_APPROVE policy is not working as documented

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.1
    • Fix Version/s: 2.5.1
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-7855NOTIFY_PENDING_ON_RETURN Policy (related to Recall from routing functionality) doesn't appear to be inherited
      KULRICE-6106Document new Document Type policy for enroute error suppression
      KULRICE-2453Remove the PRE_APPROVE document type policy
      KULRICE-3969Action policy code of ALL didn't work for responsibility assigned to a Group
      KULRICE-1836Create a Document Type policy which will force documents clicked on in super user search to forward back to the application's doc handler URL
      KULRICE-812EN-548 Document the SUPPORTS_QUICK_INITIATE document type policy
      KULRICE-6015Document the various Rice KIM permissions
      KULRICE-2462Create a system parameter to allow for turning on of KIM permission priority over Document Type policy
      KULRICE-5978Create new Document Type policy for enroute error suppression
      KULRICE-261Document enhancement for hiding search criteria fields - per the Rice Enhancement policy documentation
    • Rice Team:
      Middleware
    • Rice Module:
      KEW
    • Sprint:
      Middleware 2.5.1 Sprint 1
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes
    • Story Points:
      5

      Description

      From the rice.collab list:

      I had a question about how the DEFAULT_APPROVE document type policy should work. I thought I recalled that setting the DEFAULT_APPROVE doc type policy to ‘false’ would then throw my document into EXCEPTION status if no Approval requests were generated by the various route nodes, but in Rice 2.4.1 we’re not seeing that.

      I looked at the StandardWorkflowEngine class, and in the method checkDefaultApprovalPolicy(DocumentRouteHeaderValue) it appears that the system is checking to see that there is ANY ActionRequest that is both “Done” and is “an approve or complete” request. The problem with that is when a document in KEW is SAVED it creates a COMPLETE action request and in our case that one request seems to satisfy the DEFAULT_APPROVE policy. Is that the desired operation? Is there another document type policy that I should be using to verify that an approval request is generated? I know about the mandatoryRoute stuff but I was hoping for something on the document type that wasn’t node specific.

      Any help is much appreciated! Thanks!

      David

      And from the Rice documentation:

      The DEFAULT_APPROVE policy determines whether a document will continue processing with or without any approval requests. If a document is set to have no approval requests, its put into exception routing. Then, the document will continue to route to the exception workgroup associated with the last route node or to the workgroup defined in the defaultExceptionWorkgroupname.

      So based on what David is seeing, this looks like a bug since there are no approval requests, and yet the document does not go into exception routing.

        Activity

        Hide
        Shannon Hess added a comment -

        I was able to reproduce this issue by setting the DEFAULT_APPROVE policy to false on the ContextMaintenanceDocument document type.

        Before making any changes to checkDefaultApprovalPolicy I was able to get the document to go to final in the following situations:

        – As the initiator, sending an adhoc approve request to the initiator of the document
        – By saving the document before submitting it (as mentioned in the JIRA)

        To me, both of these scenarios seem like ways to get around needing an approval and should not be allowed.

        Show
        Shannon Hess added a comment - I was able to reproduce this issue by setting the DEFAULT_APPROVE policy to false on the ContextMaintenanceDocument document type. Before making any changes to checkDefaultApprovalPolicy I was able to get the document to go to final in the following situations: – As the initiator, sending an adhoc approve request to the initiator of the document – By saving the document before submitting it (as mentioned in the JIRA) To me, both of these scenarios seem like ways to get around needing an approval and should not be allowed.
        Hide
        Shannon Hess added a comment -

        Attaching ContextMaintenanceDocument document type with the DEFAULT_APPROVE policy set to false.

        Show
        Shannon Hess added a comment - Attaching ContextMaintenanceDocument document type with the DEFAULT_APPROVE policy set to false.
        Hide
        Shannon Hess added a comment -

        created https://fisheye.kuali.org/cru/rice-528 for the review and added testing info to RICEQA-311.

        Show
        Shannon Hess added a comment - created https://fisheye.kuali.org/cru/rice-528 for the review and added testing info to RICEQA-311 .
        Hide
        Martin Taylor (Inactive) added a comment -

        Closing 2.5.1 Development

        Show
        Martin Taylor (Inactive) added a comment - Closing 2.5.1 Development

          People

          • Assignee:
            Shannon Hess
            Reporter:
            David Elyea
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Agile

                Structure Helper Panel