Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5.1
    • Component/s: User Experience (UX)
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-13215Create AFT for Quickfinder and Inquiries from within a non-iframe modal dialog
      KULRICE-12928Migrate lookups and inquiries to modal dialogs
      KULRICE-10908Add additionalParameters to quickfinder
      KULRICE-6740Document the UI Framework - Modal Dialog (the back-end to support the Rich Lightbox, Question Framework)
      KULRICE-7300Document the UI Framework - Modal Dialog (the front-end to support the Rich Lightbox, Question Framework)
      KULRICE-7301Document the UI Framework - Modal Dialog (the back-end to support the Rich Lightbox, Question Framework)
      KULRICE-12692Disallow quickfinders with controls other than text and select
      KULRICE-4278Add support for passing parameters to a quickfinder
      KULRICE-9224QuickFinder without Lightbox
      KULRICE-13921Add "Loading" message when returning data from lookup
    • Epic Link:
    • Rice Team:
      Framework
    • Rice Module:
      KRAD
    • Application Requirement:
      KC
    • Sprint:
      UXI 2.5.0-m5 Sprint 1, UXI 2.5.0-m5 Sprint 2, UXI 2.5.0-m6 Sprint 1, UXI 2.5.0-m6 Sprint 2, UXI 2.5.0-m7 Sprint 1, Framework 2.5.1 Sprint 1
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes
    • Story Points:
      2

      Description

      Make that quickfinders and inquiries work with dialogs.

      Example of Inquiries: KRAD Lab -> Inquiries -> Inquiry from dialog
      Example of Lookups: KRAD Lab -> Lookups -> Lookup from Dialog

        Issue Links

          Activity

          Hide
          Claus Niesen added a comment - - edited
          • Modal dialogs did not set the RENDERED_IN_DIALOG flag - fixed locally.
          • quickfinder icon is separate from input text box
            • this is caused by CSS
              • disabling either of the following styles fixes this:
                 
                .uif-cssGridGroup
                .input-group
                   width: 100%
                

                or

                .input-group
                  display: table
                
          • parameter flow is null and causes a null pointer exception
            • because of <input type="hidden" name="flowKey" value=""> which comes from flowKey that isn't set in the kuali form.
          Show
          Claus Niesen added a comment - - edited Modal dialogs did not set the RENDERED_IN_DIALOG flag - fixed locally. quickfinder icon is separate from input text box this is caused by CSS disabling either of the following styles fixes this: .uif-cssGridGroup .input-group width: 100% or .input-group display: table parameter flow is null and causes a null pointer exception because of <input type="hidden" name="flowKey" value=""> which comes from flowKey that isn't set in the kuali form.
          Hide
          Jerry Neal (Inactive) added a comment -

          Some thoughts on implementing:

          • Track whether we have a dialog open (global script var). Set this to the dialog id that is open when showDialog is invoked (however we need to make sure and not do this for lookup/inquiry dialogs)
          • In krad.lookup.js modify the handlers attached to the return value links to call a function that will use postMessage and send back data to the parent. Note currently the handlers are calling local code that attempts to set values through the parent reference, looking for easyxdm frames. This has some problems and I will create a separate issue.
          • The handler that receives the message will do one of three things:
            • if return via script, set the values in the form (like is currently being done by returnLookupResultsByScript). If a dialog was open (global var) replace the modal contents with the contents of that dialog (we need to make sure and not blow the contents away when the call to a lookup is made)
            • if not return via script and a dialog was not open, reload the window as currently is being done by returnLookupResultReload
            • if not return via script and a dialog was open, make an ajax retrieve component call (use retrieveComponent) to refresh the dialog id. The lookup return parameter will need to be stripped from the return URL and passed to the ajax call as well. Finally have a successCallback that will replace the dialog content with the contents for the dialog id
          Show
          Jerry Neal (Inactive) added a comment - Some thoughts on implementing: Track whether we have a dialog open (global script var). Set this to the dialog id that is open when showDialog is invoked (however we need to make sure and not do this for lookup/inquiry dialogs) In krad.lookup.js modify the handlers attached to the return value links to call a function that will use postMessage and send back data to the parent. Note currently the handlers are calling local code that attempts to set values through the parent reference, looking for easyxdm frames. This has some problems and I will create a separate issue. The handler that receives the message will do one of three things: if return via script, set the values in the form (like is currently being done by returnLookupResultsByScript). If a dialog was open (global var) replace the modal contents with the contents of that dialog (we need to make sure and not blow the contents away when the call to a lookup is made) if not return via script and a dialog was not open, reload the window as currently is being done by returnLookupResultReload if not return via script and a dialog was open, make an ajax retrieve component call (use retrieveComponent) to refresh the dialog id. The lookup return parameter will need to be stripped from the return URL and passed to the ajax call as well. Finally have a successCallback that will replace the dialog content with the contents for the dialog id
          Hide
          Gayathri Athreya added a comment - - edited

          The lookup within dialog jira we filed (for 2.5) was closed as duplicate because of this jira but it looks like this jira is slated for 2.5.1. KC needs this asap since a couple of our functionality is blocked from this not working. Can this please be added to 2.5 ?

          Show
          Gayathri Athreya added a comment - - edited The lookup within dialog jira we filed (for 2.5) was closed as duplicate because of this jira but it looks like this jira is slated for 2.5.1. KC needs this asap since a couple of our functionality is blocked from this not working. Can this please be added to 2.5 ?
          Hide
          Claus Niesen added a comment -

          Gayathri, please talk to Matt. Adding this issue to 2.5 will delay the release date.

          Show
          Claus Niesen added a comment - Gayathri, please talk to Matt. Adding this issue to 2.5 will delay the release date.
          Hide
          Gayathri Athreya added a comment -

          OK, will do

          Show
          Gayathri Athreya added a comment - OK, will do
          Hide
          Terry Durkin added a comment -

          This has been an issue we've discussed numerous times with attempts to fix it. Closing the initial report (KULRICE-12545) which was filed in April is not an acceptable solution for KC since we have been working around this problem for months. We need to have it addressed ASAP so we can being to pull out our temporary workarounds. This is at a point where it is causing delays for KC.

          Show
          Terry Durkin added a comment - This has been an issue we've discussed numerous times with attempts to fix it. Closing the initial report ( KULRICE-12545 ) which was filed in April is not an acceptable solution for KC since we have been working around this problem for months. We need to have it addressed ASAP so we can being to pull out our temporary workarounds. This is at a point where it is causing delays for KC.
          Hide
          Claus Niesen added a comment - - edited

          Still some clean up work left to do:

          • Add "Loading" message when returning data from lookup KULRICE-13921
          • Lookup icon in Lookup Collection Edit Line doesn't line up with input field. (see first comment for possible solutions) KULRICE-13922
          • Lookup return doesn't work when using a nested lookup. (The original dialog isn't shown) KULRICE-13923
          Show
          Claus Niesen added a comment - - edited Still some clean up work left to do: Add "Loading" message when returning data from lookup KULRICE-13921 Lookup icon in Lookup Collection Edit Line doesn't line up with input field. (see first comment for possible solutions) KULRICE-13922 Lookup return doesn't work when using a nested lookup. (The original dialog isn't shown) KULRICE-13923
          Hide
          Martin Taylor (Inactive) added a comment -

          Closing 2.5.1 Development

          Show
          Martin Taylor (Inactive) added a comment - Closing 2.5.1 Development

            People

            • Assignee:
              Nisha Gupta (Inactive)
              Reporter:
              Claus Niesen
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Agile

                  Structure Helper Panel