Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-13277

Demo Lookup Search subsidized percent required indicator not appearing for DD entry

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5.1
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-7848Travel Account Document has a NPE on empty subsidized percent
      KULRICE-11421Usability Issue with Travel Account Maintentance Edit: Subsidized Percent
      KULRICE-13078AFT Failure DemoTravelAccountMaintenanceNewAft Incident Report when javascript entered into subsidized percent
      KULRICE-12434Create Travel Account Lookup with advanced features
      KULRICE-12752Travel Account Lookup: Comma appears in lookup criteria on search
      KULRICE-8439Required indicator not appearing on table headers
      KULRICE-13042AFT Failure DemoTravelAccountMaintenanceEditAft Subsidized Percent not saved on Blanket Approve and redirects to Home page
      KULRICE-9375Ranged date field breaks required field indicator and row hiding
      KULRICE-11003Advanced Lookup Demo - Configure basic DD, Maintenance, Lookup & Inquiry for Primary Destination
      KULRICE-11004Advanced Lookup Demo - Configure basic DD, Maintenance, Lookup & Inquiry for Mileage Rate
    • Rice Team:
      Framework
    • Rice Module:
      Rice Core
    • KRAD Feature Area:
      Lookup
    • Application Requirement:
      Rice
    • Sprint:
      Framework 2.5.1 Sprint 3
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes
    • Story Points:
      3

      Description

      Demo -> Lookup -> Search Click edit on entry that has no subsidized percent like on where the Travel Account Type Code is income. Enter description and try to save. The result is that subsidized percent is required even though the required asterisk is not showing up. Looking in the data dictionary, you can see that it is required for all Travel Account Type Codes that are Income. KRAD should be showing this asterisk dynamically.

        Issue Links

          Activity

          Hide
          Steve Edgar (Inactive) added a comment -

          The problem centers around the use of slightly different naming conventions for the “Subsidized Percent” label and its corresponding input field. For Travel Account Maintenance …

          http://localhost:8080/krad-dev/kr-krad/maintenance?viewTypeName=MAINTENANCE&returnLocation=http://localhost:8080/krad-dev/kr-krad/kradsampleapp?viewId&methodToCall=start&dataObjectClassName=org.kuali.rice.krad.demo.travel.dataobject.TravelAccount

          The label is …

          <label id="uedhnkp_label" for=“uedhnkp_control" …

          The input field is…

          <input id="uedhnkp_control" …

          The above works. The asterisk is applied in krad.validate.js in checkForRequiredness(), which relies on the “for” attribute in the label matching the “id” attribute on the input.

          However, if you navigate to the Travel Account Maintenance document as described by Chris in this case, the asterisk will not be applied, as the label is …

          <label id="uedhnkp_comp0_label" for=“uedhnkp_comp0_control" …

          … and the input field is …

          <input id=“uedhnkp_comp1_control" …

          The above maintenance doc has two columns, “Old” and “New”, and so uses a different naming convention.

          I’d like to request a consult on the desired solution (and so am adding Kristina as a watcher), as an existing naming convention is involved, and I’m not sure if creating some type of “special case” in checkForRequiredness() is desired.

          Show
          Steve Edgar (Inactive) added a comment - The problem centers around the use of slightly different naming conventions for the “Subsidized Percent” label and its corresponding input field. For Travel Account Maintenance … http://localhost:8080/krad-dev/kr-krad/maintenance?viewTypeName=MAINTENANCE&returnLocation=http://localhost:8080/krad-dev/kr-krad/kradsampleapp?viewId&methodToCall=start&dataObjectClassName=org.kuali.rice.krad.demo.travel.dataobject.TravelAccount The label is … <label id="uedhnkp_label" for=“uedhnkp_control" … The input field is… <input id="uedhnkp_control" … The above works. The asterisk is applied in krad.validate.js in checkForRequiredness(), which relies on the “for” attribute in the label matching the “id” attribute on the input. However, if you navigate to the Travel Account Maintenance document as described by Chris in this case, the asterisk will not be applied, as the label is … <label id="uedhnkp_comp0_label" for=“uedhnkp_comp0_control" … … and the input field is … <input id=“uedhnkp_comp1_control" … The above maintenance doc has two columns, “Old” and “New”, and so uses a different naming convention. I’d like to request a consult on the desired solution (and so am adding Kristina as a watcher), as an existing naming convention is involved, and I’m not sure if creating some type of “special case” in checkForRequiredness() is desired.
          Hide
          Steve Edgar (Inactive) added a comment - - edited

          As advised, send email to Jerry for possible consult on this case. (This was done Sept, 19.)

          Show
          Steve Edgar (Inactive) added a comment - - edited As advised, send email to Jerry for possible consult on this case. (This was done Sept, 19.)
          Hide
          Martin Taylor (Inactive) added a comment -

          Closing 2.5.1 Development

          Show
          Martin Taylor (Inactive) added a comment - Closing 2.5.1 Development

            People

            • Assignee:
              Jeff Heckel (Inactive)
              Reporter:
              Christopher Wade (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 2 hours
                1d 2h

                  Agile

                    Structure Helper Panel