Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-13898

EditWithDialog with custom dialog removes anything not a datafield or collectiongroup

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5.1
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-13896EditWithDialog fails when collection item contains render flag
      KULRICE-13082Make sortAs on DataField less strict to allow for custom sorts
      KULRICE-13667Create a smoke test for addLinePropertyName and addLineBindingInfo properties of CollectionGroup
      KULRICE-8830Update dialog handler in krad.response.js needs to remove previous dialog data
      KULRICE-14050Remove reuse of 'Uif-Dialogs .modal...' in LibraryCollectionFeaturesEditLineAft
      KULRICE-8977correct schema bean tag attribute for DataField inquiry
      KULRICE-12928Migrate lookups and inquiries to modal dialogs
      KULRICE-12352Remove IU customization for KULRICE-8299
      KULRICE-13301Refresh in Edit dialogs
      KULRICE-14271Blanket approve displays "Confirm Navigation" dialog
    • Rice Team:
      Framework
    • Rice Module:
      KRAD
    • Application Requirement:
      KC
    • Sprint:
      Framework 2.5.1 Sprint 1
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      When using editWithDialog with a custom dialog, items not datafield and collectiongroups are removed. This includes any layout related groupings, messagefields, etc. The following example(kinda complex, sorry), builds an empty dialog as none of the top level elements are any of the included items. Additionally can CollectionGroupLineBuilder be made more customization friendly? No private methods and protected getters for private members?

      	<bean id="PropBudget-SubawardsPage" parent="PropBudget-SubawardsPage-parentBean" />
      	<bean id="PropBudget-SubawardsPage-parentBean" parent="PropBudget-Page">
      		<property name="items">
      			<list>
      				<ref bean="PropBudget-SubawardsPage-CollectionGroup" />
      			</list>
      		</property>
      		<property name="header">
      			<bean parent="Uif-PageHeader" />
      		</property>
      
      	</bean>
      
      	<bean id="PropBudget-SubawardsPage-CollectionGroup"
      		parent="PropBudget-SubawardsPage-CollectionGroup-parentBean" />
      	<bean id="PropBudget-SubawardsPage-CollectionGroup-parentBean"
      		parent="Uif-TableCollectionSection" abstract="true" p:headerText="Subawards"
      		p:propertyName="budget.budgetSubAwards"
      		p:collectionObjectClass="org.kuali.coeus.propdev.impl.budget.subaward.BudgetSubAwards"
      		p:addWithDialog="true" p:layoutManager.renderSequenceField="false"
      		p:editWithDialog="true" p:customEditLineDialog="true">
      		<property name="editLineDialogPrototype">
      			<bean parent="PropBudget-Subawards-Details-Section"/>
      		</property>
      		<property name="layoutManager.richTable.templateOptions">
      			<map>
      				<entry key="sDom" value="tip" />
      				<entry key="bRetrieve" value="true" />
      				<entry key="bPaginate" value="false" />
      				<entry key="bInfo" value="false" />
      			</map>
      		</property>
      		<property name="addWithDialogAction">
      			<bean parent="Uif-AddWithDialogAction" p:actionLabel="Add Subaward" p:cssClasses="pull-right" p:iconClass="icon-plus"/>
      		</property>
      	    <property name="addLineDialog">
      	    	<bean id="PropBudget-SubawardsPage-CollectionGroup-AddDialog" parent="Uif-AddLineDialog" p:headerText="Add Subaward">
      			   <property name="footer.items">
      			     <list>
      			       <bean parent="Uif-DialogDismissButton" p:actionLabel="Cancel"/>
      			       <bean parent="Uif-AddLineAction-Dialog" p:actionLabel="Add Subaward" p:dialogDismissOption="" 
      			       		p:successCallback="Kc.PropDev.Budget.closeDialogWithoutError('PropBudget-SubawardsPage-CollectionGroup-AddDialog');"/>
      			     </list>
      			   </property>	    	    	
      	    	</bean>
      	    </property>
      		<property name="header.lowerGroup">
      			<bean parent="Uif-HeaderLowerGroup">
      				<property name="items">
      					<list>
      						<bean parent="Uif-Message"
      							p:messageText="Upload a pre-formatted budget document for a subawardee organization or enter details manually."
      							p:order="10" />
      					</list>
      				</property>
      			</bean>
      		</property>
      		<property name="addLineItems">
      			<list>
      				<bean parent="Uif-InputField" p:propertyName="organizationId"
      					p:order="10" p:propertyNamesForAdditionalDisplay="organization.organizationName" 
      					p:readOnlyDisplayReplacement="@{#fp.organization?.organizationName} (@{#fp.organizationId})"/>
      				<bean parent="Uif-InputField" p:propertyName="newSubAwardFile" p:label="File Name" 
      					p:order="20">
      					<property name="control">
      						<bean parent="Uif-FileControl"/>
      					</property>
      				</bean>
      				<bean parent="Uif-InputField" p:propertyName="comments" p:order="30" />
      			</list>
      		</property>
      		<property name="items">
      			<list>
      				<bean parent="Uif-DataField" p:propertyName="organizationId"
      					p:order="10" p:readOnlyDisplayReplacement="@{#fp.organization?.organizationName} (@{#fp.organizationId})"/>
      				<bean parent="Uif-DataField" p:propertyName="subAwardXfdFileName" p:label="File Name" 
      					p:order="20" />
      			</list>
      		</property>
      		<property name="lineActions">
      			<list>
      				<bean parent="Uif-DeleteLineAction-IconOnly" p:order="40"
      					p:iconClass="icon-trash" />
      			</list>
      		</property>
      	</bean>
      
      	<bean id="PropBudget-Subawards-Details-Section" parent="PropBudget-Subawards-Details-Section-parent" />
      	<bean id="PropBudget-Subawards-Details-Section-parent"
      		parent="Uif-EditLineDialog" p:headerText="Edit Subaward">
      		<property name="items">
      			<list>
      				<bean parent="Uif-MessageField" p:messageText="This is a test."/>
      				<bean parent="PropBudget-SubawardsAttachments-Buttons-Section" p:order="10" />
      				<bean parent="PropBudget-SubawardsAttachments-Details-Section" p:order="20" />
      			</list>
      		</property>
      	</bean>
      
      	<bean id="PropBudget-SubawardsAttachments-Buttons-Section"
      		parent="PropBudget-SubawardsAttachments-Buttons-Section-parent" />
      	<bean id="PropBudget-SubawardsAttachments-Buttons-Section-parent"
      		parent="Uif-HorizontalFieldGroup" p:label="Attachment Details">
      		<property name="items">
      			<list>
      				<bean p:actionLabel="View PDF" parent="Uif-SecondaryActionButton-Small"
      					p:style="float: right;" p:order="10" />
      				<bean p:actionLabel="View XML" parent="Uif-SecondaryActionButton-Small"
      					p:style="float: right;" p:order="20" />
      				<bean p:actionLabel="Sync from PDF" parent="Uif-SecondaryActionButton-Small"
      					p:style="float: right;" p:order="30" />
      				<bean p:actionLabel="Replace" parent="Uif-SecondaryActionButton-Small"
      					p:style="float: right;" p:order="40" />
      				<bean p:actionLabel="Delete" parent="Uif-SecondaryActionButton-Small"
      					p:style="float: right;" p:order="50" />
      			</list>
      		</property>
      	</bean>
      
      	<bean id="PropBudget-SubawardsAttachments-Details-Section"
      		parent="PropBudget-SubawardsAttachments-Details-Section-parent" />
      	<bean id="PropBudget-SubawardsAttachments-Details-Section-parent"
      		parent="Uif-HorizontalBoxGroup">
      		<property name="items">
      			<list>
      				<bean parent="PropBudget-SubawardsAttachments-Subdetails-Section" p:order="10" />
      				<bean parent="Uif-InputField" p:propertyName="comments" p:order="20"/>
      				<bean p:actionLabel="Edit Comments" parent="Uif-SecondaryActionButton-Mini" p:order="30" p:style="float: left;" />
      				<bean parent="PropBudget-SubawardsAttachments-Details-CollectionGroup" p:order="40" />
      			</list>
      		</property>
      	</bean>
      
      	<bean id="PropBudget-SubawardsAttachments-Subdetails-Section"
      		parent="PropBudget-SubawardsAttachments-Subdetails-Section-parent" />
      	<bean id="PropBudget-SubawardsAttachments-Subdetails-Section-parent"
      		parent="Uif-CssGridSubSection-2FieldLabelColumn">
      		<property name="items">
      			<list>
      				<bean parent="Uif-InputField" p:propertyName="organizationName" p:order="10"/>
      				<bean parent="Uif-InputField" p:propertyName="formName" p:order="20"/>
      				<bean parent="Uif-InputField" p:propertyName="subAwardXfdFileName" p:order="30"/>
      				<bean parent="Uif-InputField" p:propertyName="budgetSubAwardAttachments"
      					p:label="Attachments" p:order="40"/>
      				<bean parent="Uif-InputField" p:propertyName="xfdUpdateTimestamp" p:order="50" />
      				<bean parent="Uif-InputField" p:propertyName="xmlUpdateTimestamp" p:order="60" />
      				<bean parent="Uif-InputField" p:propertyName="subAwardStatusCode" p:order="70" />
      				<bean parent="Uif-InputField" p:propertyName="namespace" p:order="80" />
      			</list>
      		</property>
      	</bean>
      
      	<bean id="PropBudget-SubawardsAttachments-Details-CollectionGroup"
      		parent="PropBudget-SubawardsAttachments-Details-CollectionGroup-parentBean" />
      	<bean id="PropBudget-SubawardsAttachments-Details-CollectionGroup-parentBean"
      		parent="Uif-TableCollectionSection" abstract="true" p:headerText="Details"
      		p:propertyName="newBudgetSubaward"
      		p:collectionObjectClass="org.kuali.coeus.propdev.impl.budget.subaward.BudgetSubAwards"
      		p:addWithDialog="false" p:layoutManager.renderSequenceField="false"
      		p:renderLineActions="false">
      		<property name="layoutManager.richTable.templateOptions">
      			<map>
      				<entry key="sDom" value="tip" />
      				<entry key="bRetrieve" value="true" />
      				<entry key="bPaginate" value="false" />
      				<entry key="bInfo" value="false" />
      			</map>
      		</property>
      		<property name="items">
      			<list>
      				<bean parent="Uif-InputField" p:propertyName="totalDirectCost"
      					p:order="10"/>
      				<bean parent="Uif-InputField" p:propertyName="totalIndirectCost"
      					p:order="20"/>
      				<bean parent="Uif-InputField" p:propertyName="costSharingAmount"
      					p:order="30"/>
      				<bean parent="Uif-InputField" p:propertyName="totalCost"
      					p:label="Total Cost" p:order="40"/>
      			</list>
      		</property>
      	</bean>
      

        Activity

        Hide
        Nisha Gupta (Inactive) added a comment -

        I emailed a patch for this fix to Douglas & Brian. If Douglas tests the patch and it fixes this issue, then I will commit & resolve. I also included a sample demo in the patch that I will commit as well.

        Show
        Nisha Gupta (Inactive) added a comment - I emailed a patch for this fix to Douglas & Brian. If Douglas tests the patch and it fixes this issue, then I will commit & resolve. I also included a sample demo in the patch that I will commit as well.
        Hide
        Martin Taylor (Inactive) added a comment -

        Closing 2.5.1 Development

        Show
        Martin Taylor (Inactive) added a comment - Closing 2.5.1 Development

          People

          • Assignee:
            Nisha Gupta (Inactive)
            Reporter:
            Douglas Pace
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Agile

                Structure Helper Panel