Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5.1
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-7998Rewrite how Dirty Fields Work
      KULRICE-8001Checks not correctly cleared for dirty fields
      KULRICE-7851Dirty field indicator not working on Collections
      KULRICE-2525uncheck 'checkbox' is not working
      KULRICE-6515Dirty fields check does not work for all pages of a view
      KULRICE-8556Progressive disclosure of group/fields within a checkbox or radio group - verify functionality
      KULRICE-7158Validation messaging - single checkbox tooltip persists/open
      KULRICE-7461Validation messaging - single checkbox visual treatment/ border missing
      KULRICE-7212Onclick script not getting associated with correct control ids for checkbox
      KULRICE-7886Clicking on rich labels for checkbox items is not checking the box
    • Rice Team:
      Middleware
    • Rice Module:
      KRAD
    • KRAD Feature Area:
      UIF Script
    • Sprint:
      Middleware 2.5.1 Sprint 2, Middleware 2.5.1 Sprint 3, Middleware 2.5.2 Sprint 1, Middleware 2.5.2 Sprint 2, Middleware 2.5.2 Sprint 3
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes
    • Story Points:
      5

      Description

      Here is the mail I sent to KRAD group.

      On Fri, Oct 17, 2014 at 10:25 AM, Venkatesh Premchandran <venkatp@uw.edu> wrote:
      Hi,
      Looks like the dirty field validation is not happening with checkboxes.. The issue is with DirtyFormState.isControlDirty(). For checkboxes, both 'defaultvalue' and 'value' returns the same data for checkboxes. Here is the change we did to get it working by moving the checkbox validation first. I see it's the same issue with rice 2.5 code base too(krad.dirty.js). Can you please fix at the rice code base for next release.

      //checkbox or radio check
      if ((control.type == "checkbox" || control.type == "radio")) {
      if( control.defaultChecked != undefined && control.checked == control.defaultChecked)

      { fieldDirty = false; }

      } else
      //basic input
      if (control.defaultValue != undefined && control.value == control.defaultValue)

      { fieldDirty = false; }

      Thanks
      Venkat

        Issue Links

          Activity

          Hide
          Kristina Taylor (Inactive) added a comment -

          I suspect that moved code should actually go all the way to the bottom to handle all special cases first.

          Show
          Kristina Taylor (Inactive) added a comment - I suspect that moved code should actually go all the way to the bottom to handle all special cases first.
          Hide
          Shannon Hess added a comment -

          Attaching videos reproducing the issue and also one showing it works after the fix.

          Show
          Shannon Hess added a comment - Attaching videos reproducing the issue and also one showing it works after the fix.
          Hide
          Shannon Hess added a comment -

          There are additional details on the code review - https://fisheye.kuali.org/cru/rice-603

          Show
          Shannon Hess added a comment - There are additional details on the code review - https://fisheye.kuali.org/cru/rice-603
          Hide
          Martin Taylor (Inactive) added a comment -

          Closing 2.5.1 Development

          Show
          Martin Taylor (Inactive) added a comment - Closing 2.5.1 Development

            People

            • Assignee:
              Shannon Hess
              Reporter:
              Venkat PremChandran (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Agile

                  Structure Helper Panel