Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-13996

Problems sending ad hoc group requests on KRAD documents

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.6
    • Fix Version/s: 2.5.1
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-14019Problem With Ad Hoc Group Request Additions
      KULRICE-5386Sending Ad Hoc Requests -provide an error message if there is no user name in Ad Hoc Recipients tab and the "send ad hoc requests" button is clicked.
      KULRICE-3718Allow Ad Hoc action requests on documents with no route nodes
      KULRICE-1156ad hoc route for completion
      KULRICE-3603After a document is saved but before it is routed, the "Future Action Requests" tab on the doc's route log does not display any of the ad hoc requests
      KULRICE-4100send adhoc request button does not validate that a recipient has been entered
      KULRICE-10572KRAD UIF beans and ad hoc person BO have inconsistent interpretations of "id" and "name" properties
      KULRICE-3908Approve fails to clear out saved ad hoc route requests...
      KULRICE-9265Validation change to support ad hoc routing
      KULRICE-7842Ad Hoc Route for Completion recipient does not have the Approve action available in the Action Requested drop down field
    • Rice Team:
      Middleware
    • Rice Module:
      KRAD
    • Sprint:
      Middleware 2.5.1 Sprint 3, Middleware 2.5.2 Sprint 1, Middleware 2.5.2 Sprint 2, Middleware 2.5.2 Sprint 3
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes
    • Story Points:
      3

      Description

      With KRAD documents, if a user adds an ad hoc group request without using the group quickfinder, then that added recipient can prevent the document from saving properly or cause the document to ignore the ad hoc recipient when it gets sent. (Note that this only appears to affect KRAD docs, not KNS ones.)

      One way to fix this is to update the KRAD document controller so that, prior to performing workflow actions, the code will forcibly update each ad hoc group recipient's ID based on the recipient's current name and namespace, provided that such a group exists.

      This issue can be recreated in Kuali Rice Test Drive as follows:

      [1] On the "KRAD" tab, click the "Travel Company" JPA link under the "Legacy Testing" section.

      [2] Click "Search" and then click "edit" on any Travel Company row.

      [3] Enter a document description.

      [4] Add an ad hoc group recipient without using the quickfinder.

      [5] Click either "save" or "submit". Clicking "save" should result in an incident report screen. Clicking "submit" should route the document without sending an ad hoc to the group.

        Activity

        Hide
        Kristina Taylor (Inactive) added a comment -

        Confirmed failing on 2.5.1 in the KRAD Sample App using Travel Account and entering the group "Kuali Developers".

        On save, the relevant stack trace is

        org.kuali.rice.core.api.exception.RiceRuntimeException: Exception trying to invoke action SAVE for document: 3130 at org.kuali.rice.krad.document.DocumentControllerServiceImpl.performWorkflowAction(DocumentControllerServiceImpl.java:879) at org.kuali.rice.krad.document.DocumentControllerServiceImpl.save(DocumentControllerServiceImpl.java:282) at org.kuali.rice.krad.document.DocumentControllerServiceImpl.save(DocumentControllerServiceImpl.java:263) at org.kuali.rice.krad.document.DocumentControllerBase.save(DocumentControllerBase.java:77)
        ...
        Caused by: org.springframework.orm.jpa.JpaSystemException: Exception [EclipseLink-4002] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException Internal Exception: com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: Column 'ACTN_RQST_RECIP_ID' cannot be null Error Code: 1048 Call: INSERT INTO KRNS_ADHOC_RTE_ACTN_RECIP_T (ACTN_RQST_RECIP_ID, ACTN_RQST_CD, DOC_HDR_ID, RECIP_TYP_CD, OBJ_ID) VALUES (?, ?, ?, ?, ?) bind => [5 parameters bound] Query: InsertObjectQuery(org.kuali.rice.krad.bo.AdHocRouteWorkgroup@64cf8777); nested exception is javax.persistence.PersistenceException: Exception [EclipseLink-4002] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException Internal Exception: com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: Column 'ACTN_RQST_RECIP_ID' cannot be null Error Code: 1048 Call: INSERT INTO KRNS_ADHOC_RTE_ACTN_RECIP_T (ACTN_RQST_RECIP_ID, ACTN_RQST_CD, DOC_HDR_ID, RECIP_TYP_CD, OBJ_ID) VALUES (?, ?, ?, ?, ?)
        

        Probably those fields should be required, but also it seems that the blur on the field is not working correctly.

        Show
        Kristina Taylor (Inactive) added a comment - Confirmed failing on 2.5.1 in the KRAD Sample App using Travel Account and entering the group "Kuali Developers". On save, the relevant stack trace is org.kuali.rice.core.api.exception.RiceRuntimeException: Exception trying to invoke action SAVE for document: 3130 at org.kuali.rice.krad.document.DocumentControllerServiceImpl.performWorkflowAction(DocumentControllerServiceImpl.java:879) at org.kuali.rice.krad.document.DocumentControllerServiceImpl.save(DocumentControllerServiceImpl.java:282) at org.kuali.rice.krad.document.DocumentControllerServiceImpl.save(DocumentControllerServiceImpl.java:263) at org.kuali.rice.krad.document.DocumentControllerBase.save(DocumentControllerBase.java:77) ... Caused by: org.springframework.orm.jpa.JpaSystemException: Exception [EclipseLink-4002] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException Internal Exception: com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: Column 'ACTN_RQST_RECIP_ID' cannot be null Error Code: 1048 Call: INSERT INTO KRNS_ADHOC_RTE_ACTN_RECIP_T (ACTN_RQST_RECIP_ID, ACTN_RQST_CD, DOC_HDR_ID, RECIP_TYP_CD, OBJ_ID) VALUES (?, ?, ?, ?, ?) bind => [5 parameters bound] Query: InsertObjectQuery(org.kuali.rice.krad.bo.AdHocRouteWorkgroup@64cf8777); nested exception is javax.persistence.PersistenceException: Exception [EclipseLink-4002] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException Internal Exception: com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: Column 'ACTN_RQST_RECIP_ID' cannot be null Error Code: 1048 Call: INSERT INTO KRNS_ADHOC_RTE_ACTN_RECIP_T (ACTN_RQST_RECIP_ID, ACTN_RQST_CD, DOC_HDR_ID, RECIP_TYP_CD, OBJ_ID) VALUES (?, ?, ?, ?, ?) Probably those fields should be required, but also it seems that the blur on the field is not working correctly.
        Hide
        Kristina Taylor (Inactive) added a comment -

        This issue is critical enough to be entered after the code freeze.

        Show
        Kristina Taylor (Inactive) added a comment - This issue is critical enough to be entered after the code freeze.
        Hide
        Steve Edgar (Inactive) added a comment -

        Fix has been reviewed and committed. There are still some weirdities when using “Add” on ad hoc route workgroups when the QuickFinder is not used, and those will get written up in a new case.

        Show
        Steve Edgar (Inactive) added a comment - Fix has been reviewed and committed. There are still some weirdities when using “Add” on ad hoc route workgroups when the QuickFinder is not used, and those will get written up in a new case.
        Hide
        Martin Taylor (Inactive) added a comment -

        Closing 2.5.1 Development

        Show
        Martin Taylor (Inactive) added a comment - Closing 2.5.1 Development

          People

          • Assignee:
            Steve Edgar (Inactive)
            Reporter:
            Chad Hagstrom
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Agile

                Structure Helper Panel