Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-14034

Blank proposition labels make proposition tree unusable

    Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.5.1
    • Fix Version/s: 2.5.2
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-5904Make Proposition tree control more like the Rule tree control
      KULRICE-5903Text to make it more clear between Rule and Proposition tree sections.
      KULRICE-5180engine results reflect proposition tree
      KULRICE-6011Proposition tree data groups are not showing up
      KULRICE-8270KRMS Agenda Editor: Proposition Tree of Rule does not work properly
      KULRICE-5953Make propositions that are in edit mode easier to select
      KULRICE-13321KRMS agenda editor, field labels not rendered for propositions in edit mode
      KULRICE-5916toggle selection of rule or proposition when clicked a second time
      KULRICE-5954In some cases changing the propositions in a rule doesn't update the proposition summary
      KULRICE-6410ajax refreshes are broken on the agenda tree and the rule (proposition) tree
    • Rice Module:
      KRMS
    • Sprint:
      Middleware 2.5.2 Sprint 2
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes
    • Story Points:
      2

      Description

      In the agenda editor within KRMS:

      When a proposition has a blank description (which can happen a few different ways, but the easiest way to reproduce this might be to edit a proposition, clear it's description, and then click the gear icon on another proposition), it is very difficult to select, because it is the description field which, when clicked on, selects the proposition.

      The attached patch will put a default text string in when a proposition has a blank description in order to give the user an indication that setting a value would be helpful, and also to give them something to click on to select the proposition in the editor.

        Activity

        Peter Giles (Inactive) made changes -
        Field Original Value New Value
        Attachment BlankPropositionLabels_patch.patch [ 88180 ]
        Martin Taylor (Inactive) made changes -
        Fix Version/s 2.5.2 [ 17891 ]
        Martin Taylor (Inactive) made changes -
        Story Points 2
        Claus Niesen made changes -
        Sprint Middleware 2.5.2 Sprint 2 [ 431 ]
        Claus Niesen made changes -
        Rank Ranked lower
        Steve Edgar (Inactive) made changes -
        Assignee Steve Edgar [ sedgar ]
        Hide
        Steve Edgar (Inactive) added a comment -

        Will remove Peter as a watcher (to spare him additional email). Will add Claus. Oh... and Peter... Thanks for the supplied patch!

        Show
        Steve Edgar (Inactive) added a comment - Will remove Peter as a watcher (to spare him additional email). Will add Claus. Oh... and Peter... Thanks for the supplied patch!
        Hide
        Steve Edgar (Inactive) added a comment -

        It appears that one can not save a Rule which contains a Proposition which does not have a description, as the form validation will catch that.

        However, as described in this case, one can create a Proposition which does not have a description, which case you can not go back and edit it, as you "have nothing to click on".

        Peter's supplied patch takes care of this, by inserting the text ":: blank proposition name ::" on the form, but a description supplied by the user will still be required to save the associated Rule (enforced by the form validation). (Thanks Peter!)

        Since this is a minor bug fix, I am assuming no AFT is required, but just want to confirm. Code review has been posted.

        Show
        Steve Edgar (Inactive) added a comment - It appears that one can not save a Rule which contains a Proposition which does not have a description, as the form validation will catch that. However, as described in this case, one can create a Proposition which does not have a description, which case you can not go back and edit it, as you "have nothing to click on". Peter's supplied patch takes care of this, by inserting the text ":: blank proposition name ::" on the form, but a description supplied by the user will still be required to save the associated Rule (enforced by the form validation). (Thanks Peter!) Since this is a minor bug fix, I am assuming no AFT is required, but just want to confirm. Code review has been posted.
        Steve Edgar (Inactive) made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Steve Edgar (Inactive) made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Claus Niesen added a comment -

        Yeah, I think it's fine to skip the AFT for now.

        Show
        Claus Niesen added a comment - Yeah, I think it's fine to skip the AFT for now.
        Eric Westfall made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Steve Edgar (Inactive)
            Reporter:
            Peter Giles (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Agile

                Structure Helper Panel