Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-14037

Apply Jonathan's patch for KFSMI-3654 to 2.1.x code line

    Details

    • Type: Task
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
    • Epic Link:
    • Rice Module:
      KEW
    • Application Requirement:
      KFS
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      Jonathan should have a fix for KFSMI-3654; we just need it applied to Rice.

        Attachments

          Issue Links

            Activity

            jksmith James Smith created issue -
            mztaylor Martin Taylor (Inactive) made changes -
            Field Original Value New Value
            Fix Version/s 2.6 [ 17820 ]
            mztaylor Martin Taylor (Inactive) made changes -
            Labels 201411Requests
            mztaylor Martin Taylor (Inactive) made changes -
            Epic Link KULRICE-14056 [ 149918 ]
            cniesen Claus Niesen made changes -
            Fix Version/s 2.1.10 [ 17909 ]
            Fix Version/s 2.6 [ 17820 ]
            Hide
            cniesen Claus Niesen added a comment -

            Jonathan, can you attach the patch?

            Show
            cniesen Claus Niesen added a comment - Jonathan, can you attach the patch?
            Hide
            jkeller Jonathan Keller added a comment -

            Not as easy as that due to the fact that it was done against KFS. I'm extracting the pieces into a Rice 2.1 branch and then will rebuild a proper patch file.

            Show
            jkeller Jonathan Keller added a comment - Not as easy as that due to the fact that it was done against KFS. I'm extracting the pieces into a Rice 2.1 branch and then will rebuild a proper patch file.
            Hide
            cniesen Claus Niesen added a comment -

            Thanks

            Show
            cniesen Claus Niesen added a comment - Thanks
            cniesen Claus Niesen made changes -
            Assignee Jonathan Keller [ jkeller ]
            Hide
            jkeller Jonathan Keller added a comment -

            Here's the patch - it was only 2 files.

            Show
            jkeller Jonathan Keller added a comment - Here's the patch - it was only 2 files.
            jkeller Jonathan Keller made changes -
            Attachment rice_qualifier_dedupe.patch [ 88582 ]
            Hide
            jksmith James Smith added a comment -

            Cool, thank you Jonathan!

            Show
            jksmith James Smith added a comment - Cool, thank you Jonathan!
            jkeller Jonathan Keller made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            jkeller Jonathan Keller made changes -
            Status In Progress [ 3 ] Resolved [ 5 ]
            Rice Module KIM [ 11060 ] KEW [ 10870 ]
            Resolution Fixed [ 1 ]
            Hide
            cniesen Claus Niesen added a comment -

            Jonathan, we need to patch Rice 2.2 through 2.5 as well. BTW, did you intend to commit the eclipse files?

            Show
            cniesen Claus Niesen added a comment - Jonathan, we need to patch Rice 2.2 through 2.5 as well. BTW, did you intend to commit the eclipse files?
            Hide
            jkeller Jonathan Keller added a comment -

            Yes, I did. I spent more time fighting to try not to include them and generate a patch file which I could re-use. After an hour of that I just checked the files in so I can work in Rice without the overhead of reconfiguring every time.

            As for the other branches - no I have not. I wasn't sure what the process was for that. Manual? Or merge of the 2.1 branch changes forward to the next one?

            Show
            jkeller Jonathan Keller added a comment - Yes, I did. I spent more time fighting to try not to include them and generate a patch file which I could re-use. After an hour of that I just checked the files in so I can work in Rice without the overhead of reconfiguring every time. As for the other branches - no I have not. I wasn't sure what the process was for that. Manual? Or merge of the 2.1 branch changes forward to the next one?
            Hide
            cniesen Claus Niesen added a comment -

            Manual merging is probably best.

            Show
            cniesen Claus Niesen added a comment - Manual merging is probably best.
            Hide
            jkeller Jonathan Keller added a comment -

            Yea - it may take a little to merge it. I realized (after pushing it to 2.1) that I have no way to test it. There is nothing in the KEW integration tests or sample applications which would exercise this code. It's identical to what we have in production at UCD, but I'm not comfortable pushing a change to 4 versions of Rice without some assurance that there is not something stupid in there which might break workflow.

            Now, this is not a blocker from a system operation standpoint. So, do you want me spending my time on that, or integrating into 2.5 only? I figure it will take a number of hours to figure out how to get the needed data and DD files set up within the integration test framework to test this properly.

            Show
            jkeller Jonathan Keller added a comment - Yea - it may take a little to merge it. I realized (after pushing it to 2.1) that I have no way to test it. There is nothing in the KEW integration tests or sample applications which would exercise this code. It's identical to what we have in production at UCD, but I'm not comfortable pushing a change to 4 versions of Rice without some assurance that there is not something stupid in there which might break workflow. Now, this is not a blocker from a system operation standpoint. So, do you want me spending my time on that, or integrating into 2.5 only? I figure it will take a number of hours to figure out how to get the needed data and DD files set up within the integration test framework to test this properly.
            Hide
            jkeller Jonathan Keller added a comment -

            Per discussion - will check in code to 2.1 branch and resolve this JIRA. A new JIRA will be opened to apply the changes to the other Rice versions after KFS has had a chance to test the results.

            Show
            jkeller Jonathan Keller added a comment - Per discussion - will check in code to 2.1 branch and resolve this JIRA. A new JIRA will be opened to apply the changes to the other Rice versions after KFS has had a chance to test the results.
            jkeller Jonathan Keller made changes -
            Link This issue cloned to KULRICE-14099 [ KULRICE-14099 ]
            ewestfal Eric Westfall made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            cniesen Claus Niesen made changes -
            Link This issue relates to KULRICE-14252 [ KULRICE-14252 ]
            cniesen Claus Niesen made changes -
            Fix Version/s 2.1.11 [ 17969 ]
            Fix Version/s 2.1.10 [ 17909 ]
            cniesen Claus Niesen made changes -
            Fix Version/s 2.1.11 [ 17969 ]
            Hide
            cniesen Claus Niesen added a comment -

            This change was rolled back. See KULRICE-14252 for instructions to reapply.

            Show
            cniesen Claus Niesen added a comment - This change was rolled back. See KULRICE-14252 for instructions to reapply.

              People

              • Assignee:
                jkeller Jonathan Keller
                Reporter:
                jksmith James Smith
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: