Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-14041

Maint docs for business objects where notes associated with business object lose notes during ad hoc routing

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
    • Similar issues:
      KULRICE-9287KualiLookupableTest fails in CI with Lookup not defined for business object class org.kuali.rice.krad.test.document.bo.Account
      KULRICE-79enhance notes and attachments to allow association w/ business objects
      KULRICE-6045Add coverage of Externalizable Business Objects to Rice docs
      KULRICE-1156ad hoc route for completion
      KULRICE-10974Advanced Lookup Demo - Create Business Objects
      KULRICE-1312Create Business Objects for KOM
      KULRICE-1551Build KOM business objects
      KULRICE-4736Support for dynamic business objects
      KULRICE-11633Convert core-service business objects from Groovy back to Java
      KULRICE-1482Add new Principal business object
    • Epic Link:
    • Rice Module:
      KNS
    • KRAD Feature Area:
      Maintenance
    • Application Requirement:
      KFS
    • Sprint:
      Middleware 2.5.2 Sprint 4, Middleware 2.5.2 Sprint 5
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes
    • Story Points:
      5

      Description

      In KFS, it appears that on maintenance documents for business objects where notes are associated with the business object not the document, that ad hoc routing loses notes.

      Steps to repro in KFS:

      1. log in as kcopley
      2. on main tab, go to Vendor and create new vendor
      3. last name: Schmoe, first name: Joseph, vendor type: DV, tax number: whatever, tax number type: SSN, ownership: indiv/sole proprietor, add address with address type of RM - REMIT and associate with BL campus.
      4. Submit doc
      5. backdoor as abeal
      6. add note to document
      7. add ad hoc recipient (I used kmoutlaw, it shouldn't matter)
      8. do Ad Hoc Routing button
      9. open document as kmoutlaw; note is missing

      I tried a similar set of steps with the Organization document, which does NOT hold notes at the business object level and that worked just fine.

      1. LegacyTravelCompanyKns.xml
        8 kB
        Shannon Hess
      2. LegacyTravelCompanyOjb.java
        2 kB
        Shannon Hess

        Issue Links

          Activity

          Hide
          James Smith added a comment -

          As with all these KFS requests, we'd love a fix on the Rice 2.1.x line.

          Show
          James Smith added a comment - As with all these KFS requests, we'd love a fix on the Rice 2.1.x line.
          Hide
          James Smith added a comment -

          Added Scott Gibson as a watcher.

          Scott: Muddu said on KFSCNTRB-1355 that UMD may have a patch for this jira. If so, would you be able to share? Thank you....

          Show
          James Smith added a comment - Added Scott Gibson as a watcher. Scott: Muddu said on KFSCNTRB-1355 that UMD may have a patch for this jira. If so, would you be able to share? Thank you....
          Show
          Martin Taylor (Inactive) added a comment - Test on CampusMaintenanceDocument on 2.3 - http://env8.rice.kuali.org/portal.do?channelTitle=Campus&channelUrl=http://env8.rice.kuali.org/kr/lookup.do?methodToCall=start&businessObjectClassName=org.kuali.rice.location.impl.campus.CampusBo&docFormKey=88888888&returnLocation=http://env8.rice.kuali.org/portal.do&hideReturnLink=true and check with Scott
          Hide
          Shannon Hess added a comment - - edited

          I thought I remembered a KNS example of a BO attachment on the portal due to my work on KULRICE-12964 and KULRICE-5363. However, I took a look at KULRICE-12964 and found the following comment: "Currently there is no KNS document that I can test with - I was able to test this issue by modifying LegacyTravelCompanyOjb.java, but I did not make any database changes which would be required to fully test the entire process."

          To fully test any changes made for KULRICE-14041, there would need to be some database changes. I will attach the the changes needed to change the screen and java class. The example document can then be found on the KRAD tab in the Legacy Testing section. http://env1.rice.kuali.org/portal.do?selectedTab=krad

          Also, it would probably be wise to test this process in KRAD as well to make sure a similar problem does not exist. There are KRAD screens that can be found here: http://env14.rice.kuali.org/kr-krad/kradsampleapp?viewId=KradInquirySample-PageR6C3

          Show
          Shannon Hess added a comment - - edited I thought I remembered a KNS example of a BO attachment on the portal due to my work on KULRICE-12964 and KULRICE-5363 . However, I took a look at KULRICE-12964 and found the following comment: "Currently there is no KNS document that I can test with - I was able to test this issue by modifying LegacyTravelCompanyOjb.java, but I did not make any database changes which would be required to fully test the entire process." To fully test any changes made for KULRICE-14041 , there would need to be some database changes. I will attach the the changes needed to change the screen and java class. The example document can then be found on the KRAD tab in the Legacy Testing section. http://env1.rice.kuali.org/portal.do?selectedTab=krad Also, it would probably be wise to test this process in KRAD as well to make sure a similar problem does not exist. There are KRAD screens that can be found here: http://env14.rice.kuali.org/kr-krad/kradsampleapp?viewId=KradInquirySample-PageR6C3
          Hide
          Corey Pedersen (Inactive) added a comment -

          Tested vendor edit maintenance document change, where the change was ad hoc routed for approval to another user (kcopley) who then added a note and ad hoc routed the docuemnt to another(acrowe). The added note was lost in the test.

          Added update to Rice 2.1.10 to track added Notes & Attachments as setNewCollectionRecord(true) for notes which have been added but not yet saved. Upon document save the setNewCollectionRecord property is cleared. Upon "send ad hoc request" the document is saved if any notes have their setNewCollectionRecord property true.

          Pull request " KULRICE-14041 Maint docs for business objects fix for ad hoc routing #7" submitted.

          Show
          Corey Pedersen (Inactive) added a comment - Tested vendor edit maintenance document change, where the change was ad hoc routed for approval to another user (kcopley) who then added a note and ad hoc routed the docuemnt to another(acrowe). The added note was lost in the test. Added update to Rice 2.1.10 to track added Notes & Attachments as setNewCollectionRecord(true) for notes which have been added but not yet saved. Upon document save the setNewCollectionRecord property is cleared. Upon "send ad hoc request" the document is saved if any notes have their setNewCollectionRecord property true. Pull request " KULRICE-14041 Maint docs for business objects fix for ad hoc routing #7" submitted.
          Hide
          Corey Pedersen (Inactive) added a comment -

          pull request merged.

          Show
          Corey Pedersen (Inactive) added a comment - pull request merged.
          Hide
          Claus Niesen added a comment -

          This change was rolled back. See KULRICE-14252 for instructions to reapply.

          Show
          Claus Niesen added a comment - This change was rolled back. See KULRICE-14252 for instructions to reapply.

            People

            • Assignee:
              Corey Pedersen (Inactive)
              Reporter:
              James Smith
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Agile

                  Structure Helper Panel